Re: [ath5k-devel] [PATCH 3/3] ath5k: Add tx power calibration support

2009-03-31 Thread Nick Kossifidis
2009/3/30 Fabio Rossi ross...@inwind.it: On Sunday 29 March 2009, Nick Kossifidis wrote: This patch introduces a function (and some helpers) to set 2 tables on hardware, it doesn't mess with the rest of the driver. I've tested it both on sta and ap scenarios with all the cards i have

Re: [ath5k-devel] [PATCH 3/3] ath5k: Add tx power calibration support

2009-03-31 Thread Nick Kossifidis
2009/3/31 Nick Kossifidis mickfl...@gmail.com: It's weird that your EEPROM contains a value twice, both pwrL[0] and pwrL[1] are 4 so interpolation always returns 4 and tmp is always 1 so you have an endless loop. (still sleeping) it doesn't return 4 (that's the pwr lvl) but the same pcdac

Re: [ath5k-devel] [PATCH 3/3] ath5k: Add tx power calibration support

2009-03-31 Thread Nick Kossifidis
2009/3/31 Nick Kossifidis mickfl...@gmail.com: Anyway since we have such cards we just need to put a check there and where pwrL[0] == pwrL[1], we set tmp = stepL[0] or if pwrR[0] == pwrR[1], we set tmp = stepR[0]. Try this out and see how it goes... (almost there :P) no need to do this, if

Re: [ath5k-devel] [PATCH 3/3] ath5k: Add tx power calibration support

2009-03-31 Thread Fabio Rossi
On Tuesday 31 March 2009, Nick Kossifidis wrote: 2009/3/30 Fabio Rossi ross...@inwind.it: I have discovered the problem. Inside ath5k_hx_txpower() it's called ath5k_setup_channel_powertable() where the gain curves of frequency piers are scanned (if I have understood correctly) to extract

Re: [ath5k-devel] [PATCH 3/3] ath5k: Add tx power calibration support

2009-03-30 Thread Fabio Rossi
On Sunday 29 March 2009, Nick Kossifidis wrote: This patch introduces a function (and some helpers) to set 2 tables on hardware, it doesn't mess with the rest of the driver. I've tested it both on sta and ap scenarios with all the cards i have available and it worked fine. If you want to make

Re: [ath5k-devel] [PATCH 3/3] ath5k: Add tx power calibration support

2009-03-29 Thread Fabio Rossi
On Sunday 15 March 2009, Nick Kossifidis wrote: * Add tx power calibration support * Add a few tx power limits * Hardcode default power to 12.5dB * Disable TPC for now v2: Address Jiri's comments Signed-off-by: Nick Kossifidis mickfl...@gmail.com After bisecting I have found that

Re: [ath5k-devel] [PATCH 3/3] ath5k: Add tx power calibration support

2009-03-29 Thread Nick Kossifidis
2009/3/29 Fabio Rossi ross...@inwind.it: On Sunday 15 March 2009, Nick Kossifidis wrote:  * Add tx power calibration support  * Add a few tx power limits  * Hardcode default power to 12.5dB  * Disable TPC for now  v2: Address Jiri's comments  Signed-off-by: Nick Kossifidis

Re: [ath5k-devel] [PATCH 3/3] ath5k: Add tx power calibration support

2009-03-29 Thread Fabio Rossi
On Sunday 29 March 2009, Nick Kossifidis wrote: I can understand how this patch may have resulted a noise floor calibration timeout but i can't understand how it broke everything else. I've tested it with a very similar card (same MAC and PHY chips but from a different vendor) and it worked

Re: [ath5k-devel] [PATCH 3/3] ath5k: Add tx power calibration support

2009-03-29 Thread Nick Kossifidis
2009/3/29 Fabio Rossi ross...@inwind.it: On Sunday 29 March 2009, Nick Kossifidis wrote: I can understand how this patch may have resulted a noise floor calibration timeout but i can't understand how it broke everything else. I've tested it with a very similar card (same MAC and PHY chips

Re: [ath5k-devel] [PATCH 3/3] ath5k: Add tx power calibration support

2009-03-29 Thread Nick Kossifidis
Does also your board support 802.11abg? I don't understand why the noise calibration process remains stuck @ 5.18GHz. 5.18 is the first channel on 5GHz band and 5GHz band is the band we start with, so it's the first channel the driver sets. My initial thought was that one of the cpus was

[ath5k-devel] [PATCH 3/3] ath5k: Add tx power calibration support

2009-03-15 Thread Nick Kossifidis
* Add tx power calibration support * Add a few tx power limits * Hardcode default power to 12.5dB * Disable TPC for now v2: Address Jiri's comments Signed-off-by: Nick Kossifidis mickfl...@gmail.com --- drivers/net/wireless/ath5k/ath5k.h | 35 +- drivers/net/wireless/ath5k/attach.c |

[ath5k-devel] [PATCH 3/3] ath5k: Add tx power calibration support

2009-03-10 Thread Nick Kossifidis
* Add tx power calibration support * Add a few tx power limits * Hardcode default power to 12.5dB * Disable TPC for now Signed-off-by: Nick Kossifidis mickfl...@gmail.com --- drivers/net/wireless/ath5k/ath5k.h | 35 +- drivers/net/wireless/ath5k/attach.c |2 +

Re: [ath5k-devel] [PATCH 3/3] ath5k: Add tx power calibration support

2009-03-10 Thread Jiri Slaby
On 10.3.2009 11:37, Nick Kossifidis wrote: * Add tx power calibration support * Add a few tx power limits * Hardcode default power to 12.5dB * Disable TPC for now ... diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c index f7c424d..d9f483b 100644

Re: [ath5k-devel] [PATCH 3/3] ath5k: Add tx power calibration support

2009-03-10 Thread Nick Kossifidis
2009/3/10 Jiri Slaby jirisl...@gmail.com: On 10.3.2009 11:37, Nick Kossifidis wrote:  * Add tx power calibration support  * Add a few tx power limits  * Hardcode default power to 12.5dB  * Disable TPC for now ... diff --git a/drivers/net/wireless/ath5k/base.c