Re: [ath5k-devel] [PATCH 3/4] ath5k: Preserve tx power level requested from above on phy_init

2012-07-30 Thread Thomas Huehn
Hi Nick Nick Kossifidis schrieb: > 2012/7/29 Thomas Huehn : >> Hi Nick, >> >> >>> Anyway if readability is the issue we can just do something like >>> >>> int txpower_halfdb = 0; >>> >>> [...] >>> >>> if(ah->power_level) { >>> txpower_halfdb = ah->power_level * 2; >>> } else { >>> txpower_halfd

Re: [ath5k-devel] [PATCH 3/4] ath5k: Preserve tx power level requested from above on phy_init

2012-07-29 Thread Nick Kossifidis
2012/7/29 Thomas Huehn : > Hi Nick, > > >> Anyway if readability is the issue we can just do something like >> >> int txpower_halfdb = 0; >> >> [...] >> >> if(ah->power_level) { >> txpower_halfdb = ah->power_level * 2; >> } else { >> txpower_halfdb = AR5K_TUNE_MAX_TXPOWER; >> } >> >> and then it'

Re: [ath5k-devel] [PATCH 3/4] ath5k: Preserve tx power level requested from above on phy_init

2012-07-29 Thread Thomas Huehn
Hi Nick, > Anyway if readability is the issue we can just do something like > > int txpower_halfdb = 0; > > [...] > > if(ah->power_level) { > txpower_halfdb = ah->power_level * 2; > } else { > txpower_halfdb = AR5K_TUNE_MAX_TXPOWER; > } > > and then it'll look like this > > ret = ath5k_hw

Re: [ath5k-devel] [PATCH 3/4] ath5k: Preserve tx power level requested from above on phy_init

2012-07-28 Thread Nick Kossifidis
2012/7/28 Thomas Huehn : > Let my correct myself > > Thomas Huehn schrieb: > >> Hi Nick, >> >> Nick Kossifidis schrieb: >> >>> By using cur_pwr on phy_init we re-use the power level previously set by the >>> driver, not the one we got from above. >>> >>> Signed-off-by: Nick Kossifidis >>> --- >>>

Re: [ath5k-devel] [PATCH 3/4] ath5k: Preserve tx power level requested from above on phy_init

2012-07-28 Thread Thomas Huehn
Let my correct myself Thomas Huehn schrieb: > Hi Nick, > > Nick Kossifidis schrieb: > >> By using cur_pwr on phy_init we re-use the power level previously set by the >> driver, not the one we got from above. >> >> Signed-off-by: Nick Kossifidis >> --- >> drivers/net/wireless/ath/ath5k/phy.c |

Re: [ath5k-devel] [PATCH 3/4] ath5k: Preserve tx power level requested from above on phy_init

2012-07-28 Thread Thomas Huehn
Hi Nick, Nick Kossifidis schrieb: > By using cur_pwr on phy_init we re-use the power level previously set by the > driver, not the one we got from above. > > Signed-off-by: Nick Kossifidis > --- > drivers/net/wireless/ath/ath5k/phy.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions

[ath5k-devel] [PATCH 3/4] ath5k: Preserve tx power level requested from above on phy_init

2012-07-28 Thread Nick Kossifidis
By using cur_pwr on phy_init we re-use the power level previously set by the driver, not the one we got from above. Signed-off-by: Nick Kossifidis --- drivers/net/wireless/ath/ath5k/phy.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/p