Re: [ath5k-devel] [PATCH 3/5] ath5k: clean up queue manipulation

2010-03-30 Thread Bruno Randolf
On Wednesday 31 March 2010 12:58:47 Bob Copeland wrote: > On Wed, Mar 31, 2010 at 11:02:32AM +0900, Bruno Randolf wrote: > > we have to stop TX while NF calibration. also we need to lock it against > > other uses of reset / calibration. i think this is what gives us the > > problems with 'warm rese

Re: [ath5k-devel] [PATCH 3/5] ath5k: clean up queue manipulation

2010-03-30 Thread Bob Copeland
On Wed, Mar 31, 2010 at 11:02:32AM +0900, Bruno Randolf wrote: > we have to stop TX while NF calibration. also we need to lock it against > other > uses of reset / calibration. i think this is what gives us the problems with > 'warm reset'. afaik other calibration can run in parallel. nick gave

Re: [ath5k-devel] [PATCH 3/5] ath5k: clean up queue manipulation

2010-03-30 Thread Bruno Randolf
On Tuesday 30 March 2010 21:42:30 Bob Copeland wrote: > > > In both cases the first reset works at cross purposes to the > > > goal of pausing transmissions, so nix them. > > > > i don't understand this sentence... > > Instead of "reset" I meant "the first wake_queues". Maybe this is clearer: >

Re: [ath5k-devel] [PATCH 3/5] ath5k: clean up queue manipulation

2010-03-30 Thread Bob Copeland
On Tue, Mar 30, 2010 at 02:40:57PM +0900, Bruno Randolf wrote: > On Monday 29 March 2010 10:42:11 Bob Copeland wrote: > > Review spotted a couple of strange invocations to > > ieee80211_wake_queues that could potentially cause problems: > > > > - queues are awakened in the calibration tasklet bef

Re: [ath5k-devel] [PATCH 3/5] ath5k: clean up queue manipulation

2010-03-29 Thread Bruno Randolf
On Monday 29 March 2010 10:42:11 Bob Copeland wrote: > Review spotted a couple of strange invocations to > ieee80211_wake_queues that could potentially cause problems: > > - queues are awakened in the calibration tasklet before >phy calibration, and then again after calibration > > - queues

[ath5k-devel] [PATCH 3/5] ath5k: clean up queue manipulation

2010-03-28 Thread Bob Copeland
Review spotted a couple of strange invocations to ieee80211_wake_queues that could potentially cause problems: - queues are awakened in the calibration tasklet before phy calibration, and then again after calibration - queues are awakened inside reset when we're trying to drain the ath5k