On Mon, Aug 03, 2009 at 08:54:47PM +0300, Nick Kossifidis wrote:
2009/8/1 Johannes Berg johan...@sipsolutions.net:
On Sat, 2009-08-01 at 10:24 +0200, Jiri Slaby wrote:
On 08/01/2009 10:21 AM, Johannes Berg wrote:
Actually, jiffies are unsigned long
Yeah, this is what I meant. I agree I
2009/8/7 John W. Linville linvi...@tuxdriver.com:
Last I saw in this thread...
Yup, sorry for the delay ;-(
Can we have a clean repost of the whole series (including proper
Signed-off-by and any Acked-by, Tested-by, etc)?
sure
Also, in the future
I think it would be good for you to take
2009/8/1 Johannes Berg johan...@sipsolutions.net:
On Sat, 2009-08-01 at 10:24 +0200, Jiri Slaby wrote:
On 08/01/2009 10:21 AM, Johannes Berg wrote:
Actually, jiffies are unsigned long
Yeah, this is what I meant. I agree I messed it up when I didn't write
the unsigned explicitly. It might
On Sat, Aug 01, 2009 at 04:31:27PM +0300, Nick Kossifidis wrote:
I thought about calling ath5k_hw_stop_rx_pcu but i don't think it's
necessary i mean it won't receive anyway, why mess with pcu ?
Yeah, agreed, we can just ignore rx.
--
Bob Copeland %% www.bobcopeland.com
On 08/01/2009 07:46 AM, Nick Kossifidis wrote:
--- a/drivers/net/wireless/ath/ath5k/phy.c
+++ b/drivers/net/wireless/ath/ath5k/phy.c
@@ -1104,6 +1104,26 @@ int ath5k_hw_channel(struct ath5k_hw *ah, struct
ieee80211_channel *channel)
PHY calibration
\*/
+void
On Sat, 2009-08-01 at 10:19 +0200, Jiri Slaby wrote:
+ u32 current_time = (jiffies / HZ);
jiffies are long. And they start from negative to catch such issues. You
were lucky and/or tested after 5 minutes of uptime ;).
Actually, jiffies are unsigned long, but wrap after 5 minutes of
On 08/01/2009 10:21 AM, Johannes Berg wrote:
Actually, jiffies are unsigned long
Yeah, this is what I meant. I agree I messed it up when I didn't write
the unsigned explicitly. It might have been confusing, thanks for
pointing out.
___
ath5k-devel
On Sat, 2009-08-01 at 10:24 +0200, Jiri Slaby wrote:
On 08/01/2009 10:21 AM, Johannes Berg wrote:
Actually, jiffies are unsigned long
Yeah, this is what I meant. I agree I messed it up when I didn't write
the unsigned explicitly. It might have been confusing, thanks for
pointing out.
And,
2009/8/1 Johannes Berg johan...@sipsolutions.net:
On Sat, 2009-08-01 at 10:24 +0200, Jiri Slaby wrote:
On 08/01/2009 10:21 AM, Johannes Berg wrote:
Actually, jiffies are unsigned long
Yeah, this is what I meant. I agree I messed it up when I didn't write
the unsigned explicitly. It might
On 08/01/2009 10:31 AM, Nick Kossifidis wrote:
2009/8/1 Johannes Berg johan...@sipsolutions.net:
time_is_after_jiffies() or so.
...
Where can i find documentation on this ?
I wouldn't say there is anything else than include/linux/jiffies.h.
___
* Get rid of calibration timer, instead use a software interrupt
to schedule the calibration tasklet.
---
drivers/net/wireless/ath/ath5k/ath5k.h | 16
drivers/net/wireless/ath/ath5k/base.c | 28 ++--
drivers/net/wireless/ath/ath5k/base.h |3
On Fri, Jul 31, 2009 at 11:10 AM, Nick
Kossifidism...@madwifi-project.org wrote:
* Get rid of calibration timer, instead use a software interrupt
to schedule the calibration tasklet.
An example of itemizing one change. Explain the why, not the how.
Luis
2009/7/31 Luis R. Rodriguez mcg...@gmail.com:
On Fri, Jul 31, 2009 at 11:10 AM, Nick
Kossifidism...@madwifi-project.org wrote:
* Get rid of calibration timer, instead use a software interrupt
to schedule the calibration tasklet.
An example of itemizing one change. Explain the why, not the
On Fri, Jul 31, 2009 at 11:25 AM, Nick Kossifidismickfl...@gmail.com wrote:
2009/7/31 Luis R. Rodriguez mcg...@gmail.com:
On Fri, Jul 31, 2009 at 11:10 AM, Nick
Kossifidism...@madwifi-project.org wrote:
* Get rid of calibration timer, instead use a software interrupt
to schedule the
On Fri, 2009-07-31 at 21:25 +0300, Nick Kossifidis wrote:
a) We don't need a timer for this, there is no need for accuracy
even with round_jiffies i think this is a waste of resources.
Also we don't need to run calibration if we are idle (no interrupts).
It doesn't sound right to me.
On Fri, 2009-07-31 at 22:35 +0300, Nick Kossifidis wrote:
Nope calibration deals mostly with noise immunity, it calculates the
noise floor and fixes QAM constellation. It's not related to the synthesizer
so it's not related to the channel frequency.
OK then, good to know.
--
Regards,
Pavel
* Get rid of calibration timer, instead use a software interrupt
to schedule the calibration tasklet.
a) We don't need a timer for this, there is no need for accuracy
even with round_jiffies i think this is a waste of resources.
Also we don't need to run calibration if we are
17 matches
Mail list logo
