Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-08 Thread Helmut Schaa
Am Donnerstag 07 Oktober 2010 schrieb Johannes Berg: > On Thu, 2010-10-07 at 09:44 +0200, Helmut Schaa wrote: > > > So, I guess it makes sense to just return the calculated channel > > utilization value (u8) > > and keep it up to date within the driver. > > Not good, that means drivers implementi

Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-07 Thread Johannes Berg
On Thu, 2010-10-07 at 09:44 +0200, Helmut Schaa wrote: > So, I guess it makes sense to just return the calculated channel > utilization value (u8) > and keep it up to date within the driver. Not good, that means drivers implementing this will have to wake the CPU to do calculations even if nobody

Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-07 Thread Helmut Schaa
On Thu, Oct 7, 2010 at 9:06 AM, Bruno Randolf wrote: > which units do you have for the busy time? what about other drivers? > in ath[59]k we have it as cycles (which is about 1/44000 of a second, > depending on the mode). so it counts up rather fast. We've got the busy time in [us] since the last

Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-07 Thread Robert Budde
@lists.ath5k.org; linux-wirel...@vger.kernel.org; linvi...@tuxdriver.com; adr...@freebsd.org; vasa...@atheros.com Betreff: Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey On Thu, Oct 7, 2010 at 3:03 AM, Bruno Randolf wrote: > On Wed October 6 2010 18:54:37 Helmut Sc

Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-07 Thread Jonathan Guerin
On Thu, Oct 7, 2010 at 5:06 PM, Bruno Randolf wrote: > On Thu October 7 2010 15:51:49 Helmut Schaa wrote: >> On Thu, Oct 7, 2010 at 3:03 AM, Bruno Randolf wrote: >> > On Wed October 6 2010 18:54:37 Helmut Schaa wrote: >> >> On Tue, Oct 5, 2010 at 11:55 AM, Bruno Randolf wrote: >> >> > This adds

Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-07 Thread Bruno Randolf
On Thu October 7 2010 15:51:49 Helmut Schaa wrote: > On Thu, Oct 7, 2010 at 3:03 AM, Bruno Randolf wrote: > > On Wed October 6 2010 18:54:37 Helmut Schaa wrote: > >> On Tue, Oct 5, 2010 at 11:55 AM, Bruno Randolf wrote: > >> > This adds three new values to the survey results: > >> > > >> > * BU

Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-06 Thread Helmut Schaa
On Thu, Oct 7, 2010 at 3:03 AM, Bruno Randolf wrote: > On Wed October 6 2010 18:54:37 Helmut Schaa wrote: >> On Tue, Oct 5, 2010 at 11:55 AM, Bruno Randolf wrote: >> > This adds three new values to the survey results: >> > >> >  * BUSY - percentage of time the channel was busy >> >  * BUSY_TX - p

Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-06 Thread Luis R. Rodriguez
On Wed, Oct 6, 2010 at 6:03 PM, Bruno Randolf wrote: > On Wed October 6 2010 18:54:37 Helmut Schaa wrote: >> On Tue, Oct 5, 2010 at 11:55 AM, Bruno Randolf wrote: >> > This adds three new values to the survey results: >> > >> >  * BUSY - percentage of time the channel was busy >> >  * BUSY_TX - p

Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-06 Thread Bruno Randolf
On Wed October 6 2010 18:54:37 Helmut Schaa wrote: > On Tue, Oct 5, 2010 at 11:55 AM, Bruno Randolf wrote: > > This adds three new values to the survey results: > > > > * BUSY - percentage of time the channel was busy > > * BUSY_TX - percentage of time spent transmitting frames > > * BUSY_RX -

Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-06 Thread Helmut Schaa
On Tue, Oct 5, 2010 at 11:55 AM, Bruno Randolf wrote: > This adds three new values to the survey results: > >  * BUSY - percentage of time the channel was busy >  * BUSY_TX - percentage of time spent transmitting frames >  * BUSY_RX - percentage of time spent receiving frames Does BUSY include BU

Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-05 Thread Bruno Randolf
On Wed October 6 2010 07:36:30 Luis R. Rodriguez wrote: > On Tue, Oct 5, 2010 at 2:55 AM, Bruno Randolf wrote: > > This adds three new values to the survey results: > > > > * BUSY - percentage of time the channel was busy > > * BUSY_TX - percentage of time spent transmitting frames > > * BUSY_

Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-05 Thread Luis R. Rodriguez
On Tue, Oct 5, 2010 at 2:55 AM, Bruno Randolf wrote: > This adds three new values to the survey results: > >  * BUSY - percentage of time the channel was busy >  * BUSY_TX - percentage of time spent transmitting frames >  * BUSY_RX - percentage of time spent receiving frames > > They are defined t

[ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-05 Thread Bruno Randolf
This adds three new values to the survey results: * BUSY - percentage of time the channel was busy * BUSY_TX - percentage of time spent transmitting frames * BUSY_RX - percentage of time spent receiving frames They are defined to be a percentage of time, normalized to 255. That way they mat