Re: [ath5k-devel] [PATCH 5/5] ath5k: add bounds check to pdadc table

2010-03-29 Thread Bruno Randolf
On Monday 29 March 2010 10:42:13 Bob Copeland wrote: > We check the bounds on pdadc once when correcting for > negative curves but not when we later copy values from > from the pdadc_tmp array, leading to a potential overrun. > > Although we shouldn't hit this case in practice, let's > be consiste

[ath5k-devel] [PATCH 5/5] ath5k: add bounds check to pdadc table

2010-03-28 Thread Bob Copeland
We check the bounds on pdadc once when correcting for negative curves but not when we later copy values from from the pdadc_tmp array, leading to a potential overrun. Although we shouldn't hit this case in practice, let's be consistent. Reported-by: Dan Carpenter Signed-off-by: Bob Copeland ---