Re: [ath5k-devel] [PATCH wireless-next 2/3] ath5k: Introduce _ath5k_printk to reduce code/text

2012-03-19 Thread Adrian Chadd
On 18 March 2012 22:18, Joe Perches j...@perches.com wrote: Otherwise compiling in debugging will cause a _lot_ of spurious register reads to occur that are then tossed. This was one of the big reasons for instability and slow performance when AH_DEBUG was enabled. That doesn't make any

Re: [ath5k-devel] [PATCH wireless-next 2/3] ath5k: Introduce _ath5k_printk to reduce code/text

2012-03-18 Thread Adrian Chadd
Hi, So the reason this is a macro in the FreeBSD HAL is so that the args aren't evaluated unless the level (or debug bitmap in my case) fires off. Otherwise compiling in debugging will cause a _lot_ of spurious register reads to occur that are then tossed. This was one of the big reasons for

Re: [ath5k-devel] [PATCH wireless-next 2/3] ath5k: Introduce _ath5k_printk to reduce code/text

2012-03-18 Thread Joe Perches
On Sun, 2012-03-18 at 21:36 -0700, Adrian Chadd wrote: Hi, Hi Adrian. So the reason this is a macro in the FreeBSD HAL is so that the args aren't evaluated unless the level (or debug bitmap in my case) fires off. Otherwise compiling in debugging will cause a _lot_ of spurious register