2009/4/1 bitbucket :
> 01.04.09, 17:14, "Nick Kossifidis" :
>
>> > /* No correction */
>> > - if (i_coffd == 0 || q_coffd == 0)
>> > + if (i_coffd == 0 || q_coffd < 2)
>> > goto done;
>> >
>> Are you sure that < 2 is ok ?
> Yes. In Sam's hal (madwifi-free) they che
01.04.09, 17:14, "Nick Kossifidis" :
> > /* No correction */
> > - if (i_coffd == 0 || q_coffd == 0)
> > + if (i_coffd == 0 || q_coffd < 2)
> > goto done;
> >
> Are you sure that < 2 is ok ?
Yes. In Sam's hal (madwifi-free) they checked against 0 and >=2 .
> Give
2009/4/1 bitbucket :
> Hello !
>
> I have found bug in I/Q calibration procedure. Because of this bug
> calibration goes wrong, and card receive frames with CRC errors.
> In phy.c/ath5k_hw_rf511x_calibrate()
> i_coff = ((-iq_corr) / i_coffd) & 0x3f;
> but, i_coff is signed 32bit value, but
> Hello !
Sound's cool.
However, to get your patch accepted, you'd need a real-name and a
proper Signed-off-by line.
The real-name is a legal requirement, but apart from legal I
personally find it IRC-kiddy-style to use nicknames in Linux
related mailing list. But thats, as I said it, a matte
Hello !
I have found bug in I/Q calibration procedure. Because of this bug calibration
goes wrong, and card receive frames with CRC errors.
In phy.c/ath5k_hw_rf511x_calibrate()
i_coff = ((-iq_corr) / i_coffd) & 0x3f;
but, i_coff is signed 32bit value, but when masking it with 0x3f it bec
