Re: [ath5k-devel] reset hangs

2008-12-22 Thread Nick Kossifidis
2008/12/22 Bob Copeland : > While looking into http://bugzilla.kernel.org/show_bug.cgi?id=12080 > I noticed that we call reset() from a lot of places without locking: > > - at probe time > - whenever we change channels > - whenever we miss 3 beacons > - whenever a 'bad' interrupt occurs > - wh

Re: [ath5k-devel] reset hangs

2008-12-22 Thread Bob Copeland
On Mon, Dec 22, 2008 at 4:54 PM, Nick Kossifidis wrote: > remains). Can someone work on these locking issues inside base.c to be > safe on the driver side ? Ok, I'll leave the hardware stuff to you and take a look at the driver interface. I think most things can just schedule restq and be done w

Re: [ath5k-devel] reset hangs

2008-12-22 Thread Maxim Levitsky
On Mon, 2008-12-22 at 16:16 -0500, Bob Copeland wrote: > While looking into http://bugzilla.kernel.org/show_bug.cgi?id=12080 > I noticed that we call reset() from a lot of places without locking: > > - at probe time > - whenever we change channels > - whenever we miss 3 beacons > - whenever a

[ath5k-devel] reset hangs

2008-12-22 Thread Bob Copeland
While looking into http://bugzilla.kernel.org/show_bug.cgi?id=12080 I noticed that we call reset() from a lot of places without locking: - at probe time - whenever we change channels - whenever we miss 3 beacons - whenever a 'bad' interrupt occurs - whenever the calibration timer runs and we