[ath9k-devel] [PATCH net-next 00/21] treewide: Use consistent api style for address testing

2012-10-19 Thread Joe Perches
ethernet, ipv4, and ipv6 address testing uses 3 different api naming styles. ethernet uses: is_foo_ether_addr ipv4 uses: ipv4_is_foo ipv6 uses: ipv6_addr_foo Standardize on the ipv6 style of prefix_addr_type to reduce the number of styles to remember. The new consistent styles are:

[ath9k-devel] [PATCH net-next 04/21] wireless: Convert is_foo_ether_addr uses to eth_addr_foo

2012-10-19 Thread Joe Perches
Convert the old ether_addr tests to eth_addr_foo. Adds api consistency. Signed-off-by: Joe Perches j...@perches.com --- drivers/net/wireless/adm8211.c |2 +- drivers/net/wireless/airo.c|4 ++-- drivers/net/wireless/at76c50x-usb.c

Re: [ath9k-devel] [PATCH net-next 00/21] treewide: Use consistent api style for address testing

2012-10-19 Thread Eric Dumazet
On Thu, 2012-10-18 at 20:55 -0700, Joe Perches wrote: ethernet, ipv4, and ipv6 address testing uses 3 different api naming styles. ethernet uses:is_foo_ether_addr ipv4 uses:ipv4_is_foo ipv6 uses:ipv6_addr_foo Standardize on the ipv6 style of prefix_addr_type to reduce the

Re: [ath9k-devel] [PATCH net-next 00/21] treewide: Use consistent api style for address testing

2012-10-19 Thread Joe Perches
(cc list trimmed) On Fri, 2012-10-19 at 11:55 -0400, Pavel Roskin wrote: On Fri, 19 Oct 2012 09:04:14 +0200 Eric Dumazet eric.duma...@gmail.com wrote: Yes they are some names discrepancies, thats a big deal. And we have alloc_skb() / kfree_skb() / skb_clone() Why not skb_alloc()

Re: [ath9k-devel] [PATCH net-next 04/21] wireless: Convert is_foo_ether_addr uses to eth_addr_foo

2012-10-19 Thread Bing Zhao
Hi Joe, Subject: [PATCH net-next 04/21] wireless: Convert is_foo_ether_addr uses to eth_addr_foo Convert the old ether_addr tests to eth_addr_foo. Adds api consistency. Signed-off-by: Joe Perches j...@perches.com Acked-by: Bing Zhao bz...@marvell.com [mwifiex] Thanks, Bing