Re: [ath9k-devel] [RFC 0/2] ath10k: fix qos workaround

Hi Michal, Michal Kazior writes: > On 24/04/13 12:53, Sujith Manoharan wrote: >> Michal Kazior wrote: >>> >From what I've observed so far is frames in >>> monitor mode (non promiscuous) are corrupted. They >>> have the QoS Control stripped, with LLC header >>> finding itself in the QoS Control.

Re: [ath9k-devel] [PATCH v2 1/3] ath10k: WMI API updates

Sujith Manoharan writes: > Sujith Manoharan wrote: >> From: Sujith Manoharan >> >> To sync with new FW ver .614 > > A rebased patch below. > (Also, > http://msujith.org/patches/wl/Apr-24-2013/0005-ath10k-WMI-API-updates.patch). > > Sujith > > [PATCH] ath10k: WMI API updates > > To sync with ne

Re: [ath9k-devel] [PATCH] ath10k: Handle P2P_GO NOA notification FW 599+

Janusz Dziedzic writes: > In FW 599+ NOA structure was changed. So we have > to change this in case of using newest firmware. > > Signed-off-by: Janusz Dziedzic Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org

Re: [ath9k-devel] [PATCH] ath10k: fix supported band setup

Michal Kazior writes: > This fixes a crash and a possible memleak. > > Signed-off-by: Michal Kazior Damn, I broke this. Sorry about it. Applied, thank you for fixing my bug! -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org http

Re: [ath9k-devel] Where is done the distintion between AP and mesh/adhoc on ath9k?

zOn Wed, 2013-04-24 at 21:05 +0200, Francisco Cuesta wrote: > Hello, > > I was wondering where I might find on the ath9k drivers the functions > which let the device distinguish between AP mode and mesh/adhoc one. > Could someone enlighten me a bit? git grep NL80211_IFTYPE_ johannes ___

[ath9k-devel] Where is done the distintion between AP and mesh/adhoc on ath9k?

Hello, I was wondering where I might find on the ath9k drivers the functions which let the device distinguish between AP mode and mesh/adhoc one. Could someone enlighten me a bit? Thanks in advance, regards! ___ ath9k-devel mailing list ath9k-devel@lis

Re: [ath9k-devel] [PATCH 2/2] ath10k: don't advertise we want monitor vif

Michal Kazior wrote: > [ 1989.477975] ath10k: Only one monitor interface allowed > [ 1989.478016] ath10k: ath10k_htc_notify_tx_completion: ep 2 skb > 880220e480c0 > [ 1989.481481] [ cut here ] > [ 1989.486963] WARNING: at net/mac80211/iface.c:386 > ieee80211_add_virtua

[ath9k-devel] [PATCH] ath10k: fix comments style in rx_desc.h file

Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/rx_desc.h | 1360 ++--- 1 file changed, 680 insertions(+), 680 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/rx_desc.h b/drivers/net/wireless/ath/ath10k/rx_desc.h index e3df696..f203614 1006

Re: [ath9k-devel] [PATCH 0/2] ath10k: killing things..

On 24/04/13 14:34, Markowski Bartosz wrote: > Bartosz Markowski (2): >ath10k: kill pci_write32_v1_workaround function >ath10k: kill TARGET_TYPE_AR9888 > > drivers/net/wireless/ath/ath10k/bmi.h |8 +++ > drivers/net/wireless/ath/ath10k/core.c | 28 +-- > dr

[ath9k-devel] [PATCH v2 7/7] ath10k: add new PCI 'feature' to track QCA988x_1.0 hacks

This is to remove excessive bool variable from ar_pci struct and to not check directly device version, again. Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/pci.c |8 +--- drivers/net/wireless/ath/ath10k/pci.h |8 2 files changed, 9 insertions(+), 7 del

[ath9k-devel] [PATCH v2 6/7] ath10k: change FW folder name from AR9888 -> QCA988X

Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/hw.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h index 2a624ea..c9159d3 100644 --- a/drivers/net/wireless/ath/ath10k/hw.

[ath9k-devel] [PATCH v2 5/7] ath10k: remove odd line break

Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/hw.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h index ddb9b58..2a624ea 100644 --- a/drivers/net/wireless/ath/ath10k/hw.h

[ath9k-devel] [PATCH v2 3/7] ath10k: replace AR9888 occurrences with QCA988x

Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/bmi.h |4 +-- drivers/net/wireless/ath/ath10k/core.c | 38 +-- drivers/net/wireless/ath/ath10k/core.h |2 +- drivers/net/wireless/ath/ath10k/htt.h |2 +- drivers/net/wi

[ath9k-devel] [PATCH v2 4/7] ath10k: kill obsolete defines in hw.h

Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/hw.h |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h index 6c2a0cd..ddb9b58 100644 --- a/drivers/net/wireless/ath/ath10k/hw.h +++ b/drivers/ne

[ath9k-devel] [PATCH v2 1/7] ath10k: kill pci_write32_v1_workaround function

Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/pci.h | 38 +++-- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.h b/drivers/net/wireless/ath/ath10k/pci.h index e05a7e0..add59ea 100644 --- a/d

[ath9k-devel] [PATCH v2 2/7] ath10k: kill TARGET_TYPE_AR9888

Get rid of target_type variable also. At the moment ath10k does not support anything else then QCA988x HW. Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/bmi.h |8 +++- drivers/net/wireless/ath/ath10k/core.c | 28 ++-- drivers/net/wireless

[ath9k-devel] [PATCH v2 0/7] killing things - respin

Just to avoid many merge conflicts I'm re-sending prev 2 patches in the same sack. Bartosz Markowski (7): ath10k: kill pci_write32_v1_workaround function ath10k: kill TARGET_TYPE_AR9888 ath10k: replace AR9888 occurrences with QCA988x ath10k: kill obsolete defines in hw.h ath10k: remove o

Re: [ath9k-devel] [RFC 0/2] ath10k: fix qos workaround

On 24/04/13 12:53, Sujith Manoharan wrote: > Michal Kazior wrote: >> >From what I've observed so far is frames in >> monitor mode (non promiscuous) are corrupted. They >> have the QoS Control stripped, with LLC header >> finding itself in the QoS Control. Wireshark shows >> such packets as A-MSDU c

[ath9k-devel] [PATCH 2/2] ath10k: kill TARGET_TYPE_AR9888

Get rid of target_type variable also. At the moment ath10k does not support anything else then QCA988x HW. Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/bmi.h |8 +++- drivers/net/wireless/ath/ath10k/core.c | 28 ++-- drivers/net/wireless

[ath9k-devel] [PATCH 1/2] ath10k: kill pci_write32_v1_workaround function

Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/pci.h | 38 +++-- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.h b/drivers/net/wireless/ath/ath10k/pci.h index e05a7e0..add59ea 100644 --- a/d

[ath9k-devel] [PATCH 0/2] ath10k: killing things..

Bartosz Markowski (2): ath10k: kill pci_write32_v1_workaround function ath10k: kill TARGET_TYPE_AR9888 drivers/net/wireless/ath/ath10k/bmi.h |8 +++ drivers/net/wireless/ath/ath10k/core.c | 28 +-- drivers/net/wireless/ath/ath10k/core.h | 12 +++--- driver

[ath9k-devel] [PATCH 5/5] ath10k: fix some checkpatch warnings in htt_rx.c and ce.c

Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/ce.c | 32 +- drivers/net/wireless/ath/ath10k/htt_rx.c | 27 + 2 files changed, 36 insertions(+), 23 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/ce.c b/drivers

[ath9k-devel] [PATCH 4/5] ath10k: fix checkpatch warnings in ce.h, core.c, htc.c, htt_tx.c and txrx.c

Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/ce.h |4 +-- drivers/net/wireless/ath/ath10k/core.c | 12 +--- drivers/net/wireless/ath/ath10k/htc.c| 45 - drivers/net/wireless/ath/ath10k/htt_tx.c | 46 +

[ath9k-devel] [PATCH 3/5] ath10k: fix checkpatch warnings from bmi.c, debug.c, htc.h and pci.h

Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/bmi.c |7 --- drivers/net/wireless/ath/ath10k/debug.c | 15 ++- drivers/net/wireless/ath/ath10k/htc.h | 27 ++- drivers/net/wireless/ath/ath10k/pci.h | 25

[ath9k-devel] [PATCH 2/5] ath10k: shorten lines in ath10k_debug_read_target_stats()

This makes checkpatch a happy boy. No functional changes. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/debug.h | 117 +-- drivers/net/wireless/ath/ath10k/wmi.h |2 - 2 files changed, 65 insertions(+), 54 deletions(-) diff --git a/drivers/net/w

[ath9k-devel] [PATCH 1/5] ath10k: cosmetic checkpatch fixes to bmi.h, hw.h and txrx.h

Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/bmi.h |2 +- drivers/net/wireless/ath/ath10k/hw.h |7 +++ drivers/net/wireless/ath/ath10k/txrx.h |6 -- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/bmi.h b/driv

[ath9k-devel] [PATCH 0/5] ath10k: checkpatch fixes 20130424

Few checkpatch fixes. --- Kalle Valo (5): ath10k: cosmetic checkpatch fixes to bmi.h, hw.h and txrx.h ath10k: shorten lines in ath10k_debug_read_target_stats() ath10k: fix checkpatch warnings from bmi.c, debug.c, htc.h and pci.h ath10k: fix checkpatch warnings in ce.h, cor

[ath9k-devel] [PATCH v2 6/6] ath10k: simplify pci target reset

We already have a function that resets the target and waits until it has awoken. We can also change the ordering and combine device reset with target reset altogether. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 52 - 1 file changed

[ath9k-devel] [PATCH v2 5/6] ath10k: remove ath10k_pci_probe_device()

No need to have probing logic scattered all over the place. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 70 +++-- 1 file changed, 24 insertions(+), 46 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wirele

[ath9k-devel] [PATCH v2 4/6] ath10k: remove ath10k_pci_configure()

This moves the contents of the function directly into the pci probing function. Doesn't make sense to have probe logic scattered so much around. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 47 + 1 file changed, 18 insertions(+), 29 d

[ath9k-devel] [PATCH v2 3/6] ath10k: remove pci probe retrying

This is an ugly hack. It is better to simply reset the target and wait until it wakes up. If that is not enough the platform may be broken. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 88 +++-- 1 file changed, 39 insertions(+), 49 deleti

[ath9k-devel] [PATCH v2 2/6] ath10k: refactor pci interrupt functions

This patch splits the interrupt registering function into separate functions. Hopefully this is more readable and maintanable. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 334 - 1 file changed, 163 insertions(+), 171 deletions(-) dif

[ath9k-devel] [PATCH v2 1/6] ath10k: fix pci_set_drvpriv ordering

Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 40ca6d3..20e6371 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c

[ath9k-devel] [PATCH v2 0/6] ath10k: pci cleanup

This gets rid of the ugly device/target resetting retries. It also tries to simplify pci probing logic. v2: fixes MSI-X and legacy interrupts adds/changes a few prints Michal Kazior (6): ath10k: fix pci_set_drvpriv ordering ath10k: refactor pci interrupt functions ath10k: remove pci pro

Re: [ath9k-devel] [PATCH 2/2] ath10k: don't advertise we want monitor vif

On 24/04/13 13:36, Sujith Manoharan wrote: > Michal Kazior wrote: >> We were triggering warnings in our code and >> mac80211. We could fix the monitor state machine >> in ath10k but it doesn't make much sense. We don't >> benefit from having the monitor vif create in the >> first place so just drop

Re: [ath9k-devel] [PATCH v2 1/3] ath10k: WMI API updates

Sujith Manoharan wrote: > From: Sujith Manoharan > > To sync with new FW ver .614 A rebased patch below. (Also, http://msujith.org/patches/wl/Apr-24-2013/0005-ath10k-WMI-API-updates.patch). Sujith [PATCH] ath10k: WMI API updates To sync with new FW ver .614 Signed-off-by: Sujith Manoharan

[ath9k-devel] [PATCH v2] ath10k: kill static int max_delay

Kill not used max_delay variable Signed-off-by: Janusz Dziedzic --- drivers/net/wireless/ath/ath10k/pci.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 40ca6d3..861da39 100644 --- a/drivers/net/wirel

[ath9k-devel] [PATCH] ath10k: fix supported band setup

This fixes a crash and a possible memleak. Signed-off-by: Michal Kazior --- This was introduced just recently. drivers/net/wireless/ath/ath10k/mac.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/at

Re: [ath9k-devel] [PATCH 2/2] ath10k: don't advertise we want monitor vif

Michal Kazior wrote: > We were triggering warnings in our code and > mac80211. We could fix the monitor state machine > in ath10k but it doesn't make much sense. We don't > benefit from having the monitor vif create in the > first place so just drop it. What warnings ? I think this flag is requir

Re: [ath9k-devel] [PATCH] ath10k: kill static int max_delay

>-Original Message- >From: Kalle Valo [mailto:kv...@qca.qualcomm.com] >Sent: 24 kwietnia 2013 13:21 >To: Dziedzic Janusz >Cc: ath9k-devel@lists.ath9k.org >Subject: Re: [ath9k-devel] [PATCH] ath10k: kill static int max_delay > >Janusz Dziedzic writes: > >> Kill static variable max_delay. >>

Re: [ath9k-devel] [PATCH 0/2] ath10k: htt fixes

Michal Kazior writes: > This one addresses a rare memory leak when FW > hangs leaving some HTT tx transactions unfinished. > > Michal Kazior (2): > ath10k: clear pending_tx[] upon tx completion > ath10k: cleanup htt pending tx Thanks, applied. -- Kalle Valo

Re: [ath9k-devel] [PATCH 0/6] ath10k: pci cleanup

On 24/04/13 12:19, Kazior Michal wrote: > This gets rid of the ugly device/target resetting > retries. It also tries to simplify pci probing > logic. Please do not apply this yet. CUS223 2.0 doesn't seem to like this patchset. -- Pozdrawiam / Best regards, Michal Kazior.

Re: [ath9k-devel] [PATCH] ath10k: kill static int max_delay

Janusz Dziedzic writes: > Kill static variable max_delay. > Move this to struct ath10k_pci. > > Signed-off-by: Janusz Dziedzic > --- > drivers/net/wireless/ath/ath10k/pci.c |5 ++--- > drivers/net/wireless/ath/ath10k/pci.h |2 ++ > 2 files changed, 4 insertions(+), 3 deletions(-) > > di

Re: [ath9k-devel] [PATCH 0/5] ath10k: making static variables const

Kalle Valo writes: > Did some review of static variables and noticed that > we had quite a few variables which were not const. > > Please review carefully, I might have missed something. > > --- > > Kalle Valo (5): > ath10k: make rx_legacy_rate_idx variable const > ath10k: make host_c

[ath9k-devel] [PATCH] ath10k: fix compilation warning

In function ‘ath10k_pci_probe’: /wireless-testing/drivers/net/wireless/ath/ath10k/pci.c:2150: warning: unused variable ‘hif_type’ Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/pci.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c

Re: [ath9k-devel] [PATCH v2 0/6] ath10k: cleanups

Michal Kazior writes: > On 24/04/13 12:35, Kalle Valo wrote: >> Michal Kazior writes: >> >>> Rebased on the tip of master branch. >>> >>> Michal Kazior (6): >>>ath10k: rename htt_struct >>>ath10k: fix code style >>>ath10k: fix code style of handling errors >>>ath10k: fix code sty

Re: [ath9k-devel] [PATCH 0/7] ath10k: more cleanup

On 24/04/13 13:03, Kalle Valo wrote: > Bartosz Markowski writes: > >> Bartosz Markowski (7): >>ath10k: Print more elgant HW name/version >>ath10k: shift ath10k_generic_iter structure to mac header >>ath10k: kill HIF_TYPE_AR9888 >>ath10k: shift REG_DUMP_COUNT_AR9888 to pci block >>

Re: [ath9k-devel] [PATCH 0/7] ath10k: more cleanup

Bartosz Markowski writes: > Bartosz Markowski (7): > ath10k: Print more elgant HW name/version > ath10k: shift ath10k_generic_iter structure to mac header > ath10k: kill HIF_TYPE_AR9888 > ath10k: shift REG_DUMP_COUNT_AR9888 to pci block > ath10k: move DIAG_TRANSFER_LIMIT to pci block >

Re: [ath9k-devel] [PATCH v2 0/6] ath10k: cleanups

Kalle Valo writes: > Michal Kazior writes: > >> Rebased on the tip of master branch. >> >> Michal Kazior (6): >> ath10k: rename htt_struct >> ath10k: fix code style >> ath10k: fix code style of handling errors >> ath10k: fix code style a little >> ath10k: cleanup tx/rx mode handling >>

Re: [ath9k-devel] [PATCH v2 0/6] ath10k: cleanups

On 24/04/13 12:35, Kalle Valo wrote: > Michal Kazior writes: > >> Rebased on the tip of master branch. >> >> Michal Kazior (6): >>ath10k: rename htt_struct >>ath10k: fix code style >>ath10k: fix code style of handling errors >>ath10k: fix code style a little >>ath10k: cleanup t

Re: [ath9k-devel] [RFC 0/2] ath10k: fix qos workaround

Michal Kazior wrote: > >From what I've observed so far is frames in > monitor mode (non promiscuous) are corrupted. They > have the QoS Control stripped, with LLC header > finding itself in the QoS Control. Wireshark shows > such packets as A-MSDU corrupted frames. I tried > restoring the QoS Contr

Re: [ath9k-devel] [PATCH 0/3] ath10k: PCI cleanups

Bartosz Markowski writes: > Bartosz Markowski (3): > ath10k: update FIXME comments > ath10k: rename WAR_CE_SRC_RING_WRITE_IDX_SET > ath10k: replace TARGET_READ/WRITE macros with inline funcitons Thanks, applied. -- Kalle Valo ___ ath9k-devel ma

Re: [ath9k-devel] [PATCH 0/3] ath10k: cleanup - respin

Bartosz Markowski writes: > Couple of updated patches. > > Bartosz Markowski (3): > ath10k: remove excessive CONFIG_PM_SLEEP checks > ath10k: kill PCIE_LOCAL_REG_READ/WRITE macros > ath10k: update supported firmware tag to .599 Thanks, applied. -- Kalle Valo _

Re: [ath9k-devel] [PATCH v2 0/6] ath10k: cleanups

Michal Kazior writes: > Rebased on the tip of master branch. > > Michal Kazior (6): > ath10k: rename htt_struct > ath10k: fix code style > ath10k: fix code style of handling errors > ath10k: fix code style a little > ath10k: cleanup tx/rx mode handling > ath10k: cleanup hw init-relate

Re: [ath9k-devel] [PATCH] ath10k: kill ar9888def.h file

Janusz Dziedzic writes: > Move ar9888 definitions to hw.h file. > > Signed-off-by: Janusz Dziedzic Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 4/5] ath10k: make iee80211 iface combination structures static

Michal Kazior writes: > On 24/04/13 08:37, Kalle Valo wrote: >> Nothing modifies them. > > I think the title should be s/static/const/ Yup, I fixed that in my branch. Thanks for review. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.at

[ath9k-devel] [PATCH 6/6] ath10k: simplify pci target reset

We already have a function that resets the target and waits until it has awoken. We can also change the ordering and combine device reset with target reset altogether. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 52 - 1 file changed

[ath9k-devel] [PATCH 4/6] ath10k: remove ath10k_pci_configure()

This moves the contents of the function directly into the pci probing function. Doesn't make sense to have probe logic scattered so much around. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 47 + 1 file changed, 18 insertions(+), 29 d

[ath9k-devel] [PATCH 5/6] ath10k: remove ath10k_pci_probe_device()

No need to have probing logic scattered all over the place. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 70 +++-- 1 file changed, 24 insertions(+), 46 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wirele

[ath9k-devel] [PATCH 2/6] ath10k: refactor pci interrupt functions

This patch splits the interrupt registering function into separate functions. Hopefully this is more readable and maintanable. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 334 - 1 file changed, 164 insertions(+), 170 deletions(-) dif

[ath9k-devel] [PATCH 3/6] ath10k: remove pci probe retrying

This is an ugly hack. It is better to simply reset the target and wait until it wakes up. If that is not enough the platform may be broken. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 89 +++-- 1 file changed, 39 insertions(+), 50 deleti

[ath9k-devel] [PATCH 1/6] ath10k: fix pci_set_drvpriv ordering

Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 0d1523b..5819c21 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c

[ath9k-devel] [PATCH 0/6] ath10k: pci cleanup

This gets rid of the ugly device/target resetting retries. It also tries to simplify pci probing logic. Michal Kazior (6): ath10k: fix pci_set_drvpriv ordering ath10k: refactor pci interrupt functions ath10k: remove pci probe retrying ath10k: remove ath10k_pci_configure() ath10k: remove

[ath9k-devel] [PATCH 2/2] ath10k: don't advertise we want monitor vif

We were triggering warnings in our code and mac80211. We could fix the monitor state machine in ath10k but it doesn't make much sense. We don't benefit from having the monitor vif create in the first place so just drop it. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c |

[ath9k-devel] [PATCH 0/2] ath10k: monitor mode fixes

This cleans up some warnings during runtime. Michal Kazior (2): ath10k: avoid null dereference on vif ath10k: don't advertise we want monitor vif drivers/net/wireless/ath/ath10k/mac.c | 10 +++--- drivers/net/wireless/ath/ath10k/mac.h |3 +++ 2 files changed, 10 insertions(+), 3 de

[ath9k-devel] [PATCH 1/2] ath10k: avoid null dereference on vif

The vif isn't really guaranteed to be non-NULL. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c |9 +++-- drivers/net/wireless/ath/ath10k/mac.h |3 +++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/driv

[ath9k-devel] [PATCH 1/3] ath10k: cleanup amsdu rx

Clarify documentation, refactor the code to make it possible to support other decap modes more easily. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/htt_rx.c | 56 +++--- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/net/wire

[ath9k-devel] [PATCH 2/3] ath10k: fix native wifi decap mode amsdu rx

We did not really support nwifi decap mode correctly. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/htt_rx.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.

[ath9k-devel] [PATCH 0/3] ath10k: amsdu rx fixes

Michal Kazior (3): ath10k: cleanup amsdu rx ath10k: fix native wifi decap mode amsdu rx ath10k: don't support llc/snap decap explicitly for amsdu rx drivers/net/wireless/ath/ath10k/htt_rx.c | 71 ++ 1 file changed, 42 insertions(+), 29 deletions(-) -- 1.7.9.5

[ath9k-devel] [PATCH 3/3] ath10k: don't support llc/snap decap explicitly for amsdu rx

We don't really know how to un-decap those frames for A-MSDU traffic, yet. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/htt_rx.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10

[ath9k-devel] [RFC 2/2] ath10k: copy skb during tx

HW is unable to overwrite Qos Control field from Qos Data Frames. We must strip the QoS Control provided by mac80211 before we can submit a frame to the FW. Since we modified a frame and never restored it this could cause some issues. It definietely ended up showing corrupted frames from a monitor

[ath9k-devel] [RFC 1/2] ath10k: make more space in ath10k_skb_cb

Some fields are used only for the original payload skbuff, and other are used for htt tx descriptor skbuff. If we split them and make a union we get a lot of extra room. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/core.h | 31 +++ 1 file changed

[ath9k-devel] [RFC 0/2] ath10k: fix qos workaround

>From what I've observed so far is frames in monitor mode (non promiscuous) are corrupted. They have the QoS Control stripped, with LLC header finding itself in the QoS Control. Wireshark shows such packets as A-MSDU corrupted frames. I tried restoring the QoS Control but it didn't fix that. I thi

Re: [ath9k-devel] [PATCH 4/5] ath10k: make iee80211 iface combination structures static

On 24/04/13 08:37, Kalle Valo wrote: > Nothing modifies them. I think the title should be s/static/const/ -- Pozdrawiam / Best regards, Michal Kazior. ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath

Re: [ath9k-devel] [PATCH v2 1/3] ath10k: WMI API updates

On 24/04/13 08:53, Sujith Manoharan wrote: > From: Sujith Manoharan > > To sync with new FW ver .614 > > Signed-off-by: Sujith Manoharan > --- > drivers/net/wireless/ath/ath10k/hw.h | 3 ++- > drivers/net/wireless/ath/ath10k/wmi.c | 1 + > drivers/net/wireless/ath/ath10k/wmi.h | 12 +++

[ath9k-devel] [PATCH 2/2] ath10k: cleanup htt pending tx

This fixes memory leak. It could be seen in the following scenario: * submit htt tx frame * receive htc tx completion * FW hangs * rmmod * txed frame never freed Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/htt_tx.c | 28 1 file changed, 2

[ath9k-devel] [PATCH 0/2] ath10k: htt fixes

This one addresses a rare memory leak when FW hangs leaving some HTT tx transactions unfinished. Michal Kazior (2): ath10k: clear pending_tx[] upon tx completion ath10k: cleanup htt pending tx drivers/net/wireless/ath/ath10k/htt_tx.c | 28 drivers/net/wireless/

[ath9k-devel] [PATCH 1/2] ath10k: clear pending_tx[] upon tx completion

We validate the pending_tx[] upon tx completion so it makes sense to clear the items. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/txrx.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/txrx.c b/drivers/net/wireless/ath/ath10k/txrx.c in