Re: [ath9k-devel] [PATCH v3 0/6] ath10k: pci cleanup

2013-04-26 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: This gets rid of the ugly device/target resetting retries. It also tries to simplify pci probing logic. v3: rebased on top of latest master branch Michal Kazior (6): ath10k: fix pci_set_drvpriv ordering ath10k: refactor pci interrupt

Re: [ath9k-devel] [PATCH v3 1/6] ath10k: fix pci_set_drvpriv ordering

2013-04-26 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c

Re: [ath9k-devel] [PATCH v3 1/6] ath10k: fix pci_set_drvpriv ordering

2013-04-26 Thread Michal Kazior
On 26/04/13 08:45, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[ath9k-devel] ath10k.git updated to 3.9.0-rc8-wl-ath10k

2013-04-26 Thread Kalle Valo
Hi, I just merged latest wireless-testing to ath10k.git. The mac80211 channel API had changed and I had to change ath10k accordingly, please review my changes. diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index f64c2fc..9cb63cc 100644 ---

Re: [ath9k-devel] [PATCH 2/2] ath10k: don't advertise we want monitor vif

2013-04-26 Thread Kalle Valo
Hi, Sujith Manoharan suj...@msujith.org writes: Michal Kazior wrote: Considering how stable monitor mode is perhaps we should start monitor vdev only when there's the monitor vif present? (right now we can start it without the vdev). If so then we drop this patch. And we probably also

Re: [ath9k-devel] ath10k.git updated to 3.9.0-rc8-wl-ath10k

2013-04-26 Thread Markowski Bartosz
On 26/04/13 09:34, Kalle Valo wrote: Hi, I just merged latest wireless-testing to ath10k.git. The mac80211 channel API had changed and I had to change ath10k accordingly, please review my changes. Looks good for me. -Bartosz ___ ath9k-devel

[ath9k-devel] [PATCH 1/6] ath10k: fix code style and add comments to tx code

2013-04-26 Thread Michal Kazior
Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/htt_tx.c |4 drivers/net/wireless/ath/ath10k/txrx.c |4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c

[ath9k-devel] [PATCH 2/6] ath10k: tweak ath10k_pci_diag_read_mem() prototype

2013-04-26 Thread Michal Kazior
It reads not well defined data thus void pointer seems a better match here. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c

[ath9k-devel] [PATCH 4/6] ath10k: drop unnecessary else branch

2013-04-26 Thread Michal Kazior
Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index ddef94e..c3c91a0

[ath9k-devel] [PATCH 3/6] ath10k: tweak ath10k_pci_diag_write_mem() prototype

2013-04-26 Thread Michal Kazior
It doesn't modify the data argument thus const. It also is more suitable to use void pointer here since the payload type is not well defined. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c | 14 +++--- 1 file changed, 7 insertions(+), 7

[ath9k-devel] [PATCH 6/6] ath10k: cleanup ath10k_pci_stop_intr()

2013-04-26 Thread Michal Kazior
Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index d521270..31881f9 100644 ---

[ath9k-devel] [PATCH 5/6] ath10k: drop unnecessary else branch

2013-04-26 Thread Michal Kazior
ath10k_pci_{sleep,wake} do refcounting and the awake sections can be nested. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c

[ath9k-devel] [PATCH 0/6] ath10k: coding style cleanup

2013-04-26 Thread Michal Kazior
Michal Kazior (6): ath10k: fix code style and add comments to tx code ath10k: tweak ath10k_pci_diag_read_mem() prototype ath10k: tweak ath10k_pci_diag_write_mem() prototype ath10k: drop unnecessary else branch ath10k: drop unnecessary else branch ath10k: cleanup ath10k_pci_stop_intr()

[ath9k-devel] [PATCH 0/2] ath10k: fw download refactor

2013-04-26 Thread Michal Kazior
This kills off ath10k_file enum and splits FW loading more sanely hopefully. Michal Kazior (2): ath10k: split UART prints setup ath10k: cleanup firmware downloading routines drivers/net/wireless/ath/ath10k/core.c | 393 ++-- 1 file changed, 220 insertions(+),

[ath9k-devel] [PATCH 2/2] ath10k: cleanup firmware downloading routines

2013-04-26 Thread Michal Kazior
Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 358 +--- 1 file changed, 190 insertions(+), 168 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index

[ath9k-devel] [PATCH] ath10k: fix (void *) casts in wmi submodule

2013-04-26 Thread Bartosz Markowski
Signed-off-by: Bartosz Markowski bartosz.markow...@tieto.com --- drivers/net/wireless/ath/ath10k/wmi.c | 42 - 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index

[ath9k-devel] [PATCH 0/7] ath10k: htt rx fixes

2013-04-26 Thread Michal Kazior
This patchset addresses issues with fragmented (802.11b) frames. Michal Kazior (7): ath10k: zero htt_rx_info struct in frag rx handler ath10k: do not pop more than one frame in frag rx handler ath10k: add safety check after popping a frame in frag rx ath10k: move

[ath9k-devel] [PATCH 1/7] ath10k: zero htt_rx_info struct in frag rx handler

2013-04-26 Thread Michal Kazior
The struct was filled with garbage and ended up having fcs_err set to true. This caused mac to drop fragmented frames. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/htt_rx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[ath9k-devel] [PATCH 2/7] ath10k: do not pop more than one frame in frag rx handler

2013-04-26 Thread Michal Kazior
This led us to popping frames too early, before FW actually filled in frames. This was not an issue earlier. Perhaps the MSDU FW descriptor is now different. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/htt_rx.c |4 +--- 1 file changed, 1

[ath9k-devel] [PATCH 3/7] ath10k: add safety check after popping a frame in frag rx

2013-04-26 Thread Michal Kazior
If HTT RX went haywire we dereferenced buggy pointers that led to system crash. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/htt_rx.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c

[ath9k-devel] [PATCH 5/7] ath10k: drop all msdus in case of htt rx failure

2013-04-26 Thread Michal Kazior
It's a lot safer to simply drop everything. It's broken anyway so why bother. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/htt_rx.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c

[ath9k-devel] [PATCH 4/7] ath10k: move ath10k_htt_rx_free_msdu_chain()

2013-04-26 Thread Michal Kazior
This makes it possible to call the function more different places now. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/htt_rx.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[ath9k-devel] [PATCH 6/7] ath10k: fix tkip fragment rx

2013-04-26 Thread Michal Kazior
TKIP fragmented frames contains different data at the tail depending on the more flags. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/htt_rx.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git

[ath9k-devel] [PATCH 7/7] ath10k: strip protected flag

2013-04-26 Thread Michal Kazior
We already do decryption and all crypto verification in HW. mac80211 tries to verify CCMP for fragmented rx and fails without this patch. This fixes fragmented rx on CCMP networks. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/txrx.c |7 ++- 1

[ath9k-devel] [PATCH 0/5] ath10k: fix checkpatch warnings 20130426

2013-04-26 Thread Kalle Valo
Trying to get the number of checkpatch warnings smaller. --- Kalle Valo (5): ath10k: fix checkpatch warnings in mac.c ath10k: fix some checkpatch warnings in wmi.c ath10k: fix some checkpatch warnings in pci.c ath10k: fix some checkpatch errors in ce.c ath10k: fix

[ath9k-devel] [PATCH 1/5] ath10k: fix checkpatch warnings in mac.c

2013-04-26 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c | 103 +++-- 1 file changed, 60 insertions(+), 43 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index

[ath9k-devel] [PATCH 2/5] ath10k: fix some checkpatch warnings in wmi.c

2013-04-26 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.c | 100 ++--- 1 file changed, 66 insertions(+), 34 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index

[ath9k-devel] [PATCH 3/5] ath10k: fix some checkpatch warnings in pci.c

2013-04-26 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/pci.c | 89 ++--- 1 file changed, 58 insertions(+), 31 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index

[ath9k-devel] [PATCH 4/5] ath10k: fix some checkpatch errors in ce.c

2013-04-26 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/ce.c | 80 ++ 1 file changed, 52 insertions(+), 28 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/ce.c b/drivers/net/wireless/ath/ath10k/ce.c index 44c8947..75d1fea

[ath9k-devel] [PATCH 5/5] ath10k: fix some checkpatch errors in wmi.h

2013-04-26 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.h | 155 - 1 file changed, 111 insertions(+), 44 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index

[ath9k-devel] [PATCH 0/2] ath10k: ce cleanup

2013-04-26 Thread Michal Kazior
Trivial cleanup. Michal Kazior (2): ath10k: use ALIGN() kernel macros ath10k: use void pointer instead of char pointer drivers/net/wireless/ath/ath10k/ce.c | 50 +++--- drivers/net/wireless/ath/ath10k/ce.h |2 +- 2 files changed, 17 insertions(+), 35

[ath9k-devel] [PATCH 1/2] ath10k: use ALIGN() kernel macros

2013-04-26 Thread Michal Kazior
Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/ce.c | 50 +++--- 1 file changed, 16 insertions(+), 34 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/ce.c b/drivers/net/wireless/ath/ath10k/ce.c index

[ath9k-devel] [PATCH 2/2] ath10k: use void pointer instead of char pointer

2013-04-26 Thread Michal Kazior
Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/ce.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/ce.h b/drivers/net/wireless/ath/ath10k/ce.h index 555f7bc..11948a6 100644 ---

[ath9k-devel] Missing packet info with little endian ath9k

2013-04-26 Thread Luis Correia
Hi all! I'm doing a project of mine. It's about guiding a robot in my living room using wifi. At first I tried to use two raspberry pi with a wifi dongle (ath9k-htc) and libpcap to capture wifi packets and read the rssi from my robot mac address. It works fine. But then I thought in using

[ath9k-devel] [PATCH] ath10k: fix pci feature bitmap

2013-04-26 Thread Michal Kazior
The array size evaluated to zero. This caused hw v1 workaround to fail. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.h

[ath9k-devel] [PATCH] ath10k: Use IBSS SSID provided by mac80211.

2013-04-26 Thread Marek Puzyniak
IBSS ssid is provided by mac80211, use it in vdev start. Signed-off-by: Marek Puzyniak marek.puzyn...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c

Re: [ath9k-devel] Missing packet info with little endian ath9k

2013-04-26 Thread Holger Schurig
You probably need some __attribute__((packed)) on the structs ? http://gcc.gnu.org/onlinedocs/gcc/Type-Attributes.html 2013/4/26 Luis Correia lfpcorr...@gmail.com Hi all! I'm doing a project of mine. It's about guiding a robot in my living room using wifi. At first I tried to use two

Re: [ath9k-devel] varying RSSI values with ath9k_htc drivers for TL-WN721N USB wifi adapter.

2013-04-26 Thread Harshal Vora
On Friday 26 April 2013 01:39 AM, Adrian Chadd wrote: Have you actually verified that the output power of those devices is actually constant? Adrian On 25 April 2013 07:08, Harshal Vora hars...@amideeptech.com wrote: Hi, I are trying to achieve approximate location detection (room level

Re: [ath9k-devel] varying RSSI values with ath9k_htc drivers for TL-WN721N USB wifi adapter.

2013-04-26 Thread Trevor Cullen
This issue totally destroyed deployment of DNUA-93F (AR9271) USB Wifi in a similar application. Now use Realtek with very stable results. But there is history. See https://patchwork.kernel.org/patch/2177921/ and attached. Trevor -Original Message- From:

Re: [ath9k-devel] varying RSSI values with ath9k_htc drivers for TL-WN721N USB wifi adapter.

2013-04-26 Thread Adrian Chadd
There's some driver work that Felix and others did or are talking about, which tidy up the RSSI measurement. There's also the antenna diversity behaviour; depending upon which antenna is used, there's a few dB difference (same as the AR9285.) I'm sorry, I can't work on it any more than that. I

[ath9k-devel] [PATCH] ath9k_htc: add STBC TX support

2013-04-26 Thread Oleksij Rempel
current firmware will enable STBC_TX, only if other peer support it. This patch provide ht_peer_caps to firmware. FW versions 1.3, 1.4 should be able to work with it. Tested on ar7010+ar9280 and ar7010+ar9287. Signed-off-by: Oleksij Rempel li...@rempel-privat.de ---

[ath9k-devel] [PATCH] ath9k_htc: add STBC TX support

2013-04-26 Thread Oleksij Rempel
current firmware will enable STBC_TX, only if other peer support it. This patch provide ht_peer_caps to firmware. FW versions 1.3, 1.4 should be able to work with it. Tested on ar7010+ar9280 and ar7010+ar9287. Signed-off-by: Oleksij Rempel li...@rempel-privat.de ---

[ath9k-devel] 3.9.0-rc8+ (hacked) splat.

2013-04-26 Thread Ben Greear
Was running around 200 stations against a VAP on this system, and then changed the channel from 1 to 36 (by restarting hostapd with new config). Looks like null-pointer de-ref... Anyone seen anything similar? [17789.100382] ath: wiphy0: keyreset: keycache entry 228 out of range [17789.107940]