Re: [ath9k-devel] [v2] ath9k: simplify the code-paths when not using the built-in EEPROM

2016-07-19 Thread Kalle Valo
Martin Blumenstingl wrote: > There were two paths in the code for "external" eeprom sources. The code > in eeprom.c only handled the cases where the eeprom data was loaded via > request_firmware. ahb.c and pci.c on the other hand had some duplicate > code which

Re: [ath9k-devel] AuthSAE rekeying issues with ATH9K

2016-07-19 Thread Stam, Michel [FINT]
Hey Adrian, Apologies, I was out of the office on Friday, so I did not have access to my development system nor my test units. It is on the top of my todo list, will get to it hopefully today, or tomorrow. Cheers, Michel --- Begin Message --- hi, any news? -a On 14 July 2016 at 13:10,

Re: [ath9k-devel] AuthSAE rekeying issues with ATH9K

2016-07-19 Thread Adrian Chadd
Hi, So, there's a keycache index in the RX packet telling you which keycache entry it matched. See if it's matching a keycache entry but then failing to decrypt; if this is happening then an easy check would be "hit some threshold for crypto failures" => "replumb that keycache slot." This means

Re: [ath9k-devel] AuthSAE rekeying issues with ATH9K

2016-07-19 Thread Adrian Chadd
Hi, Yeah, delete and re-add should be fine. Just look at whatever the locking requirements are so you're serialised with anything else touching the keycache hardware at the same time. Hopefully it's not such a terrible bug that you end up doing it like, hundreds of times a second. :) -adrian

Re: [ath9k-devel] AuthSAE rekeying issues with ATH9K

2016-07-19 Thread Adrian Chadd
hi, any news? -a On 14 July 2016 at 13:10, Adrian Chadd wrote: > Hi, > > Yeah, delete and re-add should be fine. Just look at whatever the > locking requirements are so you're serialised with anything else > touching the keycache hardware at the same time. > > Hopefully

Re: [ath9k-devel] [PATCH v4 1/3] Documentation: dt: net: add ath9k wireless device binding

2016-07-19 Thread Arnd Bergmann
On Monday, July 11, 2016 11:21:26 PM CEST Martin Blumenstingl wrote: > On Mon, Jul 11, 2016 at 12:01 AM, Arnd Bergmann wrote: > >> ath9k reads the data from the EEPROM into memory. With that property > >> disabled ath9k simply assumes that the endianness of the values in the > >>

Re: [ath9k-devel] AuthSAE rekeying issues with ATH9K

2016-07-19 Thread Stam, Michel [FINT]
Hey Adrian, Just saw your email, I took a quick look and I was able to find a struct ieee80211_key_conf which contains the key material. I suppose that the ath_node needs to be extracted from the ieee80211_sta -> drv_priv by looking up the source mac address in the struct ieee80211_hdr