[ath9k-devel] [PATCH] wireless: ath: ath9k: constify ath_bus_ops structure

2017-01-07 Thread Bhumika Goyal
Declare the structure ath_bus_ops as const as it is only passed as an argument to the function ath9k_init_device. This argument is of type const struct ath_bus_ops *, so ath_bus_ops structures with this property can be declared as const. Done using Coccinelle: @r1 disable optional_qualifier @ ident

Re: [ath9k-devel] Bringing up More Than Two Station Mode Virtual Interfaces

2017-01-07 Thread BrettWright
Hi, It's a firmware limitation with the ar9271. You could modify the open source firmware to get more than 2 vif's, but as memory is constrained you would hit another brick wall pretty soon... From: ath9k-devel-boun...@lists.ath9k.org [mailto:ath9k-devel-boun...@lists.ath9k.org] On Behalf Of

Re: [ath9k-devel] [PATCH v4 3/3] ath9k: parse the device configuration from an OF node

2017-01-07 Thread Bjørn Mork
Martin Blumenstingl writes: > + if (of_property_read_bool(np, "qca,clk-25mhz")) > + ah->is_clk_25mhz = true; > + > + if (of_property_read_bool(np, "qca,disable-2ghz")) > + ah->disable_2ghz = true; > + > + if (of_property_read_bool(np, "qca,disable-5ghz")) > +

Re: [ath9k-devel] [Make-wifi-fast] Diagram of the ath9k TX path

2017-01-07 Thread David Lang
On Fri, 13 May 2016, Bob McMahon wrote: On driver delays, from a driver development perspective the problem isn't to add delay or not (it shouldn't) it's that the TCP stack isn't presenting sufficient data to fully utilize aggregation. Below is a histogram comparing aggregations of 3 systems (u

Re: [ath9k-devel] Bayesian rate control

2017-01-07 Thread Björn Smedman
Hi Johannes, Thanks for the pointers. On Mon, Oct 24, 2016 at 7:28 AM, Johannes Berg wrote: >> I'm thinking the best driver for rate control experimentation would >> be ath9k, right? If so then a TP-Link TL-WA901ND router (apparently >> based on Qualcomm QCA956x SOC) with OpenWrt, and a TP-Link

Re: [ath9k-devel] [Make-wifi-fast] [RFC/RFT 5/5] ath9k: Count RX airtime in airtime deficit

2017-01-07 Thread Jonathan Morton
> On 7 Jun, 2016, at 03:01, Adrian Chadd wrote: > > I also found one of my notes in my version of this - how can we > estimate the duration of an A-MPDU, when we only get hardware > de-encapsulated frames? If my understanding is correct: The A-MPDU itself is sent at the “data” rate (selected b

Re: [ath9k-devel] [Make-wifi-fast] Diagram of the ath9k TX path

2017-01-07 Thread Bob McMahon
On driver delays, from a driver development perspective the problem isn't to add delay or not (it shouldn't) it's that the TCP stack isn't presenting sufficient data to fully utilize aggregation. Below is a histogram comparing aggregations of 3 systems (units are mpdu per ampdu.) The lowest laten

Re: [ath9k-devel] [Make-wifi-fast] Diagram of the ath9k TX path

2017-01-07 Thread Bob McMahon
Also, I haven't done it but I don't think rate limiting TCP will solve this aggregation "problem." The faster RTT is driving CWND much below the maximum aggregation, i.e. CWND is too small relative to wi-fi aggregation. Bob On Fri, May 13, 2016 at 11:05 AM, Bob McMahon wrote: > The graphs are

Re: [ath9k-devel] [Make-wifi-fast] Diagram of the ath9k TX path

2017-01-07 Thread Bob McMahon
The graphs are histograms of mpdu/ampdu, from 1 to 64. The blue spikes show that the vast majority of traffic is filling an ampdu with 64 mpdus. The fill stop reason is ampdu full. The purple fill stop reasons are that the sw fifo (above the driver) went empty indicating a too small CWND for max

Re: [ath9k-devel] [PATCH] mac80211: debugfs var for the default aggregation timeout.

2017-01-07 Thread bruce m beach
> If any people more familiar with ARM are reading this - does the value > 0x5b35da40 ring a bell? It could be anything. It depends on the chip implementation. For instance on an exynos that is an undefined region. What device are we talking about? Bruce ___

Re: [ath9k-devel] [Make-wifi-fast] Diagram of the ath9k TX path

2017-01-07 Thread David Lang
On Mon, 9 May 2016, Dave Taht wrote: On Mon, May 9, 2016 at 7:25 PM, Jonathan Morton wrote: On 9 May, 2016, at 18:35, Dave Taht wrote: should we always wait a little bit to see if we can form an aggregate? I thought the consensus on this front was “no”, as long as we’re making the decis

Re: [ath9k-devel] [Make-wifi-fast] Diagram of the ath9k TX path

2017-01-07 Thread Jonathan Morton
> On 9 May, 2016, at 18:35, Dave Taht wrote: > > should we always wait a little bit to see if we can form an aggregate? I thought the consensus on this front was “no”, as long as we’re making the decision when we have an immediate transmit opportunity. If we *don’t* have an immediate transmit

Re: [ath9k-devel] [Make-wifi-fast] Diagram of the ath9k TX path

2017-01-07 Thread David Lang
On Mon, 9 May 2016, Dave Taht wrote: This is a very good overview, thank you. I'd like to take apart station behavior on wifi with a web application... as a straw man. On Mon, May 9, 2016 at 8:41 PM, David Lang wrote: On Mon, 9 May 2016, Dave Taht wrote: On Mon, May 9, 2016 at 7:25 PM, Jona

[ath9k-devel] [PATCH] ath9k_htc: don't use HZ for usb msg timeouts

2017-01-07 Thread Anthony Romano
The usb_*_msg() functions expect a timeout in msecs but are given HZ, which is ticks per second. If HZ=100, firmware download often times out when there is modest USB utilization and the device fails to initialize. Replaces HZ in usb_*_msg timeouts with 1000 msec since HZ is one second for timeout

Re: [ath9k-devel] [PATCH] ath9k_htc: don't use HZ for usb msg timeouts

2017-01-07 Thread Anthony Romano
Hi Oleksij, I put 4 ar9271's on a 4 port hub into monitor mode for you and all interfaces are simultaneously collecting packets. My cheap USB power meter reads 4.37v@650mA between the hub and the host, so it's pushing the limit but appears stable. On Mon, Nov 28, 2016 at 7:34 AM, Oleksij Rempel

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2017-01-07 Thread Antonio Quartulli
On Wed, Oct 26, 2016 at 05:05:14PM +0300, Kalle Valo wrote: > Antonio Quartulli writes: > > > From: Antonio Quartulli > > > > This patch was crafted long time ago to work around a key cache > > corruption problem on ath9k chipsets. > > > > The workaround consists in periodically triggering a wor

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2017-01-07 Thread Antonio Quartulli
Hello, I am trying to understand what's required by this patch to be merged upstream. Sven Eckelmann commented in another email by saying: "The patch itself has (at least) one big problem. It is using some mac80211 internals in ath_key_config_iter to make sure that the uploaded keys were actually

[ath9k-devel] [PATCH] fix:gpio: mark symbols static where possible

2017-01-07 Thread Baoyou Xie
We get 1 warning about global functions without a declaration in the ath9k gpio driver when building with W=1: drivers/net/wireless/ath/ath9k/gpio.c:25:6: warning: no previous prototype for 'ath_fill_led_pin' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is de

[ath9k-devel] [PATCH v2] ath9k: mark ath_fill_led_pin() static

2017-01-07 Thread Baoyou Xie
We get 1 warning about global functions without a declaration in the ath9k gpio driver when building with W=1: drivers/net/wireless/ath/ath9k/gpio.c:25:6: warning: no previous prototype for 'ath_fill_led_pin' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is de

[ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2017-01-07 Thread Antonio Quartulli
From: Antonio Quartulli This patch was crafted long time ago to work around a key cache corruption problem on ath9k chipsets. The workaround consists in periodically triggering a worker that uploads all the keys to the HW cache. The worker is triggered also when the vif detects 21 undecryptable

Re: [ath9k-devel] ath9k: Fix beacon configuration assertion failure

2017-01-07 Thread Benjamin Berg
On Fr, 2016-08-19 at 13:03 +0300, Kalle Valo wrote: > Actually, I see two patches which might be related but not identical: > > ath9k: fix client mode beacon configuration > https://patchwork.kernel.org/patch/9247699/ > > ath9k: Fix beacon configuration assertion failure > https://patchwork.kerne

Re: [ath9k-devel] ath9k: Fix beacon configuration assertion failure

2017-01-07 Thread Ioan-Adrian Ratiu
On Mon, 22 Aug 2016, Kalle Valo wrote: > Benjamin Berg writes: > >> On Fr, 2016-08-19 at 13:03 +0300, Kalle Valo wrote: >>> Actually, I see two patches which might be related but not identical: >>> >>> ath9k: fix client mode beacon configuration >>> https://patchwork.kernel.org/patch/9247699/ >>

Re: [ath9k-devel] ath9k: Fix beacon configuration assertion failure

2017-01-07 Thread Ioan-Adrian Ratiu
Hi On Fri, 19 Aug 2016, Kalle Valo wrote: > Kalle Valo writes: > >> Adi Ratiu wrote: >>> commit cfda2d8e2314 ("ath9k: Fix beacon configuration for >>> addition/removal of interfaces") reworked beacon configs to happen at >>> IF changes and missed cases when NL80211_IFTYPE_STATION has no beacons

Re: [ath9k-devel] [PATCH v4] ath9k: Switch to using mac80211 intermediate software queues.

2017-01-07 Thread Arend van Spriel
On 23-08-16 08:59, Kalle Valo wrote: > Toke Høiland-Jørgensen writes: > > This is great work but due to the regressions I'm not sure if this > will be ready for 4.9. To get more testing time I wonder if we should > wait for 4.10? IMHO applying this in the end of the cycle is too ris

[ath9k-devel] [PATCH] ath9k: Fix beacon configuration assertion failure

2017-01-07 Thread Ioan-Adrian Ratiu
commit cfda2d8e2314 ("ath9k: Fix beacon configuration for addition/removal of interfaces") reworked beacon configs to happen at IF changes and missed cases when NL80211_IFTYPE_STATION has no beacons with the corresponding values iter_data.primary_beacon_vif == 0 and iter_data.nbcnvifs == 0 in ath9k

[ath9k-devel] A-MPDU Aggregation with ath9k_htc

2017-01-07 Thread Cristian Hernández
Hello, I have some doubts concerning about the ath9k driver and maybe you could help me. I am developing an open source C# program where I turn a computer into an Access Point that supports A-MPDU frame aggregation. All seems to work well, and the packet that is write in the socket is OK. H

Re: [ath9k-devel] [PATCH] tree-wide: replace config_enabled() with IS_ENABLED()

2017-01-07 Thread Andrew Morton
On Mon, 6 Jun 2016 21:20:56 +0900 Masahiro Yamada wrote: > The use of config_enabled() against config options is ambiguous. > In practical terms, config_enabled() is equivalent to IS_BUILTIN(), > but the author might have used it for the meaning of IS_ENABLED(). > Using IS_ENABLED(), IS_BUILTIN

[ath9k-devel] [PATCH 0767/1285] Replace numeric parameter like 0444 with macro

2017-01-07 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

[ath9k-devel] [PATCH 0766/1285] Replace numeric parameter like 0444 with macro

2017-01-07 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

Re: [ath9k-devel] [PATCH RFC v2 1/2] Documentation: dt: net: add ath9k wireless device binding

2017-01-07 Thread Arend Van Spriel
On 23-6-2016 19:45, Martin Blumenstingl wrote: > Add documentation how devicetree can be used to configure ath9k based > devices. > > Signed-off-by: Martin Blumenstingl > --- > changes in v1 -> v2: > - use vendor prefix "qca" instead of "ath" > - extend the example so it includes the "compatibl

[ath9k-devel] [PATCH] ath9k: fix checkpatch.pl identation and sapce errors.

2017-01-07 Thread Ashwini Singh
Signed-off-by: Ashwini Singh --- drivers/net/wireless/ath/ath9k/ani.c|2 +- drivers/net/wireless/ath/ath9k/antenna.c|2 +- drivers/net/wireless/ath/ath9k/ar9002_hw.c |2 +- drivers/net/wireless/ath/ath9k/ar9002_phy.c |2 +- drivers/net/wireless/ath/ath