Re: [ath9k-devel] ath9k: Fix beacon configuration assertion failure

2017-01-07 Thread Benjamin Berg
On Fr, 2016-08-19 at 13:03 +0300, Kalle Valo wrote: > Actually, I see two patches which might be related but not identical: > > ath9k: fix client mode beacon configuration > https://patchwork.kernel.org/patch/9247699/ > > ath9k: Fix beacon configuration assertion failure > https://patchwork.kerne

[ath9k-devel] [PATCH] ath9k: Prevent radar detection and spectral scan to be used concurrently

2016-11-21 Thread Benjamin Berg
d and only analysing the PHY errors for DFS if radar detection is enabled. Signed-off-by: Mathias Kretschmer Signed-off-by: Benjamin Berg Signed-off-by: Simon Wunderlich --- drivers/net/wireless/ath/ath9k/common-spectral.c | 23 +++ drivers/net/wireless/ath/ath9k/main.c

[ath9k-devel] [PATCH v2 3/6] ath9k: Use tsf offset helper in ath9k_hw_reset

2016-07-04 Thread Benjamin Berg
From: Benjamin Berg These changes make ath9k_hw_reset more consistent with other places that handle the TSF value by using the same helper routine. A slight improvement is to not assume that a fixed time of 1.5ms has passed for the initval writes when compared to the first write attempt

[ath9k-devel] [PATCH v2 1/6] ath9k: Correct TSF adjustment to align the beacon time correctly

2016-07-04 Thread Benjamin Berg
From: Benjamin Berg Beacons were not send out at (timestamp % beacon_time == 0) for interfaces other than the primary one. To send out beacons with the correct timestamp according to 10.1.3.2 of the 802.11 standard the tsf_adjustment has to be set to the negative time difference instead of

[ath9k-devel] [PATCH v2 4/6] ath9k: Expose tsf_adjustment in mac80211 tsf getters and setters.

2016-07-04 Thread Benjamin Berg
From: Benjamin Berg The ath9k driver modifies the TSF for VIFs for the purpose of sending beacons in a staggered fashion. This patch exposes this VIF specific adjustment of the TSF value to mac80211. Without the change the TSF routines handle the hardware TSF value instead of the actual TSF

[ath9k-devel] [PATCH v2 2/6] ath9k: Handle channel context in get_/set_/reset_tsf

2016-07-04 Thread Benjamin Berg
From: Benjamin Berg The ath9k TSF handling routines need to be aware of the channel context that is being modified. With this change the TSF related values that are stored in each channel context will be correctly tracked and the harware will only be updated if the modified context is currently

[ath9k-devel] [PATCH v2 6/6] ath9k: Fix beacon configuration for addition/removal of interfaces

2016-07-04 Thread Benjamin Berg
From: Benjamin Berg This patch fixes some issues with interface reconfiguration. It could for example happen that an AP interface in beacon slot 0 was removed leaving an IBSS station in one of the other slots. When this happens the driver never sends out the beacon as it only tries to send a

[ath9k-devel] [PATCH v2 5/6] ath9k: Remove some #defined constants to decrease verbosity

2016-07-04 Thread Benjamin Berg
From: Benjamin Berg The removed ATH9K_SLOT_TIME_X constants simply map the value in microseconds to the same integer. These constants were not used consistently, so fix the inconsistency issue by replacing all occurances with the integer equivalent. Signed-off-by: Benjamin Berg --- drivers

[ath9k-devel] [PATCH 4/6] ath9k: Expose tsf_adjustment in mac80211 tsf getters and setters.

2016-06-07 Thread Benjamin Berg
From: Benjamin Berg Signed-off-by: Benjamin Berg --- drivers/net/wireless/ath/ath9k/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index 375c2ac..f2ebc85 100644 --- a/drivers/net/wireless/ath/ath9k

[ath9k-devel] [PATCH 6/6] ath9k: Fix beacon configuration for addition/removal of interfaces

2016-06-07 Thread Benjamin Berg
From: Benjamin Berg This patch fixes some issues with interface reconfiguration. It could for example happen that an AP interface in beacon slot 0 was removed leaving an IBSS station in one of the other slots. This patch approaches these failures by reconfiguring the beacon configuration from

[ath9k-devel] [PATCH 3/6] ath9k: Use tsf offset helper in ath9k_hw_reset

2016-06-07 Thread Benjamin Berg
From: Benjamin Berg Not much of a change. Only small fix is that we don't assume that exactly 1.5ms have passed for the second AR91xx SoC TSF setting. Signed-off-by: Benjamin Berg --- drivers/net/wireless/ath/ath9k/hw.c | 16 1 file changed, 8 insertions(+), 8 dele

[ath9k-devel] [PATCH 2/6] ath9k: Handle channel context in get_/set_/reset_tsf

2016-06-07 Thread Benjamin Berg
From: Benjamin Berg Signed-off-by: Benjamin Berg --- drivers/net/wireless/ath/ath9k/main.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index 8b63988..375c2ac 100644

[ath9k-devel] [PATCH 5/6] ath9k: Use defined constants consistently.

2016-06-07 Thread Benjamin Berg
From: Benjamin Berg Signed-off-by: Benjamin Berg --- drivers/net/wireless/ath/ath9k/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index f2ebc85..6a81298 100644 --- a/drivers/net

[ath9k-devel] [PATCH 1/6] ath9k: Correct TSF adjustment to align the beacon time correctly

2016-06-07 Thread Benjamin Berg
From: Benjamin Berg Beacons need to be send out at timestamp % beacon_time == 0. Signed-off-by: Benjamin Berg --- drivers/net/wireless/ath/ath9k/beacon.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/beacon.c b/drivers/net

Re: [ath9k-devel] ath9k hangs with recent backports

2015-09-18 Thread Benjamin Berg
On Di, 2015-08-04 at 16:33 -0400, Marty Faltesek wrote: > We are seeing a hang on ath9k where traffic and beacons stops anywhere > from a few minutes to half a day. Log output continues. With debug > enabled, we see this during the hang: > > ath: phy0: tx hung, resetting the chip. > > The issue w

[ath9k-devel] [PATCH] ath9k: Prevent radard detection and spectral scan to be used concurrently

2015-06-01 Thread Benjamin Berg
d and only analysing the PHY errors for DFS if radar detection is enabled. Reported-by: Mathias Kretschmer Signed-off-by: Benjamin Berg Signed-off-by: Simon Wunderlich [v3.19+] --- The patch does apply to 3.19+ with a bit of fuzz. drivers/net/wireless/ath/ath9k/common-spectral.c | 4 d

Re: [ath9k-devel] [PATCH] ath9k: Configure beacons for AP vif if this has not happened yet

2015-03-13 Thread Benjamin Berg
On Fr, 2015-03-13 at 15:27 +0100, Felix Fietkau wrote: > I sent the following patch yesterday - I think it addresses the exact > same issue. Please test it to see if it works for you as well. The patch looks a lot better. I just backported it and it is working just fine for me. Benjamin > Subje

[ath9k-devel] [PATCH] ath9k: Configure beacons for AP vif if this has not happened yet

2015-03-13 Thread Benjamin Berg
coning has been configured yet (or configuration is scheduled) and allows the configuration in that case. This works around the issue here, but I have no idea whether it is a sane solution. Signed-off-by: Benjamin Berg --- drivers/net/wireless/ath/ath9k/beacon.c | 3 ++- 1 file changed, 2 insert

[ath9k-devel] [RFC] ath9k: Configure beacons for AP vif if this has not happened yet

2015-03-10 Thread Benjamin Berg
Right now there is a bug where beaconing might not be enabled correctly if the user has configuring multiple VIFs. The issue surfaces if the userspace first creates the AP devices and only then configures the first VIF (ath9k_bss_info_changed is called). In this case the current ath9k_allow_beacon_