Re: [ath9k-devel] [PATCH 1/3 v2] ath9k: handle RoC cancel correctly

2015-07-20 Thread Kalle Valo
...@tieto.com When changing something in a patchset please resend the whole series, not just the patch which has changed. So please resend the whole series as v3. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] ath9k: DFS - consider ext_channel pulses only in HT40 mode

2015-07-11 Thread Kalle Valo
-next.git. Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] ath9k: DFS - add pulse chirp detection for FCC

2015-07-11 Thread Kalle Valo
-next.git. Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath: DFS - limit number of potential PRI sequences

2015-06-30 Thread Kalle Valo
of PRI sequences accounted at runtime (and with it CPU load) is reduced by up to 50%. Signed-off-by: Zefir Kurtisi zefir.kurt...@neratec.com Thanks, applied to ath.git. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] ath9k_htc: memory corruption calling set_bit()

2015-05-26 Thread Kalle Valo
, applied to wireless-drivers-next.git. Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath9k_htc: wmi: match wait_for_completion_timeout return type

2015-05-21 Thread Kalle Valo
Nicholas Mc Guire der.h...@hofr.at writes: On Thu, 14 May 2015, Kalle Valo wrote: Nicholas Mc Guire hof...@osadl.org writes: Patch is against 4.1-rc3 (localversion-next is -next-20150514) BTW, this info should be under --- line so that it doesn't get stored to the actual commit log

Re: [ath9k-devel] [01/11] ath9k: Add a new debug flag for FFT spectral scan

2015-05-09 Thread Kalle Valo
on ath9k_htc Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] ath9k_htc: check seq number instead of cmd id for timeout

2015-04-07 Thread Kalle Valo
From: Fred Chou fred.chou...@gmail.com As the driver may send multiple wmi commands with identical cmd id, it is more robust to check seq number for timeout instead. Signed-off-by: Fred Chou fred.chou...@gmail.com Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [ath9k-devel] [v3, 01/18] ath9k_htc: add new WMI_REG_RMW_CMDID command

2015-03-30 Thread Kalle Valo
eaa4059d56fd ath9k: use REG_RMW and rmw buffer in ath9k_hw_def_set_gain Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 16/18 v2] ath9k: use REG_RMW and rmw buffer in ath9k_hw_4k_set_gain

2015-03-21 Thread Kalle Valo
reliable that way. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [v2,01/11] ath9k: Add initial structures for AIC

2015-03-20 Thread Kalle Valo
958b6827b781 ath9k: Handle MCI_STATE_AIC_CAL_RESET f2ef792a8085 ath9k: Handle MCI_STATE_AIC_START 60544603b669 ath9k: Handle MCI_STATE_AIC_CAL 7644317bd39c ath9k: Start AIC calibration during MCI reset Kalle Valo ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] [PATCH v2 02/11] ath9k: Register private AIC ops

2015-03-20 Thread Kalle Valo
already saw the error from kbuild: ERROR: ar9003_hw_attach_aic_ops [drivers/net/wireless/ath/ath9k/ath9k_hw.ko] undefined! Can you send a fix for this, please? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org

Re: [ath9k-devel] [PATCH v2 02/11] ath9k: Register private AIC ops

2015-03-20 Thread Kalle Valo
Sujith Manoharan suj...@msujith.org writes: Kalle Valo wrote: I guess you already saw the error from kbuild: ERROR: ar9003_hw_attach_aic_ops [drivers/net/wireless/ath/ath9k/ath9k_hw.ko] undefined! Can you send a fix for this, please? This slipped through the radar... I've posted

Re: [ath9k-devel] [PATCH] ath9k: Configure beacons for AP vif if this has not happened yet

2015-03-13 Thread Kalle Valo
, I guess I missed this the last time but ath9k patches need to be CCed to linux-wireless for wider review. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [next] ath9k: make ath_frame_info fit into reduced-sizerate_driver_data

2015-03-13 Thread Kalle Valo
pre-requisite to shrink size of ieee80211_tx_info which in turn is needed to shrink skb-cb to 40 bytes again. Signed-off-by: Florian Westphal f...@strlen.de Thanks, applied to wireless-drivers-next.git. Kalle Valo ___ ath9k-devel mailing list

Re: [ath9k-devel] [PATCH] ath9k_htc: force FW v1.4.0

2015-03-12 Thread Kalle Valo
with 1.3 Yeah, that's better. The crystall ball[1] says that 4.2 will be released in August, that should be plenty of time for user space to catch up. So if you resend this end of April or so the patch should go to 4.2. [1] http://phb-crystal-ball.org/ -- Kalle Valo

Re: [ath9k-devel] [RFC] ath9k: Configure beacons for AP vif if this has not happened yet

2015-03-10 Thread Kalle Valo
. The fix in this patch simply checks whether beaconing has been configured yet (or configuration is scheduled) and allows the configuration in that case. This works around the issue here, but I have no idea whether it is a sane solution. Signed-off-by is missing. -- Kalle Valo

Re: [ath9k-devel] [PATCH] ath9k_htc: force FW v1.4.0

2015-03-10 Thread Kalle Valo
the new version, that way user space has time to catch up. Maybe for now you could add a warning about using old firmware version? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k

Re: [ath9k-devel] [PATCH] ath9k_htc: avoid memcpy when downloading firmware

2015-03-03 Thread Kalle Valo
Fred Chou fred.chou...@gmail.com writes: Are you sure usb_control_msg() accepts vmalloc()ed buffers ? My guess is the answer is no. I agree, and I would like to drop the patch. Thanks. I dropped it from my queue. -- Kalle Valo ___ ath9k

Re: [ath9k-devel] ath9k_htc: Add new USB ID

2015-02-26 Thread Kalle Valo
and the patch has been tested on real hardware. Signed-off-by: Leon Nardella leon.narde...@gmail.com Thanks, applied to wireless-drivers-next.git. Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k

Re: [ath9k-devel] [PATCH] ath9k_htc: add adaptive usb receive flow control to repair soft lockup with monitor mode

2015-02-11 Thread Kalle Valo
add a changelog after --- line. Documentation/SubmittingPatches should tell you all this. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] ath9k: Delete an unnecessary check before the function callrelay_close

2015-02-05 Thread Kalle Valo
. Signed-off-by: Markus Elfring elfr...@users.sourceforge.net Thanks, applied to wireless-drivers-next.git. Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath9k_htc: add adaptive usb flow control to repair soft lockup with monitor mode

2015-02-03 Thread Kalle Valo
with the same name :) -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] Repair soft lockup with monitor mode of ath9k_htc card

2015-01-30 Thread Kalle Valo
prefix the title with ath9k_htc: . -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] Repair soft lockup with monitor mode of ath9k_htc card

2015-01-29 Thread Kalle Valo
! :D Please run ./scripts/checkpatch.pl yourpatch_path i get: total: 139 errors, 12 warnings, 2 checks, 231 lines checked Also please add ath9k_htc: prefix to the title. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] [PATCH] ath9k and ath9k_htc: rename variable led_blink

2015-01-24 Thread Kalle Valo
very much recommended to add the actual compiler error to the commit log: drivers/net/wireless/ath/ath9k/ath9k_htc.o:(.data+0x47c): multiple definition of `led_blink' drivers/net/wireless/ath/ath9k/ath9k.o:(.bss+0x20): first defined here -- Kalle Valo

Re: [ath9k-devel] ath9k_htc: remove dead code in error path of ath9k_htc_txcompletion_cb

2015-01-23 Thread Kalle Valo
This clause is conditioned on htc_hdr != NULL, but it will only be NULL when that check is reached. Coverity: CID 114318 Signed-off-by: John W. Linville linvi...@tuxdriver.com Thanks, applied to wireless-drivers-next.git. Kalle Valo ___ ath9k

Re: [ath9k-devel] [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries

2015-01-15 Thread Kalle Valo
. Cc: ath9k-devel@lists.ath9k.org Signed-off-by: Arend van Spriel ar...@broadcom.com Thanks, applied to wireless-drivers-next.git. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k

Re: [ath9k-devel] [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled

2015-01-15 Thread Kalle Valo
or what's the plan? I didn't quite get the conclusion from the discussion. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries

2015-01-07 Thread Kalle Valo
? I'm hesitant to apply this without testing. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] changes to Linux wireless maintenance

2014-12-18 Thread Kalle Valo
through git, my hope is that they will not place any significant burden on Dave. As for the wireless driver patches, I have asked Kalle Valo to handle patch review and merge duties for everything under the drivers/net/wireless directory. This will now include not only the ath patches he already

Re: [ath9k-devel] [PATCH] ath9k/ath10k: remove unnecessary channel_switch_beacon callbacks

2014-05-23 Thread Kalle Valo
removes them. Cc: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Luciano Coelho luciano.coe...@intel.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath9k/ath10k: remove unnecessary channel_switch_beacon callbacks

2014-05-16 Thread Kalle Valo
(non) users of it. ;) John, I'm planning to take this as I think we will get less conflicts that way. But let me know if you want it instead. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo

Re: [ath9k-devel] [PATCH 1/5] ath: add common function ath_is_mybeacon

2014-01-16 Thread Kalle Valo
. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2 1/3] ath10k: implement device recovery

2013-07-15 Thread Kalle Valo
Hi Michal, sorry, I forgot to answer this one. Michal Kazior michal.kaz...@tieto.com writes: On 5 July 2013 09:47, Kalle Valo kv...@qca.qualcomm.com wrote: I feel that RESTARTING_OFF and RESTARTING_ON are a bit confusing names, especially when we have OFF and ON states. Wouldn't RESTARTING

[ath9k-devel] ath10k mailing list and new git tree

2013-07-08 Thread Kalle Valo
updated the wiki accordingly: http://wireless.kernel.org/en/users/Drivers/ath10k -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] ath10k mailing list and new git tree

2013-07-08 Thread Kalle Valo
Sedat Dilek sedat.di...@gmail.com writes: On Mon, Jul 8, 2013 at 4:17 PM, Kalle Valo kv...@qca.qualcomm.com wrote: Hi, we have a new mailing list for ath10k, please use that in the future instead of ath9k-devel: http://lists.infradead.org/mailman/listinfo/ath10k As ath10k is now

Re: [ath9k-devel] [PATCH v3 1/9] ath10k: decouple pci start/stop logic

2013-07-05 Thread Kalle Valo
, right? Or I misunderstand the meaning. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v3 5/9] ath10k: decouple suspend code

2013-07-05 Thread Kalle Valo
a quick look this function looks racy. Can we trust that there's no other code path which could create problems during suspend? Or should we properly serialise this, eg. by using conf_mutex and adding a new state? I hope I didn't ask this already before, I just came back from vacation :) -- Kalle

Re: [ath9k-devel] [PATCH v3 6/9] ath10k: move free_vdev_map initialization

2013-07-05 Thread Kalle Valo
*/ [...] + ar-free_vdev_map = (1 TARGET_NUM_VDEVS) - 1; As you do more than just move the initialisation you should also mention that in the commit log. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] [PATCH v3 10/10] ath10k: skip fw stats debugfs interface if device is down

2013-07-05 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- I've missed this patch. It should go along with this patchset. Sorry for the mess. Please write a commit log. -- Kalle Valo ___ ath9k-devel

Re: [ath9k-devel] [PATCH v3 5/9] ath10k: decouple suspend code

2013-07-05 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 5 July 2013 08:51, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: +#ifdef CONFIG_PM +static int ath10k_suspend(struct ieee80211_hw *hw, + struct cfg80211_wowlan *wowlan

Re: [ath9k-devel] [PATCH v2 1/3] ath10k: implement device recovery

2013-07-05 Thread Kalle Valo
and RESTARTED be simpler? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

[ath9k-devel] [PATCH 02/16] ath10k: fix possible deadlock

2013-07-05 Thread Kalle Valo
From: Michal Kazior michal.kaz...@tieto.com It was possible to have a deadlock due to inverted locking of local-iflist_mtx and ath10k-conf_mutex. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c

[ath9k-devel] [PATCH 00/16] ath10k: pending patches

2013-07-05 Thread Kalle Valo
Hi, here are pending patches which were commited to ath10k.git while ath10k was under review. They were only sent to ath9k-devel, I'm resending them now before I reapply them to my new ath.git tree. Michal Kazior (16): ath10k: fix teardown ordering ath10k: fix possible deadlock ath10k:

[ath9k-devel] [PATCH 09/16] ath10k: provide errno if bmi read/write fails

2013-07-05 Thread Kalle Valo
From: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/bmi.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH 05/16] ath10k: remove ath10k_bus

2013-07-05 Thread Kalle Valo
From: Michal Kazior michal.kaz...@tieto.com It serves no purpose. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.c |2 -- drivers/net/wireless/ath/ath10k/core.h |6 -- drivers/net

[ath9k-devel] [PATCH 11/16] ath10k: rename hif callback

2013-07-05 Thread Kalle Valo
From: Michal Kazior michal.kaz...@tieto.com The `set_callbacks` is a more appopriate name for the function. Let's leave `init` for something else. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/hif.h

[ath9k-devel] [PATCH 16/16] ath10k: add missing debug prints

2013-07-05 Thread Kalle Valo
From: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b

[ath9k-devel] [PATCH 15/16] ath10k: abort scan properly if wmi_scan_stop fails

2013-07-05 Thread Kalle Valo
From: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers

[ath9k-devel] [PATCH 06/16] ath10k: fix typo in define name

2013-07-05 Thread Kalle Valo
From: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/ce.c |2 +- drivers/net/wireless/ath/ath10k/pci.c |6 +++--- drivers/net/wireless/ath/ath10k/pci.h |4

[ath9k-devel] [PATCH 07/16] ath10k: silent warning in IBSS mode

2013-07-05 Thread Kalle Valo
From: Michal Kazior michal.kaz...@tieto.com There is no TIM IE generated in IBSS beacons by mac80211. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.c |4 ++-- 1 file changed, 2 insertions(+), 2

[ath9k-devel] [PATCH 10/16] ath10k: change function to take struct ath10k as arg

2013-07-05 Thread Kalle Valo
From: Michal Kazior michal.kaz...@tieto.com This aligns it to the argument list of other similar functions. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/pci.c |6 +++--- 1 file changed, 3 insertions

[ath9k-devel] [PATCH 04/16] ath10k: do not setup rts/frag thresholds for suspended interfaces

2013-07-05 Thread Kalle Valo
() hook anyway. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath

[ath9k-devel] [PATCH 03/16] ath10k: setup rts/frag thresholds upon vdev creation

2013-07-05 Thread Kalle Valo
michal.kaz...@tieto.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 9943ee9

[ath9k-devel] [PATCH 01/16] ath10k: fix teardown ordering

2013-07-05 Thread Kalle Valo
From: Michal Kazior michal.kaz...@tieto.com This should fix memory corruption if HIF is tried to be restarted. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/pci.c |2 +- 1 file changed, 1 insertion

[ath9k-devel] [PATCH 08/16] ath10k: lower print level for a message

2013-07-05 Thread Kalle Valo
From: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htc.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH 12/16] ath10k: embed HTC struct inside ath10k

2013-07-05 Thread Kalle Valo
From: Michal Kazior michal.kaz...@tieto.com This reduces number of allocations and simplifies memory managemnt. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.c | 28

Re: [ath9k-devel] [PATCH v2] ath10k: fix MSI-X setup failpath

2013-07-05 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Irqs were not freed up correctly upon msi-x setup failure. Signed-off-by: Michal Kazior michal.kaz...@tieto.com John has already applied this. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] [PATCH v2] ath10k: fix 5ghz channel definitions

2013-07-05 Thread Kalle Valo
michal.kaz...@tieto.com John also applied this already. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2] ath10k: leave MMIC generation to the HW

2013-07-05 Thread Kalle Valo
or fragmented IP traffic. Signed-off-by: Michal Kazior michal.kaz...@tieto.com This is also applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [patch] ath10k: off by one sanity check

2013-07-05 Thread Kalle Valo
Dan Carpenter dan.carpen...@oracle.com writes: This should be = ARRAY_SIZE() instead of ARRAY_SIZE(). Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Thanks for the patch. John already applied this to his wireless-next tree. -- Kalle Valo

Re: [ath9k-devel] drivers/net/wireless/ath/ath10k/mac.c:1264:8: warning: format '%zd' expects argument of type 'signed size_t', but argument 4 has type 'long int'

2013-07-05 Thread Kalle Valo
Hi Fengguang, Fengguang Wu fengguang...@intel.com writes: FYI, there are new compile warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next master head: fa1383200d289afdff2f5678eb89483daa537465 commit: 5e3dd157d7e70f0e3cea3f2573ed69fb156a19d5 ath10k:

[ath9k-devel] [PATCH] ath10k: remove unneeded semicolon

2013-07-05 Thread Kalle Valo
Coccinelly found: drivers/net/wireless/ath/ath10k/htt_rx.c:1163:2-3: Unneeded semicolon Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htt_rx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [ath9k-devel] [PATCH] ath10k: fix MSI-X setup failpath

2013-06-25 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Signed-off-by: Michal Kazior michal.kaz...@tieto.com Please write a commit log. No matter how trivial the patch is, it should have a commit log. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] [PATCH 5/6] ath10k: wait for CE to drain when shutting down

2013-06-14 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 13/06/13 20:08, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: ath10k_pci_process_ce() is used to process completions. Only one thread can do that though. If one thread starts handling completions then the other one (i.e

Re: [ath9k-devel] [PATCH v2 01/10] ath10k: decouple pci init/deinit logic

2013-06-14 Thread Kalle Valo
require the aforementioned proper alloc/init/setup separation to be done first. Yeah, we can discuss about this later. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2 08/10] ath10k: defer hw setup to start/stop mac80211 hooks

2013-06-14 Thread Kalle Valo
is not cleaning up it's somewhere else (in resume path?), or mac80211 is buggy/strange. Also I didn't fully get when state changes from RESTARTING to ON. Can you describe that, please? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] [PATCH 1/3] ath10k: implement device recovery

2013-06-14 Thread Kalle Valo
we have such a function? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 3/3] ath10k: create debugfs interface to trigger fw crash

2013-06-14 Thread Kalle Valo
simple_read_from_buffer(user_buf, count, ppos, buf, strlen(buf)); +} But I'm not sure if just writing something to the file is a good idea. Should it have some sort of protection, for example that user needs to write a keyword or something? -- Kalle Valo ___ ath9k-devel

Re: [ath9k-devel] [PATCH 3/3] ath10k: create debugfs interface to trigger fw crash

2013-06-14 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 14/06/13 14:34, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: This can be useful for testing. Signed-off-by: Michal Kazior michal.kaz...@tieto.com This is handy. +static ssize_t ath10k_read_simulate_fw_crash(struct file

Re: [ath9k-devel] [PATCH 5/6] ath10k: wait for CE to drain when shutting down

2013-06-13 Thread Kalle Valo
it be a better to fix make sure that all threads/tasklets are stopped, for example with tasklet_kill() and cancel_work_sync()? (And of course first making sure that we don't fire new instances). That way we could be sure that there is no other thread running while we shutdown. -- Kalle Valo

Re: [ath9k-devel] [PATCH 0/6] ath10k: fixes

2013-06-13 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: Michal Kazior michal.kaz...@tieto.com writes: This includes 2 patches from my previous patchset that had conflicts. It is now rebased and should apply cleanly on the github master branch. Michal Kazior (6): ath10k: embed HTC struct inside ath10k

Re: [ath9k-devel] [PATCH v2 01/10] ath10k: decouple pci init/deinit logic

2013-06-13 Thread Kalle Valo
() and ath10k_pci_ce_start(). And the former would be called only from ath10k_pci_probe(). That way we would not need to do any memory allocation during start time. But no need to refactor it right now, this is good enough for the first implementation. -- Kalle Valo

Re: [ath9k-devel] [PATCH] mac80211: ath9k: Use RCU protection calling ieee80211_get_tx_rates

2013-06-12 Thread Kalle Valo
Johannes Berg johan...@sipsolutions.net writes: Now the subject should no longer say mac80211: :) It did have a change to mac80211.h as well, but IMHO that should be in a separate patch. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] [PATCH 0/6] ath10k: fixes

2013-06-12 Thread Kalle Valo
. It just confuses everyone, especially me. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 02/10] ath10k: decouple core init/deinit logic

2013-06-10 Thread Kalle Valo
(): Initialises hw/fw. Called every time we start the firmware. stop(): Kills the running fw. Shuts down all power the device (when possible) But here ath10k_core_init() seems to be initialising hw/fw. So should it be renamed to ath10k_core_start()? -- Kalle Valo

Re: [ath9k-devel] [PATCH 03/10] ath10k: allow deferred regd update

2013-06-10 Thread Kalle Valo
, ATH6KL_STATE_RECOVERY, }; I think ON and OFF states would be enough for ath10k currently. We can extend them as we add more features. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k

Re: [ath9k-devel] [PATCH 04/10] ath10k: reset BMI state upon init

2013-06-10 Thread Kalle Valo
status; + ar-bmi.done_sent = false; We should do this in ath10k_bmi_start() so that all BMI related code is in bmi.c. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 09/10] ath10k: handle hw reconfiguration properly

2013-06-10 Thread Kalle Valo
resume case, please? If the idea is to initialise the hardware to a pristine state that we can boot the firmware, please refactor the code into it's own function. This just looks wrong. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org

Re: [ath9k-devel] [PATCH 0/2] ath10k: cleanup

2013-06-10 Thread Kalle Valo
applying this. Can you please rebase and resend? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 0/4] ath10k: fixes

2013-06-07 Thread Kalle Valo
the observation about an incomplete FW feature, this looks good to me. I applied that patch anyway as I'm hoping it will be implemented in fw eventually. Thanks for the review. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] [PATCH 0/7] ath10k: more fixes

2013-06-07 Thread Kalle Valo
warning in IBSS mode ath10k: lower print level for a message ath10k: provide errno if bmi read/write fails ath10k: change function to take struct ath10k as arg ath10k: rename hif callback Thanks, all applied. -- Kalle Valo ___ ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: fix sparse warning

2013-06-01 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: The line was over 80 characters long. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] [PATCH 2/2] ath10k: Neaten ath10k_level uses

2013-06-01 Thread Kalle Valo
#37 FAILED at 2532. Hunk #38 succeeded at 2920 (offset 96 lines). Hunk #39 succeeded at 3033 (offset 101 lines). 18 out of 39 hunks FAILED -- saving rejects to file drivers/net/wireless/ath/ath10k/mac.c.rej -- Kalle Valo ___ ath9k-devel mailing list

Re: [ath9k-devel] [PATCH] ath10k: fix hw scan cancelling

2013-05-28 Thread Kalle Valo
...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: sync WMI interface to FW 636

2013-05-28 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. But a small commit log is always good to have. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] [PATCH 0/7] ath10k: tx flow control fixes

2013-05-28 Thread Kalle Valo
asserts to htc skb dequeuing ath10k: simplify htc flow control ath10k: remove unused queue limit ath10k: introduce proper htt tx flow control ath10k: detect htt pending tx limit at runtime Thanks, all patches applied. -- Kalle Valo ___ ath9k

Re: [ath9k-devel] [PATCH 6/7] ath10k: introduce proper htt tx flow control

2013-05-28 Thread Kalle Valo
if it should be an inline function. But that can be done in a followup patch (if needed). -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 0/7] ath10k: tx flow control fixes

2013-05-28 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: Michal Kazior michal.kaz...@tieto.com writes: This addresses some `tx failed` issues and minor issues I've found along. This is a resend as a PATCH rather than an RFC. Updates include: * added `ath10k: detect htt pending tx limit at runtime

Re: [ath9k-devel] [PATCH] ath10k: remove CTRY_DEFAULT assignment

2013-05-21 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: The country is be overwritten by the eeprom regdomain that we read from WMI event anyway. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing

Re: [ath9k-devel] [PATCH] ath10k: remove static mac address mask

2013-05-21 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: FW can dynamically adjust to multiple mac addresses. It reports it's preferred base mac address, but we can freely create derivative addresses for vdevs. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo

Re: [ath9k-devel] [PATCH] ath10k: remove unnecessary include

2013-05-21 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: We already do forward declaration of ath10k and ath10k_vif in wmi.h. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: program FW with appropriate regdomain

2013-05-21 Thread Kalle Valo
/ath10k/mac.c:1266: WARNING: Avoid CamelCase: regpair-regDmnEnum But there's not much we can do about that :) -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 6/6] ath10k: preliminary VHT support

2013-05-21 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 20/05/13 15:37, Kalle Valo wrote: Adds preliminary VHT (802.11ac) support to ath10k. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- @@ -983,6 +1013,8 @@ static void ath10k_peer_assoc_h_phymode(struct ath10k *ar, { enum

Re: [ath9k-devel] [PATCH 0/6] ath10k: vht support

2013-05-21 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: VHT support and small changes I did while working on it. --- Kalle Valo (6): ath10k: set vht_nss correctly ath10k: change chan_to_phymode() use chandef ath10k: remove band_center_freq() ath10k: include all management

Re: [ath9k-devel] [PATCH 1/2] ath10k: Convert ath10k_dbg uses

2013-05-20 Thread Kalle Valo
, this patch makes that impossible. And I don't really see that we have problems with ATH10K_DBG_WMI being too long. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

[ath9k-devel] [PATCH 1/6] ath10k: set vht_nss correctly

2013-05-20 Thread Kalle Valo
name: HP ProBook 6540b [ 1336.366943] Rate marked as a VHT rate but data is invalid: MCS: 27, NSS: 0 Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/txrx.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH 2/6] ath10k: change chan_to_phymode() use chandef

2013-05-20 Thread Kalle Valo
That's more logical instead of passing chandef fields one at a time. Also change ath10k_update_channel_list to hardcode the band directly. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c | 49 + 1 file changed, 31

[ath9k-devel] [PATCH 3/6] ath10k: remove band_center_freq()

2013-05-20 Thread Kalle Valo
We can take the frequency directly from struct cfg80211_chan_def. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c | 25 ++--- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b

<    1   2   3   4   5   >