Re: [ath9k-devel] [PATCH 0/11] use ether_addr_equal_64bits

2014-01-17 Thread Pavel Machek
On Mon 2013-12-30 19:14:56, Julia Lawall wrote: Ether_addr_equal_64bits is more efficient than ether_addr_equal, and can be used when each argument is an array within a structure that contains at least two bytes of data beyond the array. I mean, yes, it is probably faster, and yes, most

Re: [ath9k-devel] [PATCH 0/11] use ether_addr_equal_64bits

2014-01-17 Thread Pavel Machek
On Fri 2014-01-17 23:02:06, Oleksij Rempel wrote: Am 17.01.2014 22:24, schrieb Pavel Machek: On Mon 2013-12-30 19:14:56, Julia Lawall wrote: Ether_addr_equal_64bits is more efficient than ether_addr_equal, and can be used when each argument is an array within a structure that contains

[ath9k-devel] [PATCH] fix endianity on ath9k_htc

2010-11-29 Thread Pavel Machek
It seems struct eep_header lacks proper #ifdef BIG_ENDIAN_BITFIELD markup. eep_4k_header has proper markup, but two fields were swapped. Signed-off-by: Pavel Machek p...@sysgo.com diff --git a/drivers/net/wireless/ath/ath9k/eeprom.h b/drivers/net/wireless/ath/ath9k/eeprom.h index 3c99830

[ath9k-devel] [PATCH] ath9k_htc cleanups

2010-11-29 Thread Pavel Machek
This fixes whitespace and reduces ammount of ifdefed lines. Signed-off-by: Pavel Machek p...@sysgo.com diff --git a/drivers/net/wireless/ath/ath9k/eeprom.h b/drivers/net/wireless/ath/ath9k/eeprom.h index 3c99830..022589d 100644 --- a/drivers/net/wireless/ath/ath9k/eeprom.h +++ b/drivers/net

Re: [ath9k-devel] ath9k_htc vs. powerpc (was Re: working usb wifi card, that is still possible to buy)

2010-11-29 Thread Pavel Machek
Hi! Sujith, I see you fought with endianness issues on ath9k_htc driver. Was you able to test it on actual hardware? Should I try the version just after your commit? No, I never had a chance to test the driver on a big-endian system. I assume you are referring to this commit:

[ath9k-devel] [PATCH] ath9k_htc more cleanups

2010-11-29 Thread Pavel Machek
This fixes whitespace and fixes strings. Signed-off-by: Pavel Machek p...@sysgo.com diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c index c41ab8c..ac4aed7 100644 --- a/drivers/net/wireless/ath/ath9k/htc_hst.c +++ b/drivers/net/wireless/ath/ath9k

Re: [ath9k-devel] [PATCH] fix endianity on ath9k_htc

2010-11-29 Thread Pavel Machek
Hi! It seems struct eep_header lacks proper #ifdef BIG_ENDIAN_BITFIELD markup. eep_4k_header has proper markup, but two fields were swapped. Signed-off-by: Pavel Machek p...@sysgo.com diff --git a/drivers/net/wireless/ath/ath9k/eeprom.h b/drivers/net/wireless/ath/ath9k/eeprom.h

[ath9k-devel] [patch] remove unneeded prototype on ath9k_htc

2010-11-29 Thread Pavel Machek
The prototype does not seem to have corresponding function. Signed-off-by: Pavel Machek p...@sysgo.com diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h index cc8f3b9..ed5d199 100644 --- a/drivers/net/wireless/ath/ath9k/hw.h +++ b/drivers/net/wireless/ath

[ath9k-devel] ath9k_htc vs. powerpc (was Re: working usb wifi card, that is still possible to buy)

2010-11-26 Thread Pavel Machek
Hi! | D-Link DWA-131| 07d1:3303 | realtek?| | This one should work with driver r8712u in staging in kernel 2.6.37-rcX. I don't have this model for testing, but the DWA-130 is rock solid with that driver.

[ath9k-devel] [PATCH] ath9k_htc: cleanup eeprom endiannes handling

2010-11-26 Thread Pavel Machek
There are already in-place byte swapping macros in Linux, use them. Signed-off-by: Pavel Machek p...@sysgo.com diff --git a/drivers/net/wireless/ath/ath9k/eeprom_4k.c b/drivers/net/wireless/ath/ath9k/eeprom_4k.c index 4fa4d8e..ee4e893 100644 --- a/drivers/net/wireless/ath/ath9k/eeprom_4k.c

[ath9k-devel] [PATCH?] do structures need to be packed? [was Re: ath9k_htc vs. powerpc (was Re: working usb wifi card, that is still possible to buy)]

2010-11-26 Thread Pavel Machek
on powerpc... Pavel Signed-off-by: Pavel Machek p...@sysgo.com diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.h b/drivers/net/wireless/ath/ath9k/htc_hst.h index 07b6509..79ef4e7 100644 --- a/drivers/net/wireless/ath/ath9k