Re: [ath9k-devel] [PATCH] ath9k: Re-enable interrupts after a channel change failure

2013-04-02 Thread Felix Fietkau
On 2013-04-02 2:03 PM, Robert Shade wrote: On Mon, Apr 1, 2013 at 1:40 PM, Felix Fietkau n...@openwrt.org wrote: Your patch is badly whitespace damaged. Ouch, must be the gmail web client. I'll resubmit a fixed one. Why the call to ath9k_hw_set_interrupts here? Simply because that's

[ath9k-devel] [PATCH] ath9k: Re-enable interrupts after a channel change failure

2013-04-01 Thread Robert Shade
Re-enable interrupts after a channel change failure, since ath_complete_reset will not be called. Also schedule a reset as a best effort method to recover the chip from whatever state caused the channel change failure. Signed-off-by: Robert Shade robert.sh...@gmail.com ---

Re: [ath9k-devel] [PATCH] ath9k: Re-enable interrupts after a channel change failure

2013-04-01 Thread Adrian Chadd
You filed a bug against this, right? Can you mention the bug report in there? (What's the blessed way to mention a bugzilla.kernel.org bug in a linux git commit?) adrian On 1 April 2013 07:22, Robert Shade robert.sh...@gmail.com wrote: Re-enable interrupts after a channel change failure,

Re: [ath9k-devel] [PATCH] ath9k: Re-enable interrupts after a channel change failure

2013-04-01 Thread Robert Shade
Yes, https://bugzilla.kernel.org/show_bug.cgi?id=55771 It was actually at the bottom of my commit message, but now I see that it was cut off by git format-patch On Mon, Apr 1, 2013 at 12:25 PM, Adrian Chadd adr...@freebsd.org wrote: You filed a bug against this, right? Can you mention the bug

Re: [ath9k-devel] [PATCH] ath9k: Re-enable interrupts after a channel change failure

2013-04-01 Thread Felix Fietkau
On 2013-04-01 4:22 PM, Robert Shade wrote: Re-enable interrupts after a channel change failure, since ath_complete_reset will not be called. Also schedule a reset as a best effort method to recover the chip from whatever state caused the channel change failure. Signed-off-by: Robert Shade

Re: [ath9k-devel] [PATCH] ath9k: Re-enable interrupts after a channel change failure

2013-04-01 Thread John W. Linville
On Mon, Apr 01, 2013 at 09:25:43AM -0700, Adrian Chadd wrote: You filed a bug against this, right? Can you mention the bug report in there? (What's the blessed way to mention a bugzilla.kernel.org bug in a linux git commit?) I usually just include the URL. Fixes Bug #12345 would suffice as