Re: [ath9k-devel] [PATCH 1/2] mac80211: add sta_update_rates callback

2012-08-11 Thread Sujith Manoharan
Sujith Manoharan wrote: > We didn't have this new callback back then, and sta_rc_update() is sufficient > to > fix this. Maybe with a new flag - IEEE80211_RC_BASIC_RATES_CHANGED. Um, IEEE80211_RC_SUPP_RATES_CHANGED or something. Sujith ___ ath9k-devel

Re: [ath9k-devel] [PATCH 1/2] mac80211: add sta_update_rates callback

2012-08-11 Thread Sujith Manoharan
Antonio Quartulli wrote: > mh, at the very beginning I thought it was not correct what you said, but > indeed > we should be able to do the job in sta_rc_update(). > > But then why does the ath9k_htc driver implement ath9k_htc_update_rate() to > update the rate used to talk to the AP? Should it u

Re: [ath9k-devel] [PATCH 1/2] mac80211: add sta_update_rates callback

2012-08-09 Thread Antonio Quartulli
On Thu, Aug 09, 2012 at 11:32:46AM +0200, Antonio Quartulli wrote: > On Thu, Aug 09, 2012 at 08:14:57AM +0200, Johannes Berg wrote: > > Also there's already an update call sta_rc_update() so I think you > > should just define a new change flag for that? > > mh, at the very beginning I thought it w

Re: [ath9k-devel] [PATCH 1/2] mac80211: add sta_update_rates callback

2012-08-09 Thread Antonio Quartulli
On Thu, Aug 09, 2012 at 08:14:57AM +0200, Johannes Berg wrote: > On Thu, 2012-08-09 at 03:11 +0200, Antonio Quartulli wrote: > > some drivers need to be notified in case of rates update. This callback > > tells > > the driver that something has been changed in the supported rates set of the > > st

Re: [ath9k-devel] [PATCH 1/2] mac80211: add sta_update_rates callback

2012-08-08 Thread Johannes Berg
On Thu, 2012-08-09 at 03:11 +0200, Antonio Quartulli wrote: > some drivers need to be notified in case of rates update. This callback tells > the driver that something has been changed in the supported rates set of the > station passed as argument and that it needs to update its internal tables >

[ath9k-devel] [PATCH 1/2] mac80211: add sta_update_rates callback

2012-08-08 Thread Antonio Quartulli
some drivers need to be notified in case of rates update. This callback tells the driver that something has been changed in the supported rates set of the station passed as argument and that it needs to update its internal tables Reported-by: Guido Iribarren Tested-by: Guido Iribarren Signed-off