Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-09 Thread Johannes Berg
On Fri, 2011-01-07 at 14:46 -0800, Ben Greear wrote: On 01/07/2011 02:26 PM, Eric Dumazet wrote: Le vendredi 07 janvier 2011 à 14:20 -0800, Ben Greear a écrit : On 0 Using skb_copy() is wrong then, since it makes a copy (order-1 allocations) It should use : skb_alloc(

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-07 Thread Johannes Berg
On Thu, 2011-01-06 at 16:46 -0800, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Patch is from Eric Dumazet, as described here: https://patchwork.kernel.org/patch/104271/ Reported-by: Michael Guntsche m...@it-loops.com Signed-off-by: Eric Dumazet

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-07 Thread Ben Greear
On 01/07/2011 02:58 AM, Johannes Berg wrote: On Thu, 2011-01-06 at 16:46 -0800, gree...@candelatech.com wrote: From: Ben Greeargree...@candelatech.com Patch is from Eric Dumazet, as described here: https://patchwork.kernel.org/patch/104271/ Reported-by: Michael Guntschem...@it-loops.com

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-07 Thread Luis R. Rodriguez
On Fri, Jan 07, 2011 at 10:34:52AM -0800, Ben Greear wrote: On 01/07/2011 02:58 AM, Johannes Berg wrote: On Thu, 2011-01-06 at 16:46 -0800, gree...@candelatech.com wrote: From: Ben Greeargree...@candelatech.com Patch is from Eric Dumazet, as described here:

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-07 Thread Eric Dumazet
Le vendredi 07 janvier 2011 à 14:20 -0800, Ben Greear a écrit : On 0 Using skb_copy() is wrong then, since it makes a copy (order-1 allocations) It should use : skb_alloc( actual_size_of_frame not the 3840 thing ...) copy(data) We need the extra stuff copied too I think (like

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-07 Thread Ben Greear
On 01/07/2011 02:26 PM, Eric Dumazet wrote: Le vendredi 07 janvier 2011 à 14:20 -0800, Ben Greear a écrit : On 0 Using skb_copy() is wrong then, since it makes a copy (order-1 allocations) It should use : skb_alloc( actual_size_of_frame not the 3840 thing ...) copy(data) We need

[ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-06 Thread greearb
From: Ben Greear gree...@candelatech.com Patch is from Eric Dumazet, as described here: https://patchwork.kernel.org/patch/104271/ Reported-by: Michael Guntsche m...@it-loops.com Signed-off-by: Eric Dumazet eric.duma...@gmail.com Signed-off-by: Ben Greear gree...@candelatech.com --- NOTE: This

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-06 Thread Luis R. Rodriguez
On Thu, Jan 6, 2011 at 4:46 PM, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Patch is from Eric Dumazet, as described here: https://patchwork.kernel.org/patch/104271/ Reported-by: Michael Guntsche m...@it-loops.com Signed-off-by: Eric Dumazet

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-06 Thread Ben Greear
On 01/06/2011 04:57 PM, Luis R. Rodriguez wrote: On Thu, Jan 6, 2011 at 4:46 PM,gree...@candelatech.com wrote: From: Ben Greeargree...@candelatech.com Patch is from Eric Dumazet, as described here: https://patchwork.kernel.org/patch/104271/ Reported-by: Michael Guntschem...@it-loops.com

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-06 Thread Christian Lamparter
On Friday 07 January 2011 01:46:03 gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Patch is from Eric Dumazet, as described here: https://patchwork.kernel.org/patch/104271/ Reported-by: Michael Guntsche m...@it-loops.com Signed-off-by: Eric Dumazet

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-06 Thread Luis R. Rodriguez
On Thu, Jan 6, 2011 at 5:23 PM, Eric Dumazet eric.duma...@gmail.com wrote: Le vendredi 07 janvier 2011 à 02:04 +0100, Christian Lamparter a écrit : On Friday 07 January 2011 01:46:03 gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Patch is from Eric Dumazet, as

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-06 Thread Eric Dumazet
Le vendredi 07 janvier 2011 à 02:04 +0100, Christian Lamparter a écrit : On Friday 07 January 2011 01:46:03 gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Patch is from Eric Dumazet, as described here: https://patchwork.kernel.org/patch/104271/ Reported-by:

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-06 Thread Eric Dumazet
Le jeudi 06 janvier 2011 à 17:57 -0800, Luis R. Rodriguez a écrit : On Thu, Jan 6, 2011 at 5:23 PM, Eric Dumazet eric.duma...@gmail.com wrote: Le vendredi 07 janvier 2011 à 02:04 +0100, Christian Lamparter a écrit : On Friday 07 January 2011 01:46:03 gree...@candelatech.com wrote: From:

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-06 Thread Eric Dumazet
Le jeudi 06 janvier 2011 à 18:13 -0800, Luis R. Rodriguez a écrit : On Thu, Jan 6, 2011 at 6:07 PM, Eric Dumazet eric.duma...@gmail.com wrote: The only way to accept your patch is to use a debugfs option to disable it, we need AMSDU support enabled by default. I dont care of my patch ;)

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-06 Thread Eric Dumazet
Le vendredi 07 janvier 2011 à 03:24 +0100, Eric Dumazet a écrit : Given IEEE80211_MAX_MPDU_LEN is more than 3840, and skb shinfo adds more than 256 bytes, I can assert rx_bufsize is greater than 4096 : order-1 On 64bit arches : sizeof(struct skb_shared_info) = 0x198 = 408