Re: [ath9k-devel] [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes

2015-12-14 Thread Mark Brown
On Mon, Sep 14, 2015 at 09:21:54AM +0530, Viresh Kumar wrote: > Long back 'bool' type used to be a typecast to 'int', but that changed > in v2.6.19. And that is a typecast to _Bool now, which (mostly) takes > just a byte. Anyway, the bool type is implementation defined, and better > we don't assume

Re: [ath9k-devel] [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes

2015-12-14 Thread Arnd Bergmann
On Tuesday 15 September 2015 07:34:38 Viresh Kumar wrote: > On 14-09-15, 09:03, Greg KH wrote: > > What ever ones you think it is relevant for :) > > "Relevant" is a relevant term :) > > So, the patch which defined the type bool as _Bool was added in v2.6.19 :) > > 6e2182874324 ("[PATCH] Generic

Re: [ath9k-devel] [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes

2015-12-14 Thread Arnd Bergmann
On Monday 14 September 2015 09:21:54 Viresh Kumar wrote: > diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c > index b4c216bab22b..bea8e425a8de 100644 > --- a/drivers/acpi/ec_sys.c > +++ b/drivers/acpi/ec_sys.c > @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, > uns

[ath9k-devel] [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes

2015-12-14 Thread Viresh Kumar
Long back 'bool' type used to be a typecast to 'int', but that changed in v2.6.19. And that is a typecast to _Bool now, which (mostly) takes just a byte. Anyway, the bool type is implementation defined, and better we don't assume its size to be 4 bytes or 1. The problem with current code is that i

Re: [ath9k-devel] [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes

2015-12-14 Thread Viresh Kumar
On 14-09-15, 09:03, Greg KH wrote: > What ever ones you think it is relevant for :) "Relevant" is a relevant term :) So, the patch which defined the type bool as _Bool was added in v2.6.19 :) 6e2182874324 ("[PATCH] Generic boolean") So, I will try at least for v3.10+ as they are used by a lot o

Re: [ath9k-devel] [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes

2015-12-14 Thread Greg KH
On Mon, Sep 14, 2015 at 09:17:08PM +0530, Viresh Kumar wrote: > On 14-09-15, 17:39, Arnd Bergmann wrote: > > On Monday 14 September 2015 09:21:54 Viresh Kumar wrote: > > > diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c > > > index b4c216bab22b..bea8e425a8de 100644 > > > --- a/drivers/ac

Re: [ath9k-devel] [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes

2015-12-14 Thread Viresh Kumar
On 14-09-15, 17:39, Arnd Bergmann wrote: > On Monday 14 September 2015 09:21:54 Viresh Kumar wrote: > > diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c > > index b4c216bab22b..bea8e425a8de 100644 > > --- a/drivers/acpi/ec_sys.c > > +++ b/drivers/acpi/ec_sys.c > > @@ -128,7 +128,7 @@ stat