[ath9k-devel] [PATCH v2 07/46] net/wireless: ath9k: fix DMA API usage

2011-07-10 Thread Michał Mirosław
Also constify buf_addr for ath9k_hw_process_rxdesc_edma() to verify assumptions --- dma_sync_single_for_device() call can be removed. Signed-off-by: Michał Mirosław --- drivers/net/wireless/ath/ath9k/ar9003_mac.c |4 ++-- drivers/net/wireless/ath/ath9k/ar9003_mac.h |2 +- drivers/net/wir

Re: [ath9k-devel] [PATCH v2 07/46] net/wireless: ath9k: fix DMA API usage

2011-07-11 Thread Felix Fietkau
On 2011-07-11 8:52 AM, Michał Mirosław wrote: > Also constify buf_addr for ath9k_hw_process_rxdesc_edma() to verify > assumptions --- dma_sync_single_for_device() call can be removed. > > Signed-off-by: Michał Mirosław > --- > drivers/net/wireless/ath/ath9k/ar9003_mac.c |4 ++-- > drivers/ne

Re: [ath9k-devel] [PATCH v2 07/46] net/wireless: ath9k: fix DMA API usage

2011-07-11 Thread Ben Greear
On 07/11/2011 09:36 PM, Felix Fietkau wrote: > On 2011-07-11 8:52 AM, Michał Mirosław wrote: >> Also constify buf_addr for ath9k_hw_process_rxdesc_edma() to verify >> assumptions --- dma_sync_single_for_device() call can be removed. >> >> Signed-off-by: Michał Mirosław >> --- >> drivers/net/wireles

Re: [ath9k-devel] [PATCH v2 07/46] net/wireless: ath9k: fix DMA API usage

2011-07-12 Thread Michał Mirosław
On Tue, Jul 12, 2011 at 12:36:06PM +0800, Felix Fietkau wrote: > On 2011-07-11 8:52 AM, Michał Mirosław wrote: > >Also constify buf_addr for ath9k_hw_process_rxdesc_edma() to verify > >assumptions --- dma_sync_single_for_device() call can be removed. > > > >Signed-off-by: Michał Mirosław > >--- > >

Re: [ath9k-devel] [PATCH v2 07/46] net/wireless: ath9k: fix DMA API usage

2011-07-12 Thread Felix Fietkau
On 12.07.2011, at 17:55, Michał Mirosław wrote: > On Tue, Jul 12, 2011 at 12:36:06PM +0800, Felix Fietkau wrote: >> On 2011-07-11 8:52 AM, Michał Mirosław wrote: >>> Also constify buf_addr for ath9k_hw_process_rxdesc_edma() to verify >>> assumptions --- dma_sync_single_for_device() call can be re

Re: [ath9k-devel] [PATCH v2 07/46] net/wireless: ath9k: fix DMA API usage

2011-07-12 Thread Michał Mirosław
On Tue, Jul 12, 2011 at 08:54:32PM +0800, Felix Fietkau wrote: > On 12.07.2011, at 17:55, Michał Mirosław wrote: > > > On Tue, Jul 12, 2011 at 12:36:06PM +0800, Felix Fietkau wrote: > >> On 2011-07-11 8:52 AM, Michał Mirosław wrote: > >>> Also constify buf_addr for ath9k_hw_process_rxdesc_edma()

Re: [ath9k-devel] [PATCH v2 07/46] net/wireless: ath9k: fix DMA API usage

2011-07-12 Thread Felix Fietkau
On 12.07.2011, at 21:03, Michał Mirosław wrote: > On Tue, Jul 12, 2011 at 08:54:32PM +0800, Felix Fietkau wrote: >> On 12.07.2011, at 17:55, Michał Mirosław wrote: >> >>> On Tue, Jul 12, 2011 at 12:36:06PM +0800, Felix Fietkau wrote: On 2011-07-11 8:52 AM, Michał Mirosław wrote: > Also

Re: [ath9k-devel] [PATCH v2 07/46] net/wireless: ath9k: fix DMA API usage

2011-07-12 Thread Michał Mirosław
On Tue, Jul 12, 2011 at 10:21:05PM +0800, Felix Fietkau wrote: > On 12.07.2011, at 21:03, Michał Mirosław wrote: > > > On Tue, Jul 12, 2011 at 08:54:32PM +0800, Felix Fietkau wrote: > >> On 12.07.2011, at 17:55, Michał Mirosław wrote: > >> > >>> On Tue, Jul 12, 2011 at 12:36:06PM +0800, Felix F

Re: [ath9k-devel] [PATCH v2 07/46] net/wireless: ath9k: fix DMA API usage

2011-07-12 Thread Felix Fietkau
On 12.07.2011, at 23:58, Michał Mirosław wrote: > On Tue, Jul 12, 2011 at 10:21:05PM +0800, Felix Fietkau wrote: >> On 12.07.2011, at 21:03, Michał Mirosław wrote: >> >>> On Tue, Jul 12, 2011 at 08:54:32PM +0800, Felix Fietkau wrote: On 12.07.2011, at 17:55, Michał Mirosław wrote: >

Re: [ath9k-devel] [PATCH v2 07/46] net/wireless: ath9k: fix DMA API usage

2011-07-12 Thread Michał Mirosław
On Wed, Jul 13, 2011 at 12:04:50AM +0800, Felix Fietkau wrote: > On 12.07.2011, at 23:58, Michał Mirosław wrote: > > > On Tue, Jul 12, 2011 at 10:21:05PM +0800, Felix Fietkau wrote: > >> On 12.07.2011, at 21:03, Michał Mirosław wrote: > >> > >>> On Tue, Jul 12, 2011 at 08:54:32PM +0800, Felix F

Re: [ath9k-devel] [PATCH v2 07/46] net/wireless: ath9k: fix DMA API usage

2011-07-12 Thread Michał Mirosław
On Tue, Jul 12, 2011 at 08:32:04PM +0100, Ralf Baechle wrote: > On Tue, Jul 12, 2011 at 12:36:06PM +0800, Felix Fietkau wrote: > > > >diff --git a/drivers/net/wireless/ath/ath9k/recv.c > > >b/drivers/net/wireless/ath/ath9k/recv.c > > >index 70dc8ec..c5f46d5 100644 > > >--- a/drivers/net/wireless/

Re: [ath9k-devel] [PATCH v2 07/46] net/wireless: ath9k: fix DMA API usage

2011-07-12 Thread Michał Mirosław
On Tue, Jul 12, 2011 at 10:53:16PM +0200, Michał Mirosław wrote: > In the case we're analysing, the ownership is on the device's side > until it stops writing the buffer. Just to be clear, this should say: ... until it marks the buffer as done. Best Regards, Michał Mirosław __