Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug

2010-12-01 Thread Joe Perches
On Tue, 2010-11-30 at 23:56 -0800, Luis R. Rodriguez wrote: On Tue, Nov 30, 2010 at 12:19 PM, Joe Perches j...@perches.com wrote: Poor function naming is just that. It reduces readability and the uses are counter expectation. The name is perfect, we use it to print anything, even

Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug

2010-12-01 Thread Felix Fietkau
On 2010-12-01 3:27 PM, Joe Perches wrote: On Tue, 2010-11-30 at 23:56 -0800, Luis R. Rodriguez wrote: On Tue, Nov 30, 2010 at 12:19 PM, Joe Perches j...@perches.com wrote: Poor function naming is just that. It reduces readability and the uses are counter expectation. The name is perfect, we

Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug

2010-12-01 Thread Joe Perches
On Wed, 2010-12-01 at 15:37 +0100, Felix Fietkau wrote: On 2010-12-01 3:27 PM, Joe Perches wrote: On Tue, 2010-11-30 at 23:56 -0800, Luis R. Rodriguez wrote: On Tue, Nov 30, 2010 at 12:19 PM, Joe Perches j...@perches.com wrote: Poor function naming is just that. It reduces readability

Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug

2010-11-30 Thread Joe Perches
On Tue, 2010-11-30 at 03:43 +0100, Felix Fietkau wrote: On 2010-11-30 2:39 AM, Joe Perches wrote: I gauge my willingness to spend time on subsystems on the maintainers willingness to merge things that improve readability and correctness. I'm not trying to discourage you from spending time

Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug

2010-11-30 Thread Luis R. Rodriguez
On Tue, Nov 30, 2010 at 12:19 PM, Joe Perches j...@perches.com wrote: On Tue, 2010-11-30 at 03:43 +0100, Felix Fietkau wrote: On 2010-11-30 2:39 AM, Joe Perches wrote: I gauge my willingness to spend time on subsystems on the maintainers willingness to merge things that improve readability

Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug

2010-11-30 Thread Luis R. Rodriguez
On Tue, Nov 30, 2010 at 11:56 PM, Luis R. Rodriguez mcg...@gmail.com wrote: On Tue, Nov 30, 2010 at 12:19 PM, Joe Perches j...@perches.com wrote: On Tue, 2010-11-30 at 03:43 +0100, Felix Fietkau wrote: On 2010-11-30 2:39 AM, Joe Perches wrote: I gauge my willingness to spend time on

Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug

2010-11-29 Thread Luis R. Rodriguez
On Mon, Nov 29, 2010 at 2:41 PM, Felix Fietkau n...@openwrt.org wrote: On 2010-11-29 7:07 AM, Peter Stuge wrote: Luis R. Rodriguez wrote: On Sun, Nov 28, 2010 at 3:53 PM, Joe Perches j...@perches.com wrote: Make the function name match the function purpose. ath_debug is a debug only

Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug

2010-11-29 Thread Felix Fietkau
On 2010-11-29 7:07 AM, Peter Stuge wrote: Luis R. Rodriguez wrote: On Sun, Nov 28, 2010 at 3:53 PM, Joe Perches j...@perches.com wrote: Make the function name match the function purpose. ath_debug is a debug only facility. ath_print seems too generic a name for a debug only use. Nack, I

Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug

2010-11-29 Thread Felix Fietkau
On 2010-11-30 2:39 AM, Joe Perches wrote: On Mon, 2010-11-29 at 23:41 +0100, Felix Fietkau wrote: On 2010-11-29 7:07 AM, Peter Stuge wrote: Luis R. Rodriguez wrote: On Sun, Nov 28, 2010 at 3:53 PM, Joe Perches j...@perches.com wrote: Make the function name match the function purpose.

Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug

2010-11-28 Thread Luis R. Rodriguez
On Sun, Nov 28, 2010 at 3:53 PM, Joe Perches j...@perches.com wrote: Make the function name match the function purpose. ath_debug is a debug only facility. ath_print seems too generic a name for a debug only use. Removed an unnecessary trailing space in htc_drv_main.c Signed-off-by: Joe

Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug

2010-11-28 Thread Peter Stuge
Luis R. Rodriguez wrote: On Sun, Nov 28, 2010 at 3:53 PM, Joe Perches j...@perches.com wrote: Make the function name match the function purpose. ath_debug is a debug only facility. ath_print seems too generic a name for a debug only use. Nack, I don't see the point. The point is to