On 2010-11-03 12:35 PM, Björn Smedman wrote:
This is one good looking patch. :) And I agree, looking at the header
qos is good to avoid.
But there is still the risk of queue selection mismatch as I see it...
See comments below.
/Björn
-
/* XXX: Remove me once we don't depend on
2010/11/3 Felix Fietkau n...@openwrt.org:
On 2010-11-03 12:35 PM, Björn Smedman wrote:
This is one good looking patch. :) And I agree, looking at the header
qos is good to avoid.
But there is still the risk of queue selection mismatch as I see it...
See comments below.
/Björn
-
/* XXX:
On 2010-11-03 5:27 PM, Björn Smedman wrote:
It comes down to this: either we look at the header qos when we select
the queue (so the above cannot happen) or we relay on mac80211 to set
the header qos and the skb queue mapping in a certain way. If we
choose the later I vote for a
2010/11/3 Felix Fietkau n...@openwrt.org:
On 2010-11-03 5:27 PM, Björn Smedman wrote:
Ok, regardless. So lets say there is a bug in mac80211 that allows a
mismatch between header qos tid and skb queue mapping to occur
(which in fact there is because this happens all the time with my
frame
On 2010-11-03 6:31 PM, Björn Smedman wrote:
2010/11/3 Felix Fietkau n...@openwrt.org:
On 2010-11-03 5:27 PM, Björn Smedman wrote:
Ok, regardless. So lets say there is a bug in mac80211 that allows a
mismatch between header qos tid and skb queue mapping to occur
(which in fact there is because
Hi all,
The following patch attempts to fix some problems with ath9k tx queue
selection:
1. There was a posible mismatch between the queue selected for QoS packets
(on which locking, queue start/stop and statistics where performed) and
the queue actually used for TX. This is fixed by
On 2010-11-02 6:13 PM, Felix Fietkau wrote:
On 2010-11-02 5:13 PM, Björn Smedman wrote:
Hi all,
The following patch attempts to fix some problems with ath9k tx queue
selection:
1. There was a posible mismatch between the queue selected for QoS packets
(on which locking, queue
2010/11/2 Felix Fietkau n...@openwrt.org:
On 2010-11-02 5:13 PM, Björn Smedman wrote:
Hi all,
The following patch attempts to fix some problems with ath9k tx queue
selection:
1. There was a posible mismatch between the queue selected for QoS packets
(on which locking, queue start/stop and
On 2010-11-02 8:16 PM, Björn Smedman wrote:
2010/11/2 Felix Fietkau n...@openwrt.org:
On 2010-11-02 7:20 PM, Björn Smedman wrote:
2010/11/2 Felix Fietkau n...@openwrt.org:
+ q = ath_get_mac80211_qnum(txq-axq_class, sc);
r = ath_tx_setup_buffer(hw, bf, skb, txctl);
if
