[ath9k-devel] Probable incorrect constant in ath9k

2013-02-21 Thread Blaise Gassend
Hi, While reviewing the ath9k source, I came across the following line which is probably wrong: #define ATH_RSSI_DUMMY_MARKER 0x127 Given that RSSI is stored in a byte, I suspect that this constant was supposed to be 127 or 0x7F, rather than 0x127. I am unfortunately not set up to easily creat

Re: [ath9k-devel] Probable incorrect constant in ath9k

2013-02-21 Thread Blaise Gassend
Actually, given that -128 is returned for antennas that are not present, I wonder if -128 is the correct value here. But this is just guesswork. On Wed, Feb 20, 2013 at 11:19 PM, Blaise Gassend wrote: > Hi, > > While reviewing the ath9k source, I came across the following line which > is probably

Re: [ath9k-devel] Probable incorrect constant in ath9k

2013-02-21 Thread Adrian Chadd
Yes, that's wrong. ;) Adrian On 20 February 2013 23:19, Blaise Gassend wrote: > Hi, > > While reviewing the ath9k source, I came across the following line which is > probably wrong: > #define ATH_RSSI_DUMMY_MARKER 0x127 > > Given that RSSI is stored in a byte, I suspect that this constant