Re: [ath9k-devel] Unrealistic RSSI values being reported

2011-11-23 Thread Daniel Smith
On 11/22/2011 6:05 PM, Adrian Chadd wrote: Ok. Does it trigger on aggregation frames w/ more, or not w/ more, or both? adrian So here is the observed patterns, * When the RSSI override is triggered, rs_isaggr and rs_moreaggr is set(true) * When rs_isaggr and rs_moreaggr is set,

Re: [ath9k-devel] Unrealistic RSSI values being reported

2011-11-23 Thread Daniel Smith
On 11/23/2011 1:06 AM, Mohammed Shafi wrote: Hi Daniel, sorry was busy with some other urgent work. a value upto 127 seems to be valid for Atheros chipsets, bad -128 http://en.wikipedia.org/wiki/Received_signal_strength_indication :) further the negative value should be caught by the check

Re: [ath9k-devel] Unrealistic RSSI values being reported

2011-11-23 Thread Adrian Chadd
Ok, cool. So I was right. :) Yes, the nice solution would be to expose those aggregate frame boundary delimiters to userland and then only marking those frames with valid RSSI .. well, somehow. The nicer solution would be to buffer those frames in an aggregate and then assign them all a common

Re: [ath9k-devel] Unrealistic RSSI values being reported

2011-11-23 Thread Felix Fietkau
On 2011-11-23 9:14 PM, Adrian Chadd wrote: Ok, cool. So I was right. :) Yes, the nice solution would be to expose those aggregate frame boundary delimiters to userland and then only marking those frames with valid RSSI .. well, somehow. The nicer solution would be to buffer those frames

Re: [ath9k-devel] Unrealistic RSSI values being reported

2011-11-23 Thread Daniel Smith
On Wed, Nov 23, 2011 at 9:24 AM, Felix Fietkau n...@openwrt.org wrote: On 2011-11-23 9:14 PM, Adrian Chadd wrote: Ok, cool. So I was right. :) Yes, the nice solution would be to expose those aggregate frame boundary delimiters to userland and then only marking those frames with valid RSSI ..

Re: [ath9k-devel] Unrealistic RSSI values being reported

2011-11-22 Thread Daniel Smith
On 11/21/2011 3:09 PM, Adrian Chadd wrote: Hi, See if those valid or invalid RSSI's coincide with aggregate frames. ath9k_process_rssi() has a bit of logic which only considers frames that aren't part of continuing aggregate: if (rx_stats-rs_rssi != ATH9K_RSSI_BAD

Re: [ath9k-devel] Unrealistic RSSI values being reported

2011-11-22 Thread Adrian Chadd
On 23 November 2011 01:42, Daniel Smith viscous.liq...@gmail.com wrote: Excellent call! So in mac.c:ath9k_hw_rxprocdesc() I put a three printk (in the following order) for when I detect the out-of-bounds rssi, an aggregate, and if there is more to the aggregate. As you can see below when my

Re: [ath9k-devel] Unrealistic RSSI values being reported

2011-11-22 Thread Mohammed Shafi
On Fri, Nov 4, 2011 at 4:57 PM, Daniel Smith viscous.liq...@gmail.com wrote: On 11/3/2011 7:10 PM, Mohammed Shafi wrote: Hi Daniel, On Fri, Nov 4, 2011 at 12:58 AM, Daniel Smithviscous.liq...@gmail.com   wrote: I recently upgraded to compat-wireless-3.1-rc8 from compat-wireless-2.6.39-1-sn

Re: [ath9k-devel] Unrealistic RSSI values being reported

2011-11-21 Thread Daniel Smith
Just wanted to follow-up to let everyone know the status and for anyone people that may stumble on this from a search. Also, I have a pcap file from one of the captures done with 2.6.39-1-sn if anyone wants to inspect the frames themselves, just email me directly if would like it. Some

Re: [ath9k-devel] Unrealistic RSSI values being reported

2011-11-04 Thread Daniel Smith
On 11/3/2011 7:10 PM, Mohammed Shafi wrote: Hi Daniel, On Fri, Nov 4, 2011 at 12:58 AM, Daniel Smithviscous.liq...@gmail.com wrote: I recently upgraded to compat-wireless-3.1-rc8 from compat-wireless-2.6.39-1-sn and have discovered an interesting behavior. When in monitor mode I use the

Re: [ath9k-devel] Unrealistic RSSI values being reported

2011-11-04 Thread Mohammed Shafi
On Fri, Nov 4, 2011 at 4:57 PM, Daniel Smith viscous.liq...@gmail.com wrote: On 11/3/2011 7:10 PM, Mohammed Shafi wrote: Hi Daniel, On Fri, Nov 4, 2011 at 12:58 AM, Daniel Smithviscous.liq...@gmail.com   wrote: I recently upgraded to compat-wireless-3.1-rc8 from compat-wireless-2.6.39-1-sn

Re: [ath9k-devel] Unrealistic RSSI values being reported

2011-11-04 Thread Daniel Smith
On 11/3/2011 7:10 PM, Mohammed Shafi wrote: Hi Daniel, i tried with the AR9382 card in 3.1.0-wl with the attached debug patch, can you please give a sample log with the patch applied and putting the interface in monitor mode. did you print/check rs_rssi somewhere else? did you also try with

[ath9k-devel] Unrealistic RSSI values being reported

2011-11-03 Thread Daniel Smith
I recently upgraded to compat-wireless-3.1-rc8 from compat-wireless-2.6.39-1-sn and have discovered an interesting behavior. When in monitor mode I use the signal strength field reported in radiotap and with 3.1 I am now getting a range of values. The more interesting ones are all the frames

Re: [ath9k-devel] Unrealistic RSSI values being reported

2011-11-03 Thread Mohammed Shafi
Hi Daniel, On Fri, Nov 4, 2011 at 12:58 AM, Daniel Smith viscous.liq...@gmail.com wrote: I recently upgraded to compat-wireless-3.1-rc8 from compat-wireless-2.6.39-1-sn and have discovered an interesting behavior. When in monitor mode I use the signal strength field reported in radiotap and