Re: tex.el compiler warnings

2020-08-22 Thread Tassilo Horn
Arash Esbati writes: >> (devar TeX-file nil) >> (defun TeX-foobar () >> (let ((TeX-file something)) >> (TeX-quux) >> (TeX-baz))) >> >> and make TeX-quux and TeX-baz (and everything called below) use >> `TeX-file' instead of `file'. The byte-compiler warnings hint us >>

Re: tex.el compiler warnings

2020-08-20 Thread Arash Esbati
Hi Keita and Tassilo, Tassilo Horn writes: > Ikumi Keita writes: > >>> Tassilo Horn writes: >>> So please keep all warnings about references to free, unprefixed >>> variables. >> >> Arash, you recently committed some changes using `with-no-warnings' to >> suppress the warnings about free,

Re: tex.el compiler warnings

2020-08-20 Thread Arash Esbati
Tassilo Horn writes: > Arash Esbati writes: > >> That would be fine with me, I can commit the defvar's only and omit >> the `with-no-warnings' if you would cater for the rest :-) > > Yes, please. We only want to silence warnings which don't indicate real > issues. All "declared in another

Re: tex.el compiler warnings

2020-08-20 Thread Tassilo Horn
Ikumi Keita writes: Hi Chaps, >> Tassilo Horn writes: >> So please keep all warnings about references to free, unprefixed >> variables. > > Arash, you recently committed some changes using `with-no-warnings' to > suppress the warnings about free, unprefixed variables, didn't you? Looking

Re: tex.el compiler warnings

2020-08-20 Thread Ikumi Keita
Hi Arash and Tassilo, > Tassilo Horn writes: > So please keep all warnings about references to free, unprefixed > variables. Arash, you recently committed some changes using `with-no-warnings' to suppress the warnings about free, unprefixed variables, didn't you? It seems that it should be

Re: tex.el compiler warnings

2020-08-19 Thread Tassilo Horn
Arash Esbati writes: Hi Arash, >> Why is that needed? As far as I see, that function only complains >> about variables defined by AUCTeX itself which you can also defvar, >> no? > > Yes, the complaints about free variables `TeX-*' vanish by defvar'ing > them. That's good. >> In

Re: tex.el compiler warnings

2020-08-19 Thread Arash Esbati
Hi Tassilo, Tassilo Horn writes: > Arash Esbati writes: > > the defvars look good to me. Thanks for checking. > Why is that needed? As far as I see, that function only complains about > variables defined by AUCTeX itself which you can also defvar, no? Yes, the complaints about free

Re: tex.el compiler warnings

2020-08-19 Thread Tassilo Horn
Arash Esbati writes: Hi Arash, the defvars look good to me. > @@ -1188,15 +1233,16 @@ entry in `TeX-view-program-list-builtin'." > (error "PDF Tools only work with PDF output")) >(add-hook 'pdf-sync-backward-redirect-functions > #'TeX-source-correlate-handle-TeX-region) >

tex.el compiler warnings

2020-08-18 Thread Arash Esbati
Hi all, I'd like to install the following patch which silences almost all compiler warnings coming from tex.el. Main features are: 1) Require texmathp 2) defvar all variables 3) use `with-no-warnings' for 2 function `TeX-pdf-tools-sync-view' and `TeX-evince-sync-view-1'. Any comments?