Update of /cvsroot/audacity/audacity-src/src/import In directory sc8-pr-cvs11.sourceforge.net:/tmp/cvs-serv21449
Modified Files: ImportPlugin.h Log Message: Destructors of classes with virtual member functions should always be virtual, in case a derived class does something in it's over-ridden virtual member functions that requires cleaning up after in the constructor. So technically a design error rather than a coding one, but GCC moans about it so I'm changing it, even if we don't currently have any importers that need to over-ride the destructor. Index: ImportPlugin.h =================================================================== RCS file: /cvsroot/audacity/audacity-src/src/import/ImportPlugin.h,v retrieving revision 1.13 retrieving revision 1.14 diff -u -d -r1.13 -r1.14 --- ImportPlugin.h 4 Jun 2008 19:12:17 -0000 1.13 +++ ImportPlugin.h 11 Aug 2008 19:11:48 -0000 1.14 @@ -124,7 +124,7 @@ { } - ~ImportFileHandle() + virtual ~ImportFileHandle() { if (mProgress != NULL) { ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Audacity-cvs mailing list Audacity-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/audacity-cvs