Miklos Szeredi:
> You misunderstand. What I think is:
>
> To be able to correctly perform permission checks based on cached
> inode attributes, those attributes may need to be refreshed before
> making the permission checks.
You seem to be replacing the problem.
The problem is more generic, not only permission check.
What you wrote is,
- in order to refer any inode attributes except file type in i_mode, the
caller have to update the inode.
- the caller must not rely on the inode attributes in a positive dentry
which is returned by path_lookup().
isn't it?
The two cases you mentioned (sticky bit and may_open()) is a part of
the list I wrote as example where VFS accesses inode attributes.
And I don't have a paticular opinion about judging those are bugs.
I already decided to add a special handling for fuse into aufs.
Because you wrote,
- you are the one who expected to fix VFS about this issue.
- you have another thing more important.
> Let's take a concrete example:
:::
> Should that rmdir succeed? Surely not, the sticky check would fail.
> But if the stale attributes are used, than it _will_ succeed.
I thought we have already agreed about the staleness of cached nfs
inode including REVAL_DOT.
Junjiro Okajima
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
