Re: Fix for AUFS hintent_put

2008-02-14 Thread sfjro
> I guess the dentry has been lookup-ed before and the operation returned > negative or failed, and the consistency broke. > I will include your patch in next Monday release. This new patch may be better (allocate/free efeciently). Would you test it and let me know the result? Junjiro Okajima

Re: Fix for AUFS hintent_put

2008-02-14 Thread sfjro
Jan-Marek Glogowski: > So it's working reliable, but it took quite some time to get it running > as an NFSroot. Why did it take time? Were there anything strange in aufs? On my test environment (debian etch), exportfs(8) for nfsv4 is unreliable. When I executed exportfs(8) repeatedly with -i, -u

Re: Fix for AUFS hintent_put

2008-02-14 Thread Jan-Marek Glogowski
> Jan-Marek Glogowski: > > This is a 2.6.24.2 debian based kernel. I'm using aufs on an NSFv4 ro fs > > and a tmpfs as a NFSroot. > > > > Without this patch I get this BUG, and the patch fixes it. > > Thank you. > I guess the dentry has been lookup-ed before and the operation returned > negative or

Re: Fix for AUFS hintent_put

2008-02-14 Thread sfjro
Jan-Marek Glogowski: > This is a 2.6.24.2 debian based kernel. I'm using aufs on an NSFv4 ro fs > and a tmpfs as a NFSroot. > > Without this patch I get this BUG, and the patch fixes it. Thank you. I guess the dentry has been lookup-ed before and the operation returned negative or failed, and th

Re: Fix for AUFS hintent_put

2008-02-14 Thread Jan-Marek Glogowski
On Thu, 14 Feb 2008 [EMAIL PROTECTED] wrote: > Will you show me the actual case (your operation or stack trace)? > I don't think this fix is meaningful. This is a 2.6.24.2 debian based kernel. I'm using aufs on an NSFv4 ro fs and a tmpfs as a NFSroot. Without this patch I get this BUG, and the p

Re: Fix for AUFS hintent_put

2008-02-14 Thread sfjro
Jan-Marek Glogowski: > The attached patch is a fix for a kernel BUG in AUFS 20080211. The > hd_intent_list is kfree'd, but the pointer is not reset, which will cause > the BUG, next time the hd is checked for intents. > > I'm using a variant of the ubuntu patch, so the actual problem might be > s

Fix for AUFS hintent_put

2008-02-14 Thread Jan-Marek Glogowski
Hi The attached patch is a fix for a kernel BUG in AUFS 20080211. The hd_intent_list is kfree'd, but the pointer is not reset, which will cause the BUG, next time the hd is checked for intents. I'm using a variant of the ubuntu patch, so the actual problem might be somewhere else. Regards Jan-M