Re: [aur-dev] [PATCH] Add comment and submitted to notification emails for comments

2008-10-08 Thread Loui
On Wed, Oct 08, 2008 at 04:42:47AM +0800, Callan Barrett wrote: > Signed-off-by: Callan Barrett <[EMAIL PROTECTED]> > --- > web/html/pkgedit.php |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/web/html/pkgedit.php b/web/html/pkgedit.php > index 610113a..974f14b 1006

Re: [aur-dev] [PATCH] Add comment and submitted to notification emails for comments

2008-10-08 Thread Callan Barrett
> I think it might be worth changing the whole wording of the notice and > maybe put the commenter's nick in the email as well. Something like: > > louipc has made a comment on tomatoes: > This game rocks so hard yo. > > You can also view the comment here: > http:///aur.archlinux.org/packages.php?I

Re: [aur-dev] [PATCH] Sanitize input of package functions in pkg_funcs.inc

2008-10-08 Thread Loui
You've got a lot of code here that's essentially repeated. I would look at doing this another way, such as putting it in a function maybe and having a common error message. "Invalid PKGBUILD ID specified." or something.

Re: [aur-dev] [PATCH] Add comment and submitted to notification emails for comments

2008-10-08 Thread Loui
On Thu, Oct 09, 2008 at 10:30:41AM +0800, Callan Barrett wrote: > > I think it might be worth changing the whole wording of the notice and > > maybe put the commenter's nick in the email as well. Something like: > > > > louipc has made a comment on tomatoes: > > This game rocks so hard yo. > > > >