Re: [aur-dev] [PATCH 2/3] SQL: treat all UID/ID values as numbers, not strings

2011-04-27 Thread Lukas Fleischer
On Tue, Apr 26, 2011 at 10:44:33AM -0500, Dan McGee wrote: > On Tue, Apr 26, 2011 at 10:04 AM, Lukas Fleischer > wrote: > > On Mon, Apr 25, 2011 at 11:23:01PM -0500, Dan McGee wrote: > >> Ensure we are not quoting these values in any of our SQL queries. > >> > >> Thanks-to: elij > >> Signed-off-b

Re: [aur-dev] [PATCH 1/1] create variable before referencing it with .=

2011-04-27 Thread Lukas Fleischer
On Mon, Apr 25, 2011 at 11:02:38PM -0700, elij wrote: > fixes php notice level error: > Undefined variable: whovoted in ../tu.php > --- > web/html/tu.php |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > Thanks, pushed that as well.

Re: [aur-dev] [PATCH 1/1] add SQL_DEBUG variable and database logging

2011-04-27 Thread Lukas Fleischer
On Tue, Apr 26, 2011 at 11:52:11AM -0700, elij wrote: > add a hook to db_query to log all sql queries when SQL_DEBUG is set > Additionally, provide better logging for sql error situations (provide > backtrace as well as error message). > --- > web/lib/aur.inc | 12 > web/li

Re: [aur-dev] [PATCH 1/1] add SQL_DEBUG variable and database logging

2011-04-27 Thread elij
On Wed, Apr 27, 2011 at 9:34 AM, Lukas Fleischer wrote: > On Tue, Apr 26, 2011 at 11:52:11AM -0700, elij wrote: >> add a hook to db_query to log all sql queries when SQL_DEBUG is set >> Additionally, provide better logging for sql error situations (provide >> backtrace as well as error message). >

Re: [aur-dev] [PATCH 1/1] add SQL_DEBUG variable and database logging

2011-04-27 Thread elij
On Wed, Apr 27, 2011 at 1:57 PM, elij wrote: > On Wed, Apr 27, 2011 at 9:34 AM, Lukas Fleischer > wrote: >> On Tue, Apr 26, 2011 at 11:52:11AM -0700, elij wrote: >>> add a hook to db_query to log all sql queries when SQL_DEBUG is set >>> Additionally, provide better logging for sql error situatio