Re: [aur-dev] [PATCH 1/4] remove submitter from package data

2011-05-11 Thread Lukas Fleischer
On Tue, May 10, 2011 at 09:01:27PM -0700, elij wrote: > --- > web/html/pkgsubmit.php |3 +-- > web/lib/pkgfuncs.inc | 10 +- > web/template/pkg_details.php | 11 --- > 3 files changed, 2 insertions(+), 22 deletions(-) > The submitter field proved to be usefu

Re: [aur-dev] [PATCH 2/4] test return value from db_query before assuming it is valid

2011-05-11 Thread Lukas Fleischer
On Tue, May 10, 2011 at 09:01:28PM -0700, elij wrote: > make the sql query form consistent in usage by cleaning up > instances where db_query's result was not inspected before > attempting to fetch row data from the handle > --- > web/html/addvote.php | 16 +- > web/html/tu.php

Re: [aur-dev] [PATCH 3/4] fix case where user does not exist

2011-05-11 Thread Lukas Fleischer
On Tue, May 10, 2011 at 09:01:29PM -0700, elij wrote: > the query was being performed when $id was not set, resulting in an > invalid sql query being performed. > --- > web/lib/acctfuncs.inc |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/web/lib/acctfuncs.inc b/we

Re: [aur-dev] [PATCH 4/4] make return value consistent for this function

2011-05-11 Thread Lukas Fleischer
On Tue, May 10, 2011 at 09:01:30PM -0700, elij wrote: > --- > web/lib/aur.inc |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/web/lib/aur.inc b/web/lib/aur.inc > index fb267af..f8fa715 100644 > --- a/web/lib/aur.inc > +++ b/web/lib/aur.inc > @@ -196,7 +196,7 @@ func

Re: [aur-dev] [PATCH 1/4] remove submitter from package data

2011-05-11 Thread elij
On Wed, May 11, 2011 at 7:11 AM, Lukas Fleischer wrote: > On Tue, May 10, 2011 at 09:01:27PM -0700, elij wrote: >> --- >>  web/html/pkgsubmit.php       |    3 +-- >>  web/lib/pkgfuncs.inc         |   10 +- >>  web/template/pkg_details.php |   11 --- >>  3 files changed, 2 insertion

Re: [aur-dev] [PATCH 1/4] remove submitter from package data

2011-05-11 Thread Dan McGee
On Wed, May 11, 2011 at 1:48 PM, elij wrote: > On Wed, May 11, 2011 at 7:11 AM, Lukas Fleischer > wrote: >> On Tue, May 10, 2011 at 09:01:27PM -0700, elij wrote: >>> --- >>>  web/html/pkgsubmit.php       |    3 +-- >>>  web/lib/pkgfuncs.inc         |   10 +- >>>  web/template/pkg_details.

Re: [aur-dev] [PATCH 3/4] fix case where user does not exist

2011-05-11 Thread elij
On Wed, May 11, 2011 at 7:22 AM, Lukas Fleischer wrote: > On Tue, May 10, 2011 at 09:01:29PM -0700, elij wrote: >> the query was being performed when $id was not set, resulting in an >> invalid sql query being performed. >> --- >>  web/lib/acctfuncs.inc |    3 +++ >>  1 files changed, 3 insertions

Re: [aur-dev] [PATCH 1/4] remove submitter from package data

2011-05-11 Thread elij
On Wed, May 11, 2011 at 11:51 AM, Dan McGee wrote: > On Wed, May 11, 2011 at 1:48 PM, elij wrote: >> On Wed, May 11, 2011 at 7:11 AM, Lukas Fleischer >> wrote: >>> On Tue, May 10, 2011 at 09:01:27PM -0700, elij wrote: ---  web/html/pkgsubmit.php       |    3 +--  web/lib/pkgfuncs.

[aur-dev] [PATCH 2/4] test return value from db_query before assuming it is valid

2011-05-11 Thread elij
make the sql query form consistent in usage by cleaning up instances where db_query's result was not inspected before attempting to fetch row data from the handle --- web/html/addvote.php | 16 +- web/html/tu.php | 17 +-- web/lib/acctfuncs.inc |

Re: [aur-dev] [PATCH 2/4] test return value from db_query before assuming it is valid

2011-05-11 Thread elij
hmm. looks like there were still a couple lines of formatting junk in this patch.. hilariously the ones I missed are converting spaces to tabs to be more consistent. &_& the count is low though. Skimming the patch file it looks like only 3 or 4 lines. I got the big ones pruned out of the patch thou

Re: [aur-dev] [PATCH 2/4] test return value from db_query before assuming it is valid

2011-05-11 Thread Lukas Fleischer
On Wed, May 11, 2011 at 04:17:12PM -0700, elij wrote: > make the sql query form consistent in usage by cleaning up > instances where db_query's result was not inspected before > attempting to fetch row data from the handle > --- > web/html/addvote.php | 16 +- > web/html/tu.php

Re: [aur-dev] [PATCH 3/4] fix case where user does not exist

2011-05-11 Thread Lukas Fleischer
On Wed, May 11, 2011 at 11:54:34AM -0700, elij wrote: > On Wed, May 11, 2011 at 7:22 AM, Lukas Fleischer > wrote: > > On Tue, May 10, 2011 at 09:01:29PM -0700, elij wrote: > >> the query was being performed when $id was not set, resulting in an > >> invalid sql query being performed. > >> --- > >>

Re: [aur-dev] [PATCH 1/4] remove submitter from package data

2011-05-11 Thread Lukas Fleischer
On Wed, May 11, 2011 at 12:00:50PM -0700, elij wrote: > On Wed, May 11, 2011 at 11:51 AM, Dan McGee wrote: > > On Wed, May 11, 2011 at 1:48 PM, elij wrote: > >> On Wed, May 11, 2011 at 7:11 AM, Lukas Fleischer > >> wrote: > >>> On Tue, May 10, 2011 at 09:01:27PM -0700, elij wrote: > --- > >

Re: [aur-dev] [PATCH 2/4] test return value from db_query before assuming it is valid

2011-05-11 Thread elij
On Wed, May 11, 2011 at 5:09 PM, Lukas Fleischer wrote: > On Wed, May 11, 2011 at 04:17:12PM -0700, elij wrote: >> make the sql query form consistent in usage by cleaning up >> instances where db_query's result was not inspected before >> attempting to fetch row data from the handle >> --- >>  web