[aur-dev] Internal server error while searching for "es"

2011-06-22 Thread Tuxce
Hi, as yaourt maintainer, I received a bug ticket about yaourt giving an error while searching for "es" on AUR. It seems that searching for "es" with rpc (and maybe only "es") returns an internal server error. http://aur.archlinux.org/rpc.php?type=search&arg=es But I cannot reproduce it on a local

Re: [aur-dev] Output buffering and header() usage

2011-06-22 Thread Lukas Fleischer
On Tue, Jun 21, 2011 at 11:19:29AM -0500, Dan McGee wrote: > On Tue, Jun 21, 2011 at 11:11 AM, Lukas Fleischer > wrote: > > Some possible solutions/workarounds that came into my mind: > > > > * Use javascript redirects instead. > > > > * Just buffer output everywhere (ob_start(), ob_flush()). > >

Re: [aur-dev] [PATCH 1/1] Make cache type selectable based on config value

2011-06-22 Thread Lukas Fleischer
On Tue, Jun 21, 2011 at 11:06:55PM +0200, Lukas Fleischer wrote: > I'll have a look at your outstanding patches as soon as possible. Rebased and pushed them. Thanks.

Re: [aur-dev] Internal server error while searching for "es"

2011-06-22 Thread Dan McGee
On Wed, Jun 22, 2011 at 5:37 AM, Tuxce wrote: > Hi, as yaourt maintainer, I received a bug ticket about yaourt giving > an error while searching for "es" on AUR. It seems that searching for > "es" with rpc (and maybe only "es") returns an internal server error. > http://aur.archlinux.org/rpc.php?t

[aur-dev] [PATCH 1/2] Fix performance issues with new PackageDepends lookups

2011-06-22 Thread Dan McGee
We do a lookup by DepName in the package details view, but I made the silly mistake of forgetting this index addition in the upgrade steps. Signed-off-by: Dan McGee --- Not sure if this fell through the cracks way back in April... UPGRADING |6 -- support/schema/aur

[aur-dev] [PATCH 2/2] Use sane ORDER BY clauses in package list queries

2011-06-22 Thread Dan McGee
We were doing some silly things here with an "ORDER BY Name, CategoryID" clause, due to the fact that Name is unique, and thus any additional ordering after Name will have no effect. Of course, the dumb as a box of rocks MySQL query optimizer doesn't realize this, leading to full table scans every

[aur-dev] [PATCH 1/5] README: fix pacman call

2011-06-22 Thread Florian Pritz
Signed-off-by: Florian Pritz --- web/README |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/web/README b/web/README index b8d1b72..0c081f2 100644 --- a/web/README +++ b/web/README @@ -1,7 +1,7 @@ Setup on Arch Linux: 1) Install Apache, MySQL, PHP,

[aur-dev] [PATCH 2/5] use valid_email() from codeigniter's email helper

2011-06-22 Thread Florian Pritz
Signed-off-by: Florian Pritz --- web/lib/aur.inc.php |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/web/lib/aur.inc.php b/web/lib/aur.inc.php index 4c2cc55..3250133 100644 --- a/web/lib/aur.inc.php +++ b/web/lib/aur.inc.php @@ -78,7 +78,7 @@ function check_sid() { # ve

[aur-dev] misc patches

2011-06-22 Thread Florian Pritz
I've tested some basic AUR functionality and it still worked fine, so please merge. Cgit (with pull URL) is available at http://git.server-speed.net/users/flo/aur/?h=working

[aur-dev] [PATCH 3/5] remove unneeded make_seed()

2011-06-22 Thread Florian Pritz
http://us.php.net/mt_srand > Note: As of PHP 4.2.0, there is no need to seed the random number > generator with srand() or mt_srand() as this is now done > automatically. Signed-off-by: Florian Pritz --- web/lib/aur.inc.php | 12 +--- 1 files changed, 1 insertions(+), 11 deletions(-)

[aur-dev] [PATCH 4/5] fix incompatibility with php short open tags

2011-06-22 Thread Florian Pritz
Signed-off-by: Florian Pritz --- web/README |4 web/template/header.php |2 +- 2 files changed, 1 insertions(+), 5 deletions(-) diff --git a/web/README b/web/README index 0c081f2..37a224e 100644 --- a/web/README +++ b/web/README @@ -62,10 +62,6 @@ Setup on Arch Linux:

[aur-dev] [PATCH 5/5] check if new SessionID already exists

2011-06-22 Thread Florian Pritz
Signed-off-by: Florian Pritz --- web/lib/aur.inc.php | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/web/lib/aur.inc.php b/web/lib/aur.inc.php index 382578c..3d1688a 100644 --- a/web/lib/aur.inc.php +++ b/web/lib/aur.inc.php @@ -89,8 +89,16 @@ function new_sid

Re: [aur-dev] [PATCH 2/5] use valid_email() from codeigniter's email helper

2011-06-22 Thread Cédric Girard
On Wed, Jun 22, 2011 at 9:36 PM, Florian Pritz wrote: > + return ( ! > preg_match("/^([a-z0-9\+_\-]+)(\.[a-z0-9\+_\-]+)*@([a-z0-9\-]+\.)+[a-z]{2,6}$/ix", > $addy)) ? FALSE : TRUE; > Some legitimate email address will not be matched by your regexp. Better use built-in PHP functions: retu