On Thu, Feb 6, 2014 at 1:42 PM, Lukas Fleischer
archli...@cryptocrack.de wrote:
There aren't any other subdirectories in support/. Reduce the nesting
depth by moving schema/ to the top-level source directory.
Signed-off-by: Lukas Fleischer archli...@cryptocrack.de
---
INSTALL
On Tue, Feb 4, 2014 at 12:54 PM, Lukas Fleischer
archli...@cryptocrack.de wrote:
This allows for removing users without also removing the corresponding
comments. Instead, all comments from deleted users will be displayed as
Anonymous comment.
Signed-off-by: Lukas Fleischer
This improves the ability to edit a user's account directly through
UI features rather than manually appending 'edit' to the URL or
searching for the account and selecting edit.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/css/aur.css | 5 +
web/template
On Mon, Jan 20, 2014 at 9:39 AM, Lukas Fleischer
archli...@cryptocrack.de wrote:
On Mon, 20 Jan 2014 at 02:29:33, canyonknight wrote:
This improves the ability to edit a user's account directly through
UI features rather than manually appending 'edit' to the URL or
searching for the account
-by: canyonknight canyonkni...@gmail.com
---
web/html/index.php | 2 +-
web/html/voters.php | 4 ++--
web/lib/pkgfuncs.inc.php | 11 ++-
web/template/pkg_details.php | 2 +-
4 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/web/html/index.php b/web/html
No need to store package ID and call pkgname_from_id() twice when
the end goal is the package name.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/voters.php | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/web/html/voters.php b/web/html/voters.php
index
This improves the ability to edit a user's account directly through
UI features rather than manually appending 'edit' to the URL or
searching for the account and selecting edit.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/account_details.php | 4
1 file changed, 4
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/acctfuncs.inc.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php
index fe748a2..52eb551 100644
--- a/web/lib/acctfuncs.inc.php
+++ b/web/lib
On Mon, Nov 25, 2013 at 7:14 AM, Daniel Albers dan...@lbe.rs wrote:
Dependencies can have a description appended, separated by a colon.
Don't treat this colon as part of the dependency name.
I know that optdepends often have the dependency name followed by a
colon and a description of the
On Fri, Oct 25, 2013 at 8:06 AM, 郑文辉(Techlive Zheng)
techlivezh...@gmail.com wrote:
Currently, if a package gets merged into another package, the URL link
to the merged package will say 404, this should not happen, instead, a
redirection should be made to the package that was merged into.
If
On Mon, Aug 5, 2013 at 4:10 AM, Lukas Fleischer
archli...@cryptocrack.de wrote:
This adds a field to the users table and corresponding fields to the
account edit and display forms that allow for setting an (in-)activity
status.
This might turn out to be useful if a user is on vacation and can
On Tue, May 7, 2013 at 10:19 PM, 郑文辉(Techlive Zheng)
techlivezh...@gmail.com wrote:
On more thing, there should be a in-reply-to field in each message's
header, these fieldes should be the same for the some message thread
to make gmail like system properly thread them.
Can you add a feature
The search_accounts_form() wrapper function doesn't have any
arguments and only makes it unclear what is happening within
account.php
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/account.php | 2 +-
web/lib/acctfuncs.inc.php | 10 --
2 files changed, 1 insertion
The last packager is not currently saved despite there being many
instances of the last packager being different than either the
submitter or the maintainer.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
UPGRADING | 10 ++
support/schema/aur-schema.sql | 4
The IP address is only visible to Trusted Users and Developers.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/account_details.php | 8
1 file changed, 8 insertions(+)
diff --git a/web/template/account_details.php b/web/template/account_details.php
index fdebfb3
by Trusted Users and Developers.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
UPGRADING | 11 +++
support/schema/aur-schema.sql | 9 +
2 files changed, 20 insertions(+)
diff --git a/UPGRADING b/UPGRADING
index 9c05467..7d13c43 100644
--- a/UPGRADING
Adds a new is_ipbanned() function to determine whether the user
attempting to login or register for an account has their IP
address listed in the Bans table.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/acctfuncs.inc.php | 35 ++-
1 file changed
On Mon, Mar 18, 2013 at 5:10 PM, Dave Reisner d...@falconindy.com wrote:
On Mon, Mar 18, 2013 at 08:18:19PM +0100, Lukas Fleischer wrote:
Changes since 2.0.1:
* Typeahead suggest for packages.
* Fix account editing and hijacking vulnerability.
* Fix account privilege escalation
On Sat, Mar 2, 2013 at 4:33 AM, Connor Behan connor.be...@gmail.com wrote:
When I recently looked through the AUR source, it seemed to me that when
a package is deleted, a record is only removed from the `Packages` table
and that there is data for the corresponding package still in
an account kills the cookie?
Maybe I missed something...
I want to get back to the fact, that the user could flag packages after he
was suspended. In January, canyonknight committed a patch for this
specific problem[1]:
A suspended user can stay in active sessions. Introduce new function
On Wed, Feb 27, 2013 at 5:26 PM, Alexander Rødseth rods...@gmail.com wrote:
Hi,
2013/2/27 Angel Velásquez an...@archlinux.org:
For solving the problem right now -quick and dirty-, we just have to
add a validation (tsk tsk anyone who wants to sum contributions can
code this silly patch), if
On Thu, Feb 14, 2013 at 7:02 PM, Lukas Fleischer
archli...@cryptocrack.de wrote:
Drop the (very bad) PHP parser and allow for passing all necessary
configuration via command line parameters.
Also, add a convenience wrapper written in PHP that parses the
configuration file and subsequently
On Sun, Feb 3, 2013 at 11:26 AM, canyonknight canyonkni...@gmail.com wrote:
Uses the Singleton pattern to ensure all queries use the same
database connection that is released upon script completion.
All database connections should now be called with DB::connect() and
not db_connect
they will be available on
my working branch.
canyonknight (5):
Add database wrapper class and new connection method
Remove unnecessary database connection parameter from all functions
Remove documentation references to database parameter
Remove checks before calling connection method
Remove
All functions now have a database connection method that will use
the same database connection. This imitates the functionality of
passing a database connection as an argument and makes it redundant.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/home.php | 6 +--
web
---
web/lib/acctfuncs.inc.php | 24
web/lib/aur.inc.php | 18 --
web/lib/pkgfuncs.inc.php | 24
web/lib/stats.inc.php | 5 -
4 files changed, 71 deletions(-)
diff --git a/web/lib/acctfuncs.inc.php
Large amount of boilerplate code that checks if a database
connection exists is useless now that the new connection method
automatically does the same check.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/logout.php| 4 +-
web/lib/acctfuncs.inc.php | 97
Since all database related functions will establish a connection
when needed, there is no need to pre-emptively try and establish
a database connection.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/account.php | 1 -
web/html/home.php | 2 --
web/html/logout.php| 1
The function is only determining whether a username is valid,
so it makes more sense to simply return a boolean value.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/acctfuncs.inc.php | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/web/lib
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/account.php | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/web/html/account.php b/web/html/account.php
index cccdd76..2133734 100644
--- a/web/html/account.php
+++ b/web/html/account.php
@@ -48,11 +48,8
A suspended user can stay in active sessions. Introduce new function
delete_user_sessions to remove all open sessions for a specific user.
Allows suspensions to take effect immediately.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/acctfuncs.inc.php | 19 +++
1
An error message is printed when the number of affected rows is
0 for an edited account. A count of 0 doesn't imply an error,
only that no changes were made in the database.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/acctfuncs.inc.php | 2 +-
1 file changed, 1 insertion(+), 1
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/pkg_details.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php
index b5d8a9f..0973448 100644
--- a/web/template/pkg_details.php
+++ b/web
Occurs in the rare situation where a logged out user tries to POST
a CSRF token.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/aur.inc.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web/lib/aur.inc.php b/web/lib/aur.inc.php
index 387d81d..e02c835 100644
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/stats/user_table.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web/template/stats/user_table.php
b/web/template/stats/user_table.php
index ba6751f..284d5b9 100644
--- a/web/template/stats/user_table.php
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/stats.inc.php | 3 ---
1 file changed, 3 deletions(-)
diff --git a/web/lib/stats.inc.php b/web/lib/stats.inc.php
index 60973e9..cfae794 100644
--- a/web/lib/stats.inc.php
+++ b/web/lib/stats.inc.php
@@ -43,9 +43,6 @@ function
On Sat, Jan 5, 2013 at 11:32 AM, Marcel Korpel marcel.li...@gmail.com wrote:
Implements FS#33294
I like the idea of this patch. It would make search engine results for
AUR packages far more sane.
---
web/html/packages.php| 7 +--
web/lib/aur.inc.php | 3 ++-
On Mon, Dec 17, 2012 at 1:10 PM, Marcel Korpel marcel.li...@gmail.com wrote:
On Sun, Dec 16, 2012 at 7:12 PM, canyonknight canyonkni...@gmail.com wrote:
This implementation is susceptible to HTTP header injection.
Ok. You mean in the current 'Location:' line without filtering 0x0a and 0x0d
On Fri, Dec 14, 2012 at 5:51 PM, Marcel Korpel marcel.li...@gmail.com wrote:
Fixes FS#32481
---
web/html/login.php| 2 +-
web/lib/acctfuncs.inc.php | 8 +++-
web/lib/aur.inc.php | 44
web/template/header.php | 4 ++--
4
Fortune calls slows down the generation of dummy data dramatically
for large datasets. Read from a specified fortune file directly
to avoid the need for the subprocess.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
support/schema/gendummydata.py | 18 +++---
1 file changed
On Tue, Dec 11, 2012 at 9:17 AM, Marcel Korpel marcel.li...@gmail.com wrote:
On Tue, Dec 11, 2012 at 1:39 PM, Marcel Korpel marcel.li...@gmail.com wrote:
As FS#32986 isn't resolved yet, I can't test my typeahead-suggest
script. Can someone please send me (off-list) a correct version of
On Wed, Dec 5, 2012 at 11:49 AM, Marcel Korpel marcel.li...@gmail.com wrote:
This overrides my earlier patch
'INSTALL: Added MYUSER (needed from root)'
---
For future reference, anything above this is a part of the commit
message. Anything put here isn't. Since that other patch wasn't
applied,
On Thu, Dec 6, 2012 at 10:25 AM, Marcel Korpel marcel.li...@gmail.com wrote:
On Wed, Dec 5, 2012 at 8:24 PM, canyonknight canyonkni...@gmail.com wrote:
snip
You could also just set $USE_VIRTUAL_URLS to false and navigate using
the legacy pages packages.php, account.php, etc... Although I
On Wed, Dec 5, 2012 at 12:28 PM, Marcel Korpel marcel.li...@gmail.com wrote:
Hi all,
After following the instructions and giving Apache access to my home
directory, I managed to go to the local AUR home page. However, apart
from not having dummy data, I have some issues:
Could you please
On Wed, Dec 5, 2012 at 12:05 PM, Marcel Korpel marcel.li...@gmail.com wrote:
---
INSTALL | 3 +++
1 file changed, 3 insertions(+)
diff --git a/INSTALL b/INSTALL
index 76df42b..d682eda 100644
--- a/INSTALL
+++ b/INSTALL
@@ -69,6 +69,9 @@ Setup on Arch Linux:
$ mysql -uaur -p AUR
of the notification system.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/packages.php| 4 +--
web/lib/pkgfuncs.inc.php | 74
2 files changed, 45 insertions(+), 33 deletions(-)
diff --git a/web/html/packages.php b/web/html/packages.php
index
Signed-off-by: canyonknight canyonkni...@gmail.com
---
INSTALL | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/INSTALL b/INSTALL
index 1a41066..047cfc4 100644
--- a/INSTALL
+++ b/INSTALL
@@ -72,7 +72,7 @@ Setup on Arch Linux:
(give password 'aur' at the prompt
On Tue, Dec 4, 2012 at 8:32 AM, Marcel Korpel marcel.li...@gmail.com wrote:
Hi developers,
I'd like to implement a typeahead menu like it appears on the main
page. In order to test my PHP script that feeds package names, I need
a small subset of the AUR database (only the Packages table), say
hijacking.
Add a new flexible function can_edit_account() to determine if
a user has appropriate permissions. Run the permission check before
processing any account information in the backend.
Signed-off-by: canyonknight canyonkni...@gmail.com
Signed-off-by: Lukas Fleischer archli...@cryptocrack.de
A check is only done to verify a Trusted User isn't promoting their
account. An attacker can send tampered account type POST data to
change their User level account to a Developer account.
Add check so that all users cannot increase their own account
permissions.
Signed-off-by: canyonknight
Voter page token check takes place in the same way as other
existing token checks. Move the check for consistency.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/index.php | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/web/html/index.php b/web
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/login.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web/html/login.php b/web/html/login.php
index 9b3715b..e458fec 100644
--- a/web/html/login.php
+++ b/web/html/login.php
@@ -17,7 +17,7 @@ html_header('AUR
Packages with multiple DepConditions are returned multiple
times in the Required by column.
Limit SQL results to distinct packages.
Fixes FS#32478
Signed-off-by: canyonknight canyonkni...@gmail.com
---
Ignore previous duplicates fix. This works better as an SQL fix.
web/lib/pkgfuncs.inc.php
-by: canyonknight canyonkni...@gmail.com
---
web/lib/pkgfuncs.inc.php | 2 ++
1 file changed, 2 insertions(+)
diff --git a/web/lib/pkgfuncs.inc.php b/web/lib/pkgfuncs.inc.php
index 8f84cdf..4beaec3 100644
--- a/web/lib/pkgfuncs.inc.php
+++ b/web/lib/pkgfuncs.inc.php
@@ -178,6 +178,8 @@ function
in their tarball.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
The error message isn't great. But this avoids messing up the string freeze.
web/html/pkgsubmit.php | 4
1 file changed, 4 insertions(+)
diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php
index efd90e1
error code for when
the result limit is hit.
Fixes FS#31849
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/aurjson.class.php| 22 +-
web/lib/config.inc.php.proto | 4
2 files changed, 21 insertions(+), 5 deletions(-)
diff --git a/web/lib
the result limit is hit.
Fixes FS#31849
Signed-off-by: canyonknight canyonkni...@gmail.com
---
It doesn't have to be 5000. That's just a safe arbitrary number
I came up with during testing.
web/lib/aurjson.class.php | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/pkg_details.php | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php
index b286664..74f9257 100644
--- a/web/template/pkg_details.php
+++ b/web
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/pkg_comment_form.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web/template/pkg_comment_form.php
b/web/template/pkg_comment_form.php
index 903173d..da871ec 100644
--- a/web/template/pkg_comment_form.php
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/tu_list.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web/template/tu_list.php b/web/template/tu_list.php
index 566cb17..f80d2f5 100644
--- a/web/template/tu_list.php
+++ b/web/template/tu_list.php
* Add /option close tags
* Add VI delimiter to selected option
* Add quotes to language codes
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/account_edit_form.php | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/web/template
Replace incorrect /td tags with /th tags
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/account_details.php | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/web/template/account_details.php b/web/template/account_details.php
index aa18f5b
* Add missing p tag
* Move h4 outside of a p tag
* Rename an id to avoid a conflict with an already existing id
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/home.php | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/web/html/home.php b/web/html/home.php
Comment box already uses h2 tag. Additional label is not needed.
Also remove label for form submit button.
Reported-by: Dave Reisner d...@falconindy.com
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/pkg_comment_form.php | 2 --
1 file changed, 2 deletions(-)
diff --git
The delete button is currently on a separate line. Change some logic
to allow for the button to be on the same line as poster info.
Reported-by: Dave Reisner d...@falconindy.com
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/pkg_comments.php | 4 +++-
1 file changed, 3
As all new passwords are hashed and therefore stored in the database
at the same length, this limitation is no longer needed.
Fixes FS#31855
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/login.php | 2 +-
web/html/passreset.php | 4 ++--
web/lib
An array that contains whether the package is blacklisted is
being improperly used for a comparison. Use fetchColumn() to
avoid the array completely and compare a value directly.
Regression with e171f6f34eeacf35cf7142b4788d43e7d0978546
Fixes FS#31867
Signed-off-by: canyonknight canyonkni
Parameters were not correct for a package update operation.
Fix regression of 763cbf8373e3373254ad18f5b69fd16efdc6fd5c
Fixes FS#31868
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/pkgsubmit.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web/html
An ended vote details page will report a user hasn't voted even when
they have. This is a result of faulty logic that only checks if a user
has voted if the vote is still running.
Regression with commit c15441762c6f6ab4438eaf2854c0ee3146a98b30
Signed-off-by: canyonknight canyonkni...@gmail.com
Fixes FS#27669
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/header.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web/template/header.php b/web/template/header.php
index 3179a53..c78f1e3 100644
--- a/web/template/header.php
+++ b/web/template
Comment box already uses h2 tag. Additional label is not needed.
Reported-by: Dave Reisner d...@falconindy.com
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/pkg_comment_form.php | 1 -
1 file changed, 1 deletion(-)
diff --git a/web/template/pkg_comment_form.php
b/web
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/pkgfuncs.inc.php | 303 ---
1 file changed, 263 insertions(+), 40 deletions(-)
diff --git a/web/lib/pkgfuncs.inc.php b/web/lib/pkgfuncs.inc.php
index 06f348c..90b96a9 100644
--- a/web/lib
Package actions now have a separate box on the package details page. Make
a package deletion link in that box.
Link leads to a new page (pkgdel.php) that can be used to confirm package
deletion. A separate page with confirmation is used to avoid CSRFs.
Signed-off-by: canyonknight canyonkni
Package actions now have a separate box on the package details page. Add
a package merge link in that box.
Link leads to a new page (pkgmerge.php) that can be used to confirm package
merging. A separate page with confirmation is used to avoid CSRFs.
Signed-off-by: canyonknight canyonkni
The only buttons on the actions bar that were still used when virtual URLs
are enabled were the package deletion and package merging. These now reside
in separate pages, so remove the need for the actions bar when virtual URLs
are enabled.
Signed-off-by: canyonknight canyonkni...@gmail.com
When virtual URLs are enabled, simpler links can be used to access
a user's account details page. Change this for both the maintainer and
submitter links.
Keeps backwards compatibility with virtual URLs being disabled.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/acctfuncs.inc.php | 351 +++---
1 file changed, 270 insertions(+), 81 deletions(-)
diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php
index 8c96e6f..bce00f8 100644
--- a/web/lib
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/stats.inc.php | 22 ++
1 file changed, 22 insertions(+)
diff --git a/web/lib/stats.inc.php b/web/lib/stats.inc.php
index 2c26d43..60973e9 100644
--- a/web/lib/stats.inc.php
+++ b/web/lib/stats.inc.php
@@ -2,6
PHPDoc is a standardized format for commenting on PHP code.
Using it allows for a more cohesive use of IDEs and documentation
generators with the AUR code.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/aur.inc.php | 231 +++-
1
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/rss.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/web/html/rss.php b/web/html/rss.php
index 6f057bf..84d2205 100644
--- a/web/html/rss.php
+++ b/web/html/rss.php
@@ -28,7 +28,7 @@ $rss-encoding = UTF-8
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/pkgfuncs.inc.php | 23 ---
1 file changed, 23 deletions(-)
diff --git a/web/lib/pkgfuncs.inc.php b/web/lib/pkgfuncs.inc.php
index f0e64d2..8208af0 100644
--- a/web/lib/pkgfuncs.inc.php
+++ b/web/lib
The account editing form requires two different form action URLs
due to the fact that the same template is shared for both account
registration and account editing.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
This patch assumes all previous patches. This should complete those changes
to a package page
- The Latest Comments link appends ?comments=all to URL on every click
Anything else?
canyonknight (13):
Migrate all DB code to use PDO
Adjust user directions after registering to reflect new login page
logout.php: Fix PHP undefined variable notice
Add the new package icon
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/acctfuncs.inc.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php
index 54e8381..e7dcb10 100644
--- a/web/lib/acctfuncs.inc.php
+++ b/web/lib/acctfuncs.inc.php
This regression was introduced with d2480e8b9d3d0f946d57fa9422811cb37296b8b4.
Re-implement the functionality in a cleaner way.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/stats/updates_table.php | 3 +++
1 file changed, 3 insertions(+)
diff --git a/web/template/stats
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/images/new.gif | Bin 116 - 0 bytes
web/html/images/new.png | Bin 0 - 378 bytes
web/html/index.php | 4 ++--
web/template/stats/updates_table.php | 2 +-
4 files changed, 3 insertions
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/images/titlelogo.png | Bin 4502 - 0 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 web/html/images/titlelogo.png
diff --git a/web/html/images/titlelogo.png b/web/html/images/titlelogo.png
deleted file
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/pkg_comment_form.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web/template/pkg_comment_form.php
b/web/template/pkg_comment_form.php
index 95d2cb0..fb3ebff 100644
--- a/web/template/pkg_comment_form.php
Allows for easier account editing and saner URLs. Update account editing links
to use new URL.
Before:
AUR_URL/account/?Action=DisplayAccountU=userfoo
After:
AUR_URL/account/userfoo/edit
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/index.php | 10
The UpdateAccount page displays information as to whether an account
update was successful. All POST account info goes to this page, so use
it with sane URLs.
Before:
AUR_URL/account/?Action=UpdateAccountU=userfoo
After:
AUR_URL/account/userfoo/update
Signed-off-by: canyonknight canyonkni
* Restructure account.php to remove redundant code.
* Remove own_account_details().
* Rework logic check to default to no access to account edit form.
* Make default account action viewing account info.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/account.php | 34
* Use AUR_URL/account/userfoo/edit format for own account editing.
* Change Accounts label to My Account for regular users.
* Add ability for Developers and Trusted Users to edit their account
without having to use the search form first.
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web
, URL, description, license, or version is too long.
Also move the resolution of full package version (including epoch) to an
earlier point in pkgsubmit.php
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/pkgsubmit.php | 35 +--
1 file changed, 29
and parts
of the web interface that I may have failed at testing.
This patch series is based against Lukas' wip branch [1]. Those changes
and my changes in entirety can be had from my working branch [2].
[1] http://git.cryptocrack.de/aur.git/log/?h=wip
[2] https://github.com/canyonknight/aur/tree
The Required by column already handles an empty list appropriately. Move a
/div tag to match that behavior in the Dependencies column
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/template/pkg_details.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web
, URL, description, license, or version is too long.
Also move the resolution of full package version (including epoch) to an
earlier point in pkgsubmit.php
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/pkgsubmit.php | 35 +--
1 file changed, 29
Currently everyone is allowed to unflag a package as out of date. This should
be limited to only the appropriate people for a specific package.
Fixes FS#27263
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/lib/pkgfuncs.inc.php | 4
web/template/actions_form.php | 3
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/home.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web/html/home.php b/web/html/home.php
index df112b8..8fecfd4 100644
--- a/web/html/home.php
+++ b/web/html/home.php
@@ -91,7 +91,7 @@ $dbh = db_connect
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/pkgsubmit.php | 1 -
1 file changed, 1 deletion(-)
diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php
index 2fd21e6..c2a7191 100644
--- a/web/html/pkgsubmit.php
+++ b/web/html/pkgsubmit.php
@@ -477,7 +477,6 @@ else:
endif
Signed-off-by: canyonknight canyonkni...@gmail.com
---
web/html/tu.php | 1 +
1 file changed, 1 insertion(+)
diff --git a/web/html/tu.php b/web/html/tu.php
index 5537d3a..48cd6c1 100644
--- a/web/html/tu.php
+++ b/web/html/tu.php
@@ -34,6 +34,7 @@ if ($atype == Trusted User || $atype
100 matches
Mail list logo
