Re: [aur-dev][PATCH] Fix notifications emails going to the right people, part #2

2018-10-26 Thread Eli Schwartz
On 10/26/18 10:00 AM, Eli Schwartz wrote: > Notifications are still going to the wrong people. We tried to fix this > in commit b702e5c0e7f13103fc764b7e5613f78f3e7acd30, but only fixed it > for the python callers. There's another caller in the php code, which > needs to use the right order of

[aur-dev][PATCH] Fix notifications emails going to the right people, part #2

2018-10-26 Thread Eli Schwartz
Notifications are still going to the wrong people. We tried to fix this in commit b702e5c0e7f13103fc764b7e5613f78f3e7acd30, but only fixed it for the python callers. There's another caller in the php code, which needs to use the right order of arguments as well. Fixes FS#60602 Signed-off-by: Eli

Re: [aur-dev][PATCH] Fix notifications emails going to the right people

2018-08-30 Thread Eli Schwartz
On 8/11/18 4:25 AM, Lukas Fleischer wrote: > Wow, good catch! > > The patch is totally correct but the suspected cause is not. I think > thus is a regression introduced by f3b4c5c (Refactor the notification > script, 2018-05-17) where some of the parameters where accidentally > pushed around.

Re: [aur-dev][PATCH] Fix notifications emails going to the right people

2018-08-12 Thread Eli Schwartz
On 8/11/18 4:25 AM, Lukas Fleischer wrote: > On Fri, 10 Aug 2018 at 23:26:28, Eli Schwartz wrote: >> The notify script expects to see the userid followed by additional >> arguments like the pkgbase id, however, these were getting sent swapped >> around (presumably due to the similarity with the db

Re: [aur-dev][PATCH] Fix notifications emails going to the right people

2018-08-11 Thread Lukas Fleischer
On Fri, 10 Aug 2018 at 23:26:28, Eli Schwartz wrote: > The notify script expects to see the userid followed by additional > arguments like the pkgbase id, however, these were getting sent swapped > around (presumably due to the similarity with the db connection which > expects them in the other

[aur-dev][PATCH] Fix notifications emails going to the right people

2018-08-10 Thread Eli Schwartz
The notify script expects to see the userid followed by additional arguments like the pkgbase id, however, these were getting sent swapped around (presumably due to the similarity with the db connection which expects them in the other order when processing SQL statements). As a result, some