Re: [aur-dev] [PATCH] xhtml validation fixes for login_form.php

2008-06-06 Thread Michael Klier
Angel Velásquez wrote: >Hi Michael, first of all thanks for contributing to the AUR >Development. Hi Angel, >Imho, you must try to use quotes correctly, i mean simples and >doubles, you can find a good tutorial here: >[1]http://ve2.php.net/types.string >Or you can google '

Re: [aur-dev] [PATCH] xhtml validation fixes for login_form.php

2008-06-05 Thread Loui
On Thu, 5 Jun 2008 16:33:59 -0700 eliott <[EMAIL PROTECTED]> wrote: > On 6/5/08, Loui <[EMAIL PROTECTED]> wrote: > > Overall tabs are actually used for indentation, though it's not written > > anywhere. > > I thought there was a policy of spaces at one point. > 4 spaces for indentation, blah bl

Re: [aur-dev] [PATCH] xhtml validation fixes for login_form.php

2008-06-05 Thread Angel Velásquez
Hi Michael, first of all thanks for contributing to the AUR Development. Imho, you must try to use quotes correctly, i mean simples and doubles, you can find a good tutorial here: http://ve2.php.net/types.string Or you can google 'simple vs doble quotes + php', that will apply to you in many pro

Re: [aur-dev] [PATCH] xhtml validation fixes for login_form.php

2008-06-05 Thread eliott
On 6/5/08, Loui <[EMAIL PROTECTED]> wrote: > Overall tabs are actually used for indentation, though it's not written > anywhere. I thought there was a policy of spaces at one point. 4 spaces for indentation, blah blah.. similar to (but not quite the same as) the pacman codebase code guidelines.

Re: [aur-dev] [PATCH] xhtml validation fixes for login_form.php

2008-06-05 Thread Michael Klier
Loui wrote: > There are a couple worthwhile things in here but most of this just > looks like messing with the indentation and such. Overall tabs > are actually used for indentation, though it's not written anywhere. I was actually wondering about that because I haven't found a real refernce and I

Re: [aur-dev] [PATCH] xhtml validation fixes for login_form.php

2008-06-05 Thread Loui
There are a couple worthwhile things in here but most of this just looks like messing with the indentation and such. Overall tabs are actually used for indentation, though it's not written anywhere. You should try to write shorter patches that don't mess with everything in the file. It's less for

[aur-dev] [PATCH] xhtml validation fixes for login_form.php

2008-06-05 Thread Michael Klier
--- web/template/login_form.php | 45 +++--- 1 files changed, 20 insertions(+), 25 deletions(-) diff --git a/web/template/login_form.php b/web/template/login_form.php index 7fd40fb..b2ed066 100644 --- a/web/template/login_form.php +++ b/web/template/login_for