Hi Levente, Thanks for your review, packages have been updated accordingly.
> certbot-dns-hetzner: > - uses setuptools entry_point so python-setuptools is a first level > hard dependency > - missing hard requires on python-requests and python-zope-interface > as used in the modules It should be noted that this lead to a wiki change, which previously stated "Dependencies that are provided by other dependencies do not need to be listed" [1]. > dns-zone-blacklist-git: > - doesn't properly distribute a license declaration but just a comment > about the json that declares the license type. Please distribute > something in the licenses folder and ask upstream to provide a > license file in tree Fixed upstream [3], I've added the file in the package. > kiwix-desktop-git: > [...] > - didn't have time, but does PREFIX really need to contain ${pkgdir}? You're right, it doesn't. > prismatik-bin: > - hmm sources exist and a -git package seems to be possible, why > not build from source instead? we love sources :) > > prismatik-psieg-bin: > - same as prismatik-bin, more source more love Building stale QT software from 2015 is a little bit less love ;) Packages added [3] [4], but namcap complains: * ELF file ('usr/bin/prismatik') lacks FULL RELRO, check LDFLAGS * Unused shared library '/usr/lib/libGL.so.1' I'll have to look into it. > zimwriterfs: > - does this really require gumbo-git, it has like 5 more commits since > 2015 compared to repo gumbo-parser. Maybe would make more sense to > poke some upstream folks to tag a new version instead? > - seems to soon be superseded by zim-tools anyway As you said, I'm only waiting for a new version of zim-tools that includes zimwriterfs, so I'm not touching it for now. I'll keep gumbo-parser in mind. Best Regards hashworks [1] https://wiki.archlinux.org/?title=PKGBUILD&diff=prev&oldid=620592 [2] https://github.com/oznu/dns-zone-blacklist/pull/17 [3] https://aur.archlinux.org/packages/prismatik [4] https://aur.archlinux.org/packages/prismatik-psieg
pgpPq5Gk3sVSb.pgp
Description: OpenPGP digital signature