On 7 Nov 2013 16:31, "Maxime Gauduin" wrote:
>
> Furthermore, _APPNAME is easily replaced with ${pkgname%-*}, and there's
hardly any need to create a _BUILD_DIR variable if you're only going to use
it once.
>
> BTW, please reply at the bottom of the mail Jeremy, no top posting on the
mailing lists
On Thu, Nov 7, 2013 at 5:07 PM, Jeremy Audet
wrote:
I would discourage the use of all-caps variable names. Shells
typically use
all-caps for their environment variables, and although I don't know
of any
shells that use _BUILD_DIR or _APPNAME as environment vars, the
possibility
exists.
O
I would discourage the use of all-caps variable names. Shells typically use
all-caps for their environment variables, and although I don't know of any
shells that use _BUILD_DIR or _APPNAME as environment vars, the possibility
exists.
On Thu, Nov 7, 2013 at 10:38 AM, Leonidas Spyropoulos
wrote:
Go Ivan,
Thanks for the comments!
On 7 Nov 2013 15:21, "Ivan Shapovalov" wrote:
>
> Hi!
>
> Looks pretty good; I've got a few comments here and there.
>
> > source=('git+https://github.com/freeplane/freeplane.git' 'license.txt'
'freeplane.desktop' 'freeplane.run')
>
> It's better to use 'git://'
On Thursday 07 November 2013 at 19:21:19, Ivan wrote:
> On Thursday 07 November 2013 at 11:38:52, Leonidas wrote:
> > Hello,
> >
> > Just made a git version of freeplane package I maintain. Since it's one of
> > my first git packages I'd appreciate a second eye / opinion. Here is the
> > link:
> >
On Thursday 07 November 2013 at 11:38:52, Leonidas wrote:
> Hello,
>
> Just made a git version of freeplane package I maintain. Since it's one of
> my first git packages I'd appreciate a second eye / opinion. Here is the
> link:
> https://github.com/inglor/pkgbuild/tree/master/freeplane-git
>
> T
Hello,
Just made a git version of freeplane package I maintain. Since it's one of
my first git packages I'd appreciate a second eye / opinion. Here is the
link:
https://github.com/inglor/pkgbuild/tree/master/freeplane-git
Thanks
Leonidas
