Re: [aur-general] Adopt Monkeysphere

2014-12-13 Thread Jeremy Audet
Some small suggestions: * I'd suggest quoting the first item in the `source` array, on line 14. The variables being interpolated into that string should never contain spaces or other undesirable characters, but why take a chance? * Lines 15-17 contain tab characters. I'd suggest replacing them wit

Re: [aur-general] Adopt Monkeysphere

2014-12-11 Thread Valo
Thanks! I uploaded it Il 10/12/2014 21:28, Florian Bruhin ha scritto: > * Valo [2014-12-10 20:53:58 +0100]: >> Sorry, I was attacching an archive, maybe it's not possible, here [1] >> the archive, it'll be uploaded to the AUR if everything it's ok > Some minor things: > > - There are two checksum

Re: [aur-general] Adopt Monkeysphere

2014-12-10 Thread Florian Bruhin
* Valo [2014-12-10 20:53:58 +0100]: > Sorry, I was attacching an archive, maybe it's not possible, here [1] > the archive, it'll be uploaded to the AUR if everything it's ok Some minor things: - There are two checksum arrays, you most likely want to delete sha1sums. Most PKGBUILDs also have th

Re: [aur-general] Adopt Monkeysphere

2014-12-10 Thread Valo
Sorry, I was attacching an archive, maybe it's not possible, here [1] the archive, it'll be uploaded to the AUR if everything it's ok [1]http://efesto.eigenlab.org/~valo/monkeysphere-0.37-2.src.tar.gz Il 10/12/2014 14:49, Florian Bruhin ha scritto: > * Valo [2014-12-10 14:45:45 +0100]: >> Hello e

Re: [aur-general] Adopt Monkeysphere

2014-12-10 Thread Florian Bruhin
* Valo [2014-12-10 14:45:45 +0100]: > Hello everybody, I'm a new subscriber of the list and an arch user since > 3-4 years. > I adopted monkeysphere after talking with the old maintainer, hope it's > fine for you. > Since it's my first adoption and PKGBUILD I'd like to ask you to review > it, I'm

[aur-general] Adopt Monkeysphere

2014-12-10 Thread Valo
Hello everybody, I'm a new subscriber of the list and an arch user since 3-4 years. I adopted monkeysphere after talking with the old maintainer, hope it's fine for you. Since it's my first adoption and PKGBUILD I'd like to ask you to review it, I'm wide-open to suggestions, then if it's fine i'll