Re: [aur-general] RFC: PKGBUILD for nixnote2-git [Take 3]

2018-10-07 Thread Florian Bruhin
On Sun, Oct 07, 2018 at 10:46:56AM -0400, Eli Schwartz via aur-general wrote: > On 10/7/18 5:58 AM, Florian Bruhin wrote: > > That seems like a good idea, but I'm not sure a PKGBUILD should set it. > > Maybe makepkg even does it by itself? > Who says it's a good idea? When is it a good idea? How do

Re: [aur-general] RFC: PKGBUILD for nixnote2-git [Take 3]

2018-10-07 Thread Eli Schwartz via aur-general
On 10/7/18 5:32 AM, Tom Hale wrote: > Here's a version which builds from HEAD of the default branch. > > Comments please. Well, by convention you would post this inline instead of as an attachment since it is easier to review that way... > _pkgname=nixnote2 > _repo_url="https://github.com/robert

Re: [aur-general] RFC: PKGBUILD for nixnote2-git [Take 3]

2018-10-07 Thread Tom Hale
On 7/10/18 4:58 pm, Florian Bruhin wrote: On Sun, Oct 07, 2018 at 04:32:04PM +0700, Tom Hale wrote: Guess you could use $_pkgname here for nixnote2. Also not sure specifying the version there is a good idea. https://wiki.archlinux.org/index.php/PKGBUILD#provides says: Note: The version that

Re: [aur-general] RFC: PKGBUILD for nixnote2-git [Take 3]

2018-10-07 Thread Florian Bruhin
On Sun, Oct 07, 2018 at 04:32:04PM +0700, Tom Hale wrote: > Comments please. Some random stuff I noticed: > _repo_url="https://github.com/robert7/${_pkgname}.git"; Probably not needed when you only need it in source. > provides=("nixnote=${pkgver%.r*}" "nixnote2=${pkgver%.r*}") Guess you could

Re: [aur-general] RFC: PKGBUILD for nixnote2-git [Take 3]

2018-10-07 Thread Tom Hale
Here's a version which builds from HEAD of the default branch. Comments please. -- Tom Hale # Maintainer: Tom Hale # Contributor: twa022 _pkgname=nixnote2 _repo_url="https://github.com/robert7/${_pkgname}.git"; pkgname=${_pkgname}-git pkgver=v2.1.0.beta3.r95.g8f235769 pkgrel=1 pkgdesc="Evern