[aur-general] graphviz perl module package

Hi, I did this PKGBUILD for graphviz, and I think it is OK. But I would like someone more experienced (I never did a PKGBUILD) took a look and tell me if it is really OK and I can upload it to aur. I based it on this sample found on the wiki:

Re: [aur-general] graphviz perl module package

On 13.11.2010 17:54, Antonio Lucas wrote: I did this PKGBUILD for graphviz, and I think it is OK. But I would like someone more experienced (I never did a PKGBUILD) took a look and tell me if it is really OK and I can upload it to aur. You should: - move everything after make into package()

Re: [aur-general] graphviz perl module package

On Sat, Nov 13, 2010 at 06:06:13PM +0100, Florian Pritz wrote: You should: - move everything after make into package() - remove || return 1 - replace $startdir/{pkg,src} by ${pkg,src}dir - remove the 3rd line (useless comment) That should look similar to this

Re: [aur-general] graphviz perl module package

Am 13.11.2010 17:54, schrieb Antonio Lucas: Hi, I did this PKGBUILD for graphviz, and I think it is OK. But I would like someone more experienced (I never did a PKGBUILD) took a look and tell me if it is really OK and I can upload it to aur. I based it on this sample found on the wiki:

Re: [aur-general] graphviz perl module package

Am 13.11.2010 18:33, schrieb Stefan Husmann: Maybe arch should be 'any'? (answering to myself after testing) Yes, it should be!

Re: [aur-general] graphviz perl module package

Le samedi 13 novembre 2010 12:15:35, Lukas Fleischer a écrit : On Sat, Nov 13, 2010 at 06:06:13PM +0100, Florian Pritz wrote: You should: - move everything after make into package() - remove || return 1 - replace $startdir/{pkg,src} by ${pkg,src}dir - remove the 3rd line (useless

Re: [aur-general] graphviz perl module package

Am 13.11.2010 19:04, schrieb Stéphane Gaudreault: Le samedi 13 novembre 2010 12:15:35, Lukas Fleischer a écrit : On Sat, Nov 13, 2010 at 06:06:13PM +0100, Florian Pritz wrote: You should: - move everything after make into package() - remove || return 1 - replace $startdir/{pkg,src} by

Re: [aur-general] graphviz perl module package

hi everyone, thanks the quickly response for all (and sorry the top posting =p) I modified the PKGBUILD based on your suggestions. I added the graphviz package as a dependecy (I have forgoten that because I already had it installed). I do not know the diference between makedepends and depends