Re: wiringX-git PKGBUILD Review Request (#2)

2024-01-08 Thread David C. Rankin
On 1/7/24 08:37, Doug Newgard wrote: If there is ever an actual "Release" of wiringX, then we can remove the pkgver() function entirely. That's not how -git PKGBUILDs work. It builds from HEAD and should always build from HEAD. You really need to fix the pkgver function. Looking at the upstream

Re: wiringX-git PKGBUILD Review Request (#2)

2024-01-07 Thread Doug Newgard
> If there is > ever an actual "Release" of wiringX, then we can remove the pkgver() function > entirely. That's not how -git PKGBUILDs work. It builds from HEAD and should always build from HEAD. You really need to fix the pkgver function. Looking at the upstream CMakeLists.txt, I would version

Re: wiringX-git PKGBUILD Review Request (#2)

2024-01-07 Thread David C. Rankin
On 1/5/24 21:01, Aaron Liu wrote: Hmm, I know nothing on the library side of things, but as Arch conventions dictate: 1. All package titles should be lowercase, so wiringx-git, perhaps?. 2. You should probably do a provides=(libwiringx.so wiringx) so the soname is searchable and conflicts are