Re: Why conditionally include config.h?

2012-09-15 Thread Kip Warner
On Thu, 2012-09-13 at 17:43 -0600, Eric Blake wrote: Yep, you are exactly right, which is why gnulib doesn't use HAVE_CONFIG_H, and even provides a syntax check rule that you can copy into your project to also avoid it yourself. Thanks Eric. That was very helpful. I see that you also made some

Re: Why conditionally include config.h?

2012-09-15 Thread Kip Warner
On Fri, 2012-09-14 at 02:58 +0300, Marko Lindqvist wrote: I've seen some packages where same sources are used with multiple build systems (typically autotools in more unixy systems and visual studio project files on Windows) and it's actually needed to weed out config.h include when building

Re: Why conditionally include config.h?

2012-09-15 Thread Kip Warner
On Thu, 2012-09-13 at 19:14 -0500, Bob Friesenhahn wrote: Since subsequent responses are not yet adequate ... It is not necessary to have a configuration header when Autoconf is used. If a configuration header is not used, then all definitions appear on the compiler command line and

Re: Why conditionally include config.h?

2012-09-15 Thread Kip Warner
On Thu, 2012-09-13 at 17:17 -0700, Russ Allbery wrote: I believe the #ifdef wrapper used to be recommended by the Autoconf manual way back, many moons ago (2.13 days at the latest), because it was how the transition from defining things via -D on the command line to using a header was handled.

Re: Why conditionally include config.h?

2012-09-15 Thread Russ Allbery
Kip Warner k...@thevertigo.com writes: Thanks Russ. That was very helpful. Is there a general rule on which source files to #include config.h, or is it as simple as any files that needs now or may need in the future the information contained in it. One exception as previously pointed out