Re: [PATCH] use m4_require to implement AS_REQUIRE

2008-10-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paolo Bonzini on 10/12/2008 10:20 AM: > The implementation is easy, though I had to try several times before > getting it right. Anyway, the attached patch works and adds a testcase > for the first behavior. The second bug is already tes

Re: [PATCH] use m4_require to implement AS_REQUIRE

2008-10-17 Thread Paolo Bonzini
> It's still not perfect. This file is failing: > > AS_INIT > foo=bar > AS_VAR_PUSHDEF([tmp], [foo]) > AS_VAR_IF(tmp, [bar], [echo yes], [echo no]) > AS_VAR_POPDEF([tmp]) > > because it is expanding _AS_TR_SH_PREPARE in the middle of AS_VAR_IF > rather than hoisting it into M4SH-INIT right afte

Re: [PATCH] use m4_require to implement AS_REQUIRE

2008-10-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paolo Bonzini on 10/17/2008 6:19 AM: > That's related to tmp being underquoted, see the following even more > reduced testcase > > AS_INIT > m4_defun([AS_DOIT], [: $1]) > m4_define([tmp], [AS_TR_SH(foo)]) > AS_DOIT(tmp) > > => : # Sed ex

Re: [PATCH] use m4_require to implement AS_REQUIRE

2008-10-17 Thread Paolo Bonzini
Eric Blake wrote: > According to Paolo Bonzini on 10/17/2008 6:19 AM: >> That's related to tmp being underquoted, see the following even more >> reduced testcase > >> AS_INIT >> m4_defun([AS_DOIT], [: $1]) >> m4_define([tmp], [AS_TR_SH(foo)]) >> AS_DOIT(tmp) > >> => : # Sed expression to map a st

Re: [PATCH] use m4_require to implement AS_REQUIRE

2008-10-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paolo Bonzini on 10/17/2008 6:41 AM: > I still cannot understand why the diversion ends up like this though. > > Here is an even smaller testcase: > > AS_INIT > m4_defun([AS_FROBIT_PREPARE], [frob=1]) > m4_defun([AS_FROBIT], [AS_REQUIRE(

Re: [PATCH] use m4_require to implement AS_REQUIRE

2008-10-17 Thread Paolo Bonzini
> The point is that text goes into a diversion only when _you are not doing > argument collection_ - in other words, the macro call must be expanded at > the outermost level. Any macro that potentially changes the current > diversion must be quoted, rather than expanded in advance, when handed as

Add and document AS_VAR_COPY, speed up configure

2008-10-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm planning on committing this to savannah later today, unless someone reviews it sooner. $ git pull http://repo.or.cz/w/autoconf/ericb.git master The driving factor behind this patch is that I wanted to fix what is already present in the AS_VAR fam

Re: Add and document AS_VAR_COPY, speed up configure

2008-10-17 Thread Ralf Wildenhues
Hi Eric, * Eric Blake wrote on Fri, Oct 17, 2008 at 07:43:51PM CEST: > > I'm planning on committing this to savannah later today, unless someone > reviews it sooner. Overall very nice, only nits. Thanks! > Subject: [PATCH] Add AS_VAR_COPY. > > +# AS_VAR_SET(VARIABLE, VALUE) > +# -

Re: Add and document AS_VAR_COPY, speed up configure

2008-10-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Ralf Wildenhues on 10/17/2008 1:05 PM: > Overall very nice, only nits. Thanks! Applied, with these changes: > >> Subject: [PATCH] Add AS_VAR_COPY. >> >> +# AS_VAR_SET(VARIABLE, VALUE) >> +# --- >> +# Set the VAL

reduce vertical whitespace

2008-10-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Looking at configure, there was a big window of vertical whitespace. This narrows it to be a bit more legible (configure scripts, as generated files, will never be perfectly easy to read, but every little bit helps. Applying this: - -- Don't work too

Re: naming m4_transform

2008-10-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 10/14/2008 5:31 PM: > > I like it. Here's three preliminary patches along this front: > > aaee3a9 Document m4_map_args. > 4cd6caa Add m4_set_map. > 3bdb8d4 Improve suggested test filtering. > > But m4 doesn't make it easy