-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Paolo Bonzini on 10/20/2008 7:35 AM:
2008-10-12 Paolo Bonzini [EMAIL PROTECTED]
* lib/autoconf/general.m4 (_AC_COMPILE_IFELSE): Use a shell function.
Committed with this squashed on:
- --
Don't work too hard, make some time
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 10/16/2008 7:43 AM:
Here's what I'm considering checking in; I'd like some feedback to make
sure I'm not missing anything. For that matter, since the 'missing'
script supports autom4te, should we update the example to
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Paolo Bonzini on 10/21/2008 8:36 PM:
I'll apply this tomorrow unless I get feedback first.
Seems a good idea...
Committed.
Commit the AC_PREPROC_IFELSE functionization too
already done earlier today, but I just now did 2/12
so
so that I'll rebase my other function patches (by the way, are you going
to frob all the other 11 patches 11, to split the function body, too?).
Yes, I've been (slowly) visiting them one at a time; we might as well be
consistent splitting out the function body.
Great -- take your time!
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Paolo Bonzini on 10/22/2008 6:20 AM:
so that I'll rebase my other function patches (by the way, are you going
to frob all the other 11 patches 11, to split the function body, too?).
Yes, I've been (slowly) visiting them one at a time;
Simon Josefsson [EMAIL PROTECTED] wrote:
Jim, the getgroups m4 check causes errors on mingw:
./configure: line 8004: test: =: unary operator expected
The problem is this code:
AC_REQUIRE([AC_FUNC_GETGROUPS])
if test $ac_cv_func_getgroups_works = no; then
The AC_FUNC_GETGROUPS
Jim Meyering jim at meyering.net writes:
To autoconf folks, I've attached the obvious patch below,
and will push it some time tomorrow if no one objects.
From: Jim Meyering meyering at redhat.com
Date: Wed, 22 Oct 2008 17:25:46 +0200
Subject: [PATCH] AC_FUNC_GETGROUPS: always define
Paolo Bonzini bonzini at gnu.org writes:
2008-10-12 Paolo Bonzini bonzini at gnu.org
* lib/autoconf/general.m4 (_AC_LINK_IFELSE): Use a shell function.
+ AS_IF([_AC_DO_STDERR($ac_link) {
I just noticed that _AC_DO_STDERR used $LINENO rather than $as_lineno, so by
moving it
I had left the removal of unneeded subshells (which would indeed jump up
when the code is moved to shell functions) for later. But since you're
at it this one:
(exit $ac_status); }])
in _AC_RUN_LOG_STDERR and _AC_RUN_LOG could also be changed to an
ac_func_set_status shell function that does
Paolo Bonzini bonzini at gnu.org writes:
2008-10-12 Paolo Bonzini bonzini at gnu.org
* lib/autoconf/general.m4 (_AC_RUN_IFELSE): Use a shell function.
-_AC_MSG_LOG_CONFTEST
-m4_ifvaln([$3],
- [( exit $ac_status )
-$3])dnl])[]dnl
-rm -rf conftest.dSYM
-rm -f core *.core
Paolo Bonzini bonzini at gnu.org writes:
(exit $ac_status); }])
in _AC_RUN_LOG_STDERR and _AC_RUN_LOG could also be changed to an
ac_func_set_status shell function that does just return $1. A
candidate for m4sh maybe?
Absolutely! Nice catch. I think an m4sh addition would be nice,
Hello Eric, Paolo,
* Eric Blake wrote on Wed, Oct 22, 2008 at 07:59:08PM CEST:
This is a subtle change in semantics; beforehand, the if-failed code
($3) was executed while the compiler output still existed, and could
theoretically rerun conftest$ac_exeext with an argument; now the files
are
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Ralf Wildenhues on 10/22/2008 2:34 PM:
Hello Eric, Paolo,
* Eric Blake wrote on Wed, Oct 22, 2008 at 07:59:08PM CEST:
This is a subtle change in semantics; beforehand, the if-failed code
($3) was executed while the compiler output
This patch makes autoreconf pass along -I arguments to aclocal, which
is useful in cases
where m4 files are installed in sensible, but non standard places
(like /opt/local/share/aclocal)
cheers,
--
Clinton Roy
CSIRO - Robotics Platform Engineer
Autonomous Systems Lab
humbug.org.au - Brisbane
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 10/22/2008 12:25 PM:
Paolo Bonzini bonzini at gnu.org writes:
(exit $ac_status); }])
in _AC_RUN_LOG_STDERR and _AC_RUN_LOG could also be changed to an
ac_func_set_status shell function that does just return $1. A
* Eric Blake wrote on Thu, Oct 23, 2008 at 04:46:39AM CEST:
According to Ralf Wildenhues on 10/22/2008 2:34 PM:
While I haven't looked at this in detail, I do know there are places in
Autoconf where removing the output files before evaluating the actions
breaks user scripts. So this
* Eric Blake wrote on Thu, Oct 23, 2008 at 06:13:00AM CEST:
How likely is it that m4sh users care about 'set -e' bugs prior to
exiting?
No idea. Would be cool if trivial to do, though. (Even if we'd have to
exclude OSF1.)
Should m4sh cater to that OSF1/Tru64 sh bug?
Would be cool; but
17 matches
Mail list logo
