AM_CONDITIONAL fails with line break at the end of $2

2014-07-17 Thread Dimitrios Apostolou
Hello list, the following snippet generates invalid shell code (and a cryptic error message) because of the line break right before the closing parenthesis. AM_CONDITIONAL([HAVE_LIBXML2], [test "x$with_libxml2" != xno && test "x$ac_cv_lib_xml2_xmlFirstElementChild" = xyes] ) Generat

Re: AM_CONDITIONAL fails with line break at the end of $2

2014-07-17 Thread Eric Blake
[adding automake] On 07/17/2014 10:00 AM, Dimitrios Apostolou wrote: > Hello list, > > the following snippet generates invalid shell code (and a cryptic error > message) because of the line break right before the closing parenthesis. > > AM_CONDITIONAL([HAVE_LIBXML2], > [test "x$with_libxml2

Re: AM_CONDITIONAL fails with line break at the end of $2

2014-07-17 Thread Dimitrios Apostolou
Hi Erik, thank you for forwarding to the appropriate list! On Thu, 17 Jul 2014, Eric Blake wrote: I don't know if automake should work around your bad syntax, or if you should just fix your configure.ac to use correct syntax to begin with. I Is my syntax illegal? Can't I put line-breaks there

Re: AM_CONDITIONAL fails with line break at the end of $2

2014-07-17 Thread Eric Blake
On 07/17/2014 12:44 PM, Dimitrios Apostolou wrote: > Hi Erik, thank you for forwarding to the appropriate list! > > On Thu, 17 Jul 2014, Eric Blake wrote: >> >> I don't know if automake should work around your bad syntax, or if you >> should just fix your configure.ac to use correct syntax to begi

[PATCH] m4sh: allow trailing newlines in shell conditions

2014-07-17 Thread Eric Blake
Dimitrios Apostolou reported confusion in understanding why his configure.ac was generating a shell syntax error with: AM_CONDITIONAL([HAVE_LIBXML2], [test "x$with_libxml2" != xno && test "x$ac_cv_lib_xml2_xmlFirstElementChild" = xyes] ) Root cause was that his trailing newline, coupled

Re: [PATCH] m4sh: allow trailing newlines in shell conditions

2014-07-17 Thread Paul Eggert
Thanks, this patch seems like the right thing to do to handle this sort of problem.

Re: [PATCH] m4sh: allow trailing newlines in shell conditions

2014-07-17 Thread Eric Blake
On 07/17/2014 03:31 PM, Paul Eggert wrote: > Thanks, this patch seems like the right thing to do to handle this sort > of problem. Pushed. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signatur

[PATCH] AC_LANG for Java

2014-07-17 Thread Mike Duigou
Hello all; I've prepared a prospective patch for supporting Java with AC_LANG. I've modelled the patch on what I found in the Go and Erlang AC_LANG implementations. (BTW, the Go support needs updating. There are problems in the _AC_LANG_IO_PROGRAM due to symbol name changes). The key things pr