Re: [PATCH 1/5] Require Perl 5.10.0 or later.

+AS_EXECUTABLE_P(["$ac_path_$1"]) || continue > +$3 > +$ac_path_$1_found && break 4 > + done > +done > + done])dnl > + if test -z "$ac_cv_path_$1"; then > + m4_default([$4], > + [AC_MSG_ERROR([no acceptable m4_bpatsubst(

Re: [PATCH] Port test to next m4 version

On Tue, Aug 31, 2021 at 04:15:28PM -0700, Paul Eggert wrote: > * tests/tools.at (autom4te cache): > Allow m4 to quote 'like this' as well as 'like this'. > --- > tests/tools.at | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) ACK. -- Eric Blake, Principal So

Re: [PATCH] doc: fix typo in variable name

can check whether the C++ compiler has been set to > -accept standard C++ by inspecting the shell variable @code{ac_prog_cc_stdc}. > +accept standard C++ by inspecting the shell variable > @code{ac_prog_cxx_stdcxx}. Yep, that's correct. I've pushed it. -- Eric Blake, Principal Soft

Re: [PATCH] _AC_PROG_CXX_STDCXX_EDITION_TRY: fix typo in variable name

name matches the comments above and the resulting _AC_COMPILE_IFELSE below, but agree that it is correct. Thanks; I've pushed it in your name. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: [PATCH] lib/autoconf/c.m4: fix NULL pointer dereference in _AC_LANG_IO_PROGRAM

my employer added a few weeks ago a configuration > to GMail which automatically adds this blurb, even to full-text emails > sent to mailing lists. Thanks! That indeed makes it easier to reply to your mail without worrying whether I'm getting in trouble with your employer. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

[PATCH] maint: advertise GNU in README

* README: Add section to attract more people towards the GNU project. Inspired by a suggestion from Jose E. Marchesi on the gnu-prog-discuss mailing list. --- README | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/README b/README index fd16df7c..2cedb951

[PATCH] maint: ensure autoconf-latest.* links stay up-to-date

* cfg.mk (GNUPLOADFLAGS): New. https://lists.gnu.org/archive/html/autoconf/2021-05/msg6.html --- I just pushed this, after coming up with something similar for m4. cfg.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cfg.mk b/cfg.mk index 0d4ec728..6a89e489 100644 --- a/cfg.mk +++

Re: [PATCH] AC_LANG_INT_SAVE: Modernize function declarators (C89 and above).

. It may not be needed on that front, but at the same time, I don't see it as hurting. We can't guarantee that all configure snippets compile warning-free, but where a warning is easy to avoid, we might as well do it. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301

Re: [PATCH] Define $as_echo and $as_echo_n for backward compatibility.

On 3/13/20 2:22 PM, Zack Weinberg wrote: On Fri, Mar 13, 2020 at 3:13 PM Eric Blake wrote: Unpatched bash 5.0 has a bug where calling $as_echo that contains \ can result in unintended globbing, where the behavior of the expansion is dependent on the contents of the current directory. Nasty

Re: [PATCH] Define $as_echo and $as_echo_n for backward compatibility.

s bug doesn't affect this patch) https://www.mail-archive.com/austin-group-l@opengroup.org/msg04237.html ACK -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH] _AS_REEXEC_WITH_SHELL: don’t use AS_EXIT.

ll appear _after_ this point. +dnl We shouldn't have to worry about any traps being active at this point. +exit 255])# _AS_REEXEC_WITH_SHELL # _AS_PREPARE -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH] AC_COMPILE_IFELSE: Evaluate user supplied arguments

ur use of ${CFLAGS} during configure should use the same level of quotation stripping as what the resulting makefile will. Your patch could use a NEWS entry for the change. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] AC_C_BIGENDIAN: fix narrowing error

On 03/12/2018 07:47 AM, Eric Blake wrote: On 03/12/2018 04:24 AM, Rechi wrote: The following patch will fix AC_C_BIGENDIAN, for cross compiling, if narrowing is a fatal error in the used compiler. Narrowing should not be a fatal error unless you used -Werror, which we advise against doing

Re: [PATCH] AC_C_BIGENDIAN: fix narrowing error

short int ebcdic_mm[] =   { 0xC2C9, 0xC785, 0x95C4, 0x8981, 0x95E2, 0xA8E2, 0 }; and that is easy to maintain, so I'll go ahead and incorporate it when I get a chance. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org

Re: [PATCH] Support for Flang and ARM HPC compiler

ran expert, so I can't test this, but in principle the patch looks reasonable; and it is small enough to not need copyright assignment. However, I wonder if it does need mention in NEWS, so I'll wait a bit longer before applying to see if anyone else chimes in on review. -- Eric Blake, Principal Sof

Re: [nts] bootstrap patch

quivalent to adding :.:; having the current working directory earlier than the end of PATH can sometimes lead to trojan horses being executed. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org signature.asc Description

Re: [PATCH] fix regex in AC_DEFINE_UNQUOTED

ot; for > basic regex alteration. > * tests/torture.at (Substitute and define special characters): > Add test case. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > lib/autoconf/general.m4 | 2 +- > tests/torture.at | 2 ++ > 2 files changed, 3 inse

Re: bug#25740: [PATCH] Swallow m4traces that have no file/line number

XFile ($tcache . $req->id, "<"); >while ($_ = $traces->getline) > { > + # Traces without file/line > + next if (m{^m4trace: -(\d+)- ([^(]+)\((.*)$}); Would it be better to keep the error message, but set the file and line to placeholders, instead of comp

[PATCH] doc: emphasize that config.h must be first

* doc/autoconf.texi (C and Posix Variants, System Services): Remind user to include config.h first. (Configuration Headers): Give another reason why config.h must be first, and mention that only .c files need it. Based on discussion on bugs.debian.org/158969 Signed-off-by: Eric Blake <

[PATCH] doc: Mention effect of 'autoreconf -fi' on INSTALL

customizations, and that the set of files impacted is controlled by automake. Reported by Emil Laine <laine.e...@gmail.com> Signed-off-by: Eric Blake <ebl...@redhat.com> --- [I'm obviously digging through my inbox for old emails in preparation for trying to release 2.70, as Emil fi

Re: [PATCH 3/3] maint: Allow amendments to git log when generating ChangeLog

[adding coreutils] On 12/22/2016 03:36 PM, Eric Blake wrote: > Copied from Coreutils. Note that git-log-fix does not yet > exist, and even when it does, it will not be part of the > tarball (since it only makes sense in the context of a git > checkout). > > * Makefile.am (gen

[PATCH 1/3] maint: Merge HACKING and README-hacking

It makes no sense to have two files that describe things that only apply to a git checkout, when only one will do. Signed-off-by: Eric Blake <ebl...@redhat.com> --- HACKING| 134 +++--- README-hacking

[PATCH 2/3] maint: Tweak HACKING for generated ChangeLog

Signed-off-by: Eric Blake <ebl...@redhat.com> --- HACKING | 39 +-- 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/HACKING b/HACKING index 07d7bcd..0f53bb8 100644 --- a/HACKING +++ b/HACKING @@ -33,16 +33,6 @@ generate the version

[PATCH 3/3] maint: Allow amendments to git log when generating ChangeLog

Copied from Coreutils. Note that git-log-fix does not yet exist, and even when it does, it will not be part of the tarball (since it only makes sense in the context of a git checkout). * Makefile.am (gen-ChangeLog): Allow for corrections. Signed-off-by: Eric Blake <ebl...@redhat.

[RFC PATCH 0/3] HACKING cleanups

that you don't know the commit id until after the tweak is committed). Eric Blake (3): maint: Merge HACKING and README-hacking maint: Tweak HACKING for generated ChangeLog maint: Allow amendments to git log when generating ChangeLog HACKING| 153

Re: update HACKING file

often deemed politically-incorrect when it might rule out women, while "their" has gained a new meaning as a singular gender-neutral pronoun by enough native speakers. So on those grounds, I'm okay applying your patch. I'll probably do a followup (these days, we don't hand-maintain ChangeLog, but ins

[PATCH] doc: Patterns in m4_pattern_forbid cause error, not warning

of m4_pattern_allow() as the fix, and beef up the example to better demonstrate the problem. * doc/autoconf.texi (Autoconf Language): Improve AC_DC example. Reported by Gavin Smith <gavinsmith0...@gmail.com>. Signed-off-by: Eric Blake <ebl...@redhat.com> --- doc/autoco

[PATCH 1/2] m4sh: Add _AS_INVOCATION

@@_INVOCATION): Test it. Inspired by a report by Kevin Brubeck Unhammer <unham...@fsfe.org>. Signed-off-by: Eric Blake <ebl...@redhat.com> --- lib/m4sugar/m4sh.m4 | 14 ++ tests/m4sh.at | 23 +++ 2 files changed, 37 insertions(+) diff --git a

[PATCH 2/2] autoconf: Properly quote logged command line

difference to shell parsing of the pasted line.) * lib/autoconf/general.m4 (_AC_INIT_CONFIG_LOG): Use _AS_INVOCATION. * lib/autoconf/status.m4 (_AC_OUTPUT_CONFIG_STATUS): Likewise. Reported by Kevin Brubeck Unhammer <unham...@fsfe.org> Signed-off-by: Eric Blake <ebl...@redhat.com> --- I

[PATCH 0/2] Fix logged command line

of config.log. Eric Blake (2): m4sh: Add _AS_INVOCATION autoconf: Properly quote logged command line lib/autoconf/general.m4 | 3 ++- lib/autoconf/status.m4 | 3 ++- lib/m4sugar/m4sh.m4 | 14 ++ tests/m4sh.at | 23 +++ 4 files changed, 41

Re: [PATCH] Add support for fuchsia (OS)

and succeed. # You can get the latest version of this script from: # http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub and you want your patch to go there to benefit all projects. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http:/

[PATCH v3 3/4] AC_CHECK_FUNCS_ONCE: hoist cache name computation to m4 time

. (_AC_FUNCS_EXPANSION): Use it to inline enough of AC_CHECK_FUNC to operate on a literal rather than a shell variable, for fewer sed calls. Signed-off-by: Eric Blake <ebl...@redhat.com> --- lib/autoconf/functions.m4 | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff

[PATCH v3 0/4] limit number of cat and sed forks

quite as large (on coreutils, Paolo's cost about 17k, my approach cost about 2k). Eric Blake (3): AC_CHECK_FUNCS_ONCE: honor current AC_LANG AC_CHECK_FUNCS_ONCE: hoist CPP name computation to m4 time AC_CHECK_FUNCS_ONCE: hoist cache name computation to m4 time Paolo Bonzini (1): autoconf

[PATCH v3 4/4] autoconf: prefer an unrolled loop for trivial AC_CHECK_FUNCS

l loop if safe. (_AC_CHECK_FUNCS): Move basic implementation here. Signed-off-by: Paolo Bonzini <bonz...@gnu.org> Message-Id: <1477933688-4884-2-git-send-email-bonz...@gnu.org> [eblake: perform AC_CHECK_FUNCS_ONCE changes separately, use dnl to reduce generated blank lines] Signed-off-b

[PATCH v3 1/4] AC_CHECK_FUNCS_ONCE: honor current AC_LANG

AC_CHECK_FUNCS_ONCE while a different language is active is a no-op (this still makes sense because the side-effect of defining the CPP macro HAVE_FUNC does not include a language prefix). * lib/autoconf/functions.m4 (_AC_CHECK_FUNC_ONCE) (_AC_FUNCS_EXPANSION): * NEWS: Mention it. Signed-off-by: Eric

[PATCH v3 2/4] AC_CHECK_FUNCS_ONCE: hoist CPP name computation to m4 time

walk to parse off pairs of arguments, for fewer sed calls. Signed-off-by: Eric Blake <ebl...@redhat.com> --- lib/autoconf/functions.m4 | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/lib/autoconf/functions.m4 b/lib/autoconf/functions.m4 index 7b98a06..b

Re: [PATCH v2 1/3] autoconf: prefer an unrolled loop for trivial AC_CHECK_FUNCS

On 11/02/2016 08:28 PM, Eric Blake wrote: >> How would you do that? You would have to expand before the first >> AC_CHECK_FUNC_ONCE, but you do not have a diversion there (you might >> need one per language, in fact). > > Oh, and you're right that N would have to be

Re: [PATCH v2 1/3] autoconf: prefer an unrolled loop for trivial AC_CHECK_FUNCS

On 11/02/2016 06:41 PM, Paolo Bonzini wrote: > > > On 02/11/2016 23:14, Eric Blake wrote: >> Our use of AC_REQUIRE hoists the check outside of any AS_IF or similar >> code. However, while I don't think any well-written configure.ac script >> will be checking $ac_c

Re: [PATCH v2 0/3] limit number of cat and sed forks

ns are moved to autoconf time. cat is replaced by printf. > I'm still working on testing this (I'm trying to test against coreutils, to see the impact in configure size - but that turned up a recent problem in gnulib that I have to resolve first), but will get it in shortly. -- Eric Blake eb

Re: [PATCH] Fix an infinitely recursing example

t repository. > --- > doc/autoconf.texi | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Good catch! I'll install this alongside other patches that I'm testing this week. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] doc: detail inconsistencies in sed word boundary handling

itage plus cygwin extension). It may be worth pointing out that POSIX does not require ANY support for word boundaries in regex. ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/3] autoconf: prefer an unrolled loop for trivial AC_CHECK_FUNCS

On 10/31/2016 10:33 AM, Paolo Bonzini wrote: > > > On 31/10/2016 16:28, Eric Blake wrote: >> On 10/31/2016 06:39 AM, Paolo Bonzini wrote: >>> An unrolled loop avoids the cost of spawning sed in AS_TR_SH and >>> AS_TR_CPP. Prefer it if there is nothing in

Re: [PATCH 3/3] autoconf: refine quadrigraph test in _AC_DEFINE_UNQUOTED

s present to avoid confusing m4 with comments, > +# but quadrigraphs are fine in that case. > m4_define([_AC_DEFINE_UNQUOTED], > -[m4_if(m4_bregexp([$1], [\\\|`\|\$(\|\${\|@]), [-1], > +[m4_if(m4_bregexp([$1], [#\|\\\|`\|\(\$\|@S|@\)\((|{|@{:@\)]), [-1], Line noise for the win! >

Re: [PATCH 2/3] autoconf: prefer an unrolled loop for trivial AC_CHECK_HEADERS

c_includes_default])]dnl > + [sys/types.h sys/stat.h strings.h inttypes.h stdint.h unistd.h])]dnl This one, I'm worried about. $ac_includes_default is a shell variable not documented in the manual (so we can probably get away with changing it), but doesn't it exist so that projects can r

Re: [PATCH 1/3] autoconf: prefer an unrolled loop for trivial AC_CHECK_FUNCS

[$3])dnl]) > +[m4_if([$2$3]AS_LITERAL_IF([$1], [yes], [no]), []yes, Why []yes instead of the more typical [yes] ? If the user has (unwisely) defined yes as a macro, your version will compare against their expansion, instead of against the intended literal. -- Eric Blake eblake redh

Re: [PATCH] oldnames: autoupdate AM_PROG_MKDIR_P

+++ b/lib/autoconf/oldnames.m4 > @@ -90,3 +90,4 @@ AU_ALIAS([AM_EXEEXT], [AC_EXEEXT]) > # AU_ALIAS([AM_PROG_LIBTOOL],[AC_PROG_LIBTOOL]) > AU_ALIAS([AM_MINGW32], [AC_MINGW32]) > AU_ALIAS([AM_PROG_INSTALL], [AC_PROG_INSTALL]) > +AU_ALIAS([AM_PROG

Re: [PATCH v2] AC_HEADER_MAJOR: port to glibc 2.25

go either way as long as the two lines are consistent, but the #ifdef approach seems less likely to bother people that use the gcc warning. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

[PATCH v2] AC_HEADER_MAJOR: port to glibc 2.25

-updated projects. Signed-off-by: Eric Blake <ebl...@redhat.com> --- Thanks for the wordsmithing help, and forcing me to think about mingw. This version updates some wording, and changes the macro to leave the relative order of mkdev.h vs. sysmacros.h checking unchanged (by merely wea

Re: [PATCH] AC_HEADER_MAJOR: port to glibc 2.25

uld check sys/types.h last. That will future-proof > against C libraries where these functions are in both sys/mkdev.h and > sys/types.h deciding to do the same deprecation that glibc has done. Good idea. Will respin to check mkdev.h first (as before), then sysmacros.h, and sys/types.h last. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

[PATCH] AC_HEADER_MAJOR: port to glibc 2.25

for sysmacros.h first, rather than after determining if sys/types.h pollutes the namespace. * doc/autoconf.texi (Particular Headers) : Expand details on usage, and on workarounds for non-updated projects. Signed-off-by: Eric Blake <ebl...@redhat.com> --- I'd like a review on this patch before p

[PATCH] doc: use @xref correctly

Silences this warning from new-enough texinfo: ./doc/autoconf.texi:14236: warning: @xref node name should not contain `.' * doc/autoconf.texi (Macro Definitions): No need for .info. Signed-off-by: Eric Blake <ebl...@redhat.com> --- Pushing this obvious fix. doc/autoconf.texi | 2 +-

[PATCH] doc: mention 'for' syntax issue on older shells

Based on a report by Michael Felt, via Paul Eggert on the coreutils list. * doc/autoconf.texi (Limitations of Builtins) for: Document problem with 'for var in ;'. Signed-off-by: Eric Blake ebl...@redhat.com --- doc/autoconf.texi | 34 ++ 1 file changed, 34

Re: m4_pattern_forbid documentation

On 04/21/2015 06:51 AM, Matěj Týč wrote: On 21.4.2015 14:37, Eric Blake wrote: ... This reads a bit awkwardly; I would like to propose this alternate wording, still in your name. If you agree, I'll go ahead and push. Great, go ahead and fix the wording. Done. Thanks again for your first

Re: allow autom4te to accept -D and -U as m4 does

what you actually did. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] lib: use shorter way to test if variable is set

On 04/15/2015 04:58 PM, Eric Blake wrote: Based on an idea by Bernhard Reutner-Fischer. We frequently used the idiom of 'test ${var+set} = set' to test if $var was set to a non-empty string, but this can portably be trimmed to a more compact 'test ${var+y}' for a smaller configure file

Re: m4_pattern_forbid documentation

=BD=C4=8D?= matej@gmail.com Date: Thu, 16 Apr 2015 23:00:24 +0200 Subject: [PATCH] m4_pattern_forbid: better documentation Give a more concrete description of what the m4_pattern_forbid thingy that pretends it is a macro accepts as an argument. Signed-off-by: Eric Blake ebl...@redhat.com

[PATCH] lib: use shorter way to test if variable is set

. (AS_VAR_TEST_SET): Use shorter sequence. Signed-off-by: Eric Blake ebl...@redhat.com --- Finally finding time to revisit this; here's what I will probably push, if no negative review comments are raised in a couple days. I'll probably also work on a second patch that scrubs obvious uses of 'test -n $var

Re: [PATCH 2/4] AC_PROG_LEX: Rephrase LEX is set test

], [AC_PROG_LEX]) AC_DEFUN_ONCE([AC_PROG_LEX], [AC_CHECK_PROGS(LEX, flex lex, :) -if test x$LEX != x:; then +if [[ ${LEX:+y} ]]; then NACK. This is checking if $LEX is specifically something other than ':', not whether it is empty. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [PATCH] Replace 'test ${var+set} = set' with 'test -n ${var+set}'

On 04/09/2015 12:49 AM, Paul Eggert wrote: Eric Blake wrote: test ${var+y} Hah! Here's something that's one byte shorter: ${var+:} [ ] It may be clearer to write it more in the style you used: [ ${var+y} ] Both of these work with Solaris 10 /bin/sh. But both become more

Re: [PATCH 3/4] AC_PROG_MKDIR_P: Also accept BusyBox mkdir -p

On 04/09/2015 08:51 AM, Eric Blake wrote: On 04/09/2015 06:43 AM, Bernhard Reutner-Fischer wrote: 2015-04-08 Bernhard Reutner-Fischer rep.dot@gmail.com * lib/autoconf/programs.m4 (AC_PROG_MKDIR_P): Accept BusyBox. Signed-off-by: Bernhard Reutner-Fischer rep.dot@gmail.com

Re: [PATCH v2 1/4] Replace 'test ${var+set} = set' with '[ ${var+y} ]'

that we aren't quite yet at the fully polished version. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH v2 1/4] Replace 'test ${var+set} = set' with '[ ${var+y} ]'

([bad as_lineno at depth 2]) AS_LINENO_POP test $as_lineno = || AS_ERROR([bad as_lineno at depth 1]) AS_LINENO_POP -test x${as_lineno+set} = xset AS_ERROR([as_lineno set at depth 0]) +test ${as_lineno+y} AS_ERROR([as_lineno set at depth 0]) Ahh, you kept 'test' here. -- Eric

Re: [PATCH 3/4] AC_PROG_MKDIR_P: Also accept BusyBox mkdir -p

acb200444395b8108b42dfacd54dabd02d966bd3 Mon Sep 17 00:00:00 2001 From: Eric Blake ebl...@redhat.com Date: Thu, 9 Apr 2015 08:47:10 -0600 Subject: [PATCH] AC_PROG_MKDIR_P: reduce macro output size Merging two case globs into one gives slightly smaller files and less time spent in shell globbing on systems that lack GNU mkdir. * lib

Re: [PATCH 0/4] misc test(1) invocation tweaks

copyright assignment with FSF (I see you've done it before on at least gcc). -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 4/4] _AC_OUTPUT_FILES_PREPARE: Rephrase CONFIG_FILES test

? -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] Replace 'test ${var+set} = set' with 'test -n ${var+set}'

On 04/08/2015 04:25 PM, Eric Blake wrote: I can beat it in an amortized way, by doing: f(){ false;} ${var+:} f Or shorter: f(){ eval \${$1+:} [ ];} f var but only after I have at least 4 tests at 10 bytes each making up for the 12 bytes spent on the function definition (a longer

Re: [PATCH] Replace 'test ${var+set} = set' with 'test -n ${var+set}'

On 04/08/2015 04:25 PM, Eric Blake wrote: And in modern shell, 'test -n ...' is strictly equivalent to 'test ...' (not so in ancient shell, but those are getting fewer and farther between) - if we did appropriate pre-filtering tests, we could get away with 15 bytes: test ${var+y} Or even

Re: [PATCH] Replace 'test ${var+set} = set' with 'test -n ${var+set}'

approach at the moment, if properly audited to make sure we aren't going to rely on $? during the time where we are probing for shell features in order to re-exec away from Solaris /bin/sh. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [PATCH] Fix spurious testsuite failure when /bin/sh is dash

. (parallel syntax error): Likewise. Signed-off-by: Stefano Lattarini stefano.lattar...@gmail.com --- tests/autotest.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [PATCH] docs: mention that not all values can be exported

On 09/29/2014 04:44 PM, Zack Weinberg wrote: On Sat, Sep 27, 2014 at 8:26 PM, Eric Blake ebl...@redhat.com wrote: There has been a LOT of news about bash's Shell Shock bug lately. Document some of the ramifications it has on portable scripting. I think this is a good idea in the abstract

[PATCH] docs: mention that not all values can be exported

There has been a LOT of news about bash's Shell Shock bug lately. Document some of the ramifications it has on portable scripting. * doc/autoconf.texi (Limitations of Builtins) export: Add some details about Shell Shock CVE-2014-6271. Signed-off-by: Eric Blake ebl...@redhat.com --- I'm still

Re: [PATCH 4/4] git-version-gen: remove cr as well

the script verbatim from gnulib), and in a way that doesn't use a raw CR in the file. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/4] AC_CACHE_SAVE: treat x: as an absolute path as well

as the destination? That is, you don't try to ever save the cache as 'c:', but as 'c:/file', in which case the pattern already matches. Without an example of something that is broken without this patch, I'm less inclined to apply it. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [PATCH 3/4] _AS_LN_S_PREPARE: default to 'cp -pR' on OS/2

test ! -f conf$$.exe + test -z $OS2_SHELL || as_ln_s='cp -pR' Is the goal here to unconditionally use 'cp -pR' if OS2_SHELL is set? elif ln conf$$.file conf$$ 2/dev/null; then as_ln_s=ln else -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization

Re: [PATCH 2/4] AC_SITE_LOAD: add OS/2-specific initialization

processes? This might be better as two separate patches, since it is doing two unrelated changes. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 2/4] AC_SITE_LOAD: add OS/2-specific initialization

On 09/22/2014 08:39 PM, KO Myung-Hun wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi/2. Eric Blake wrote: On 09/22/2014 12:59 AM, KO Myung-Hun wrote: \ may be recognized as an escape character on some shells such as pdksh. And the executables on OS/2 have .exe as an extension

Re: Followup on AC_LANG(java)

patch is one of the reasons I still haven't done a release. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Add gtk-doc usage check to autoreconf

non-trivial in size. Are you okay with assigning copyright to the FSF? If so, I can work with you off-list to get that going. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: AM_CONDITIONAL fails with line break at the end of $2

-z ${$1_TRUE} test -z ${$1_FALSE}; then -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: AM_CONDITIONAL fails with line break at the end of $2

On 07/17/2014 12:44 PM, Dimitrios Apostolou wrote: Hi Erik, thank you for forwarding to the appropriate list! On Thu, 17 Jul 2014, Eric Blake wrote: I don't know if automake should work around your bad syntax, or if you should just fix your configure.ac to use correct syntax to begin

[PATCH] m4sh: allow trailing newlines in shell conditions

/autoconf/programs.m4 (_AC_PATH_PROGS_FEATURE_CHECK): Likewise. * tests/m4sh.at (AS_IF and AS_CASE): Test it. Signed-off-by: Eric Blake ebl...@redhat.com --- lib/autoconf/general.m4 | 3 ++- lib/autoconf/libs.m4 | 3 ++- lib/autoconf/programs.m4 | 3 ++- lib/m4sugar/m4sh.m4 | 15

Re: [PATCH] m4sh: allow trailing newlines in shell conditions

On 07/17/2014 03:31 PM, Paul Eggert wrote: Thanks, this patch seems like the right thing to do to handle this sort of problem. Pushed. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Remove unused function warning from AC_C_INLINE

@@ for ac_kw in inline __inline__ __inline; do [#ifndef __cplusplus typedef int foo_t; static $ac_kw foo_t static_foo () {return 0; } -$ac_kw foo_t foo () {return 0; } +$ac_kw foo_t foo () {static_foo(); } Don't you still need the 'return' ? -- Eric Blake eblake redhat com+1-919-301-3266

Re: feature request: making invalid feature request error more friendly

consistent with the rest of the file). From da84360b9775510f219c6022514fe390c4fadf44 Mon Sep 17 00:00:00 2001 From: Eric Blake ebl...@redhat.com Date: Fri, 30 May 2014 08:55:10 -0600 Subject: [PATCH] AC_INIT: quote invalid feature names Changes: configure: error: invalid feature name: debug

Re: [PATCH] Change main () to main (void) for C/C++

/doc/autoconf.texi @@ -9132,7 +9132,7 @@ on a system with @command{gcc} installed, results in: const char hw[] = Hello, World\n; int -main () +main (void) Thanks again for doing this, and sorry for the delay. Now pushed. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: Turn on compiler warnings by default for AC_PROG_CC, AC_PROG_CXX AC_PROG_FC

the probe to reject unknown warnings). Overall, I think migrating the core functionality of gnulib's warnings module into autoconf does sound useful, so I'm pleased that you are pursuing this, and I will answer your off-list query about copyright assignment. -- Eric Blake eblake redhat com+1

Re: [PATCH] doc: give an example of using the macro for pkg-config

On 01/27/2014 11:39 AM, Eric Blake wrote: The autoconf manual doesn't mention any examples of actually using m4_pattern_forbid. Yet this is the perfect macro for avoiding the all-too-common failure mode of configure dying with: checking if libxml2 is present... ./configure: line 11586

[PATCH] doc: give an example of using the macro for pkg-config

about missing third-party macros. Based on a mailing list report by Daniel Pocock: http://lists.gnu.org/archive/html/autoconf/2014-01/msg00030.html * doc/autoconf.texi (Forbidden Patterns): Add examples. Signed-off-by: Eric Blake ebl...@redhat.com --- No wonder it took us a couple of iterations

[PATCH 1/2] maint: bump copyright to 2014

Done via 'make update-copyright', since all files are effectively modified and distributed this year via public version control. * all files: Update copyright year. --- AUTHORS | 2 +- BUGS| 2 +- HACKING | 2 +- Makefile.am

[PATCH 2/2] maint: fix 'make syntax-check' findings

-off-by: Eric Blake ebl...@redhat.com --- bin/local.mk | 2 +- lib/autoconf/c.m4 | 2 +- lib/local.mk | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/local.mk b/bin/local.mk index 0edfbbe..b599a2b 100644 --- a/bin/local.mk +++ b/bin/local.mk @@ -46,7 +46,7

Re: [PATCH 3/6] Modernize AC_INCLUDES_DEFAULT and friends.

On 09/21/2013 06:05 PM, Zack Weinberg wrote: On Sat, Sep 21, 2013 at 9:29 AM, Eric Blake ebl...@redhat.com wrote: On 09/14/2013 10:22 AM, Zack Weinberg wrote: ... (AC_HEADER_STDC, AC_UNISTD_H): AU_DEFUN to trigger _AC_INCLUDES_DEFAULT_REQUIREMENTS if it hasn't already happened

Re: [PATCH 2/6] AC_CHECK_HEADER/AC_CHECK_HEADERS: complete transition to compile tests.

. But as this is undocumented, and as the preproc variant outputs a warning, the users deserve a warning for using undocumented macros. I agree with the decision. ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP

Re: [PATCH 3/6] Modernize AC_INCLUDES_DEFAULT and friends.

, / ACK with those changes. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 4/6] Use AC_CHECK_HEADERS_ONCE for the tests done by AC_INCLUDES_DEFAULT.

$ac_includes_default, not AC_INCLUDES_DEFAULT. (_AC_INCLUDES_DEFAULT_REQUIREMENTS): Use AC_CHECK_HEADERS_ONCE. Signed-off-by: Zack Weinberg za...@panix.com --- lib/autoconf/headers.m4 | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) ACK -- Eric Blake eblake

Re: [PATCH 5/6] Use AC_CHECK_{DECLS, FUNCS, HEADERS}_ONCE more in specific-check macros.

(HAVE_DOPRNT, 1, +[AC_CHECK_FUNCS_ONCE([vprintf]) +AS_IF([test $ac_cv_func_vprintf = no], Unsafe - the user can pre-populate the cache with something that would break 'test'. Use what we do elsewhere: AS_IF([test x$ac_cv_func_vprintf = xno], ACK with that fix. -- Eric Blake eblake redhat com

Re: [PATCH 6/6] Expose the checks done by AC_INCLUDES_DEFAULT as a public macro.

. Even if people don't use it, it's nice to have a single file for history of when public macros were introduced. ACK with that addition. And thanks again for tackling this! -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: problem with ./configure

On 07/19/2013 07:03 AM, Eric Blake wrote: On 07/19/2013 06:55 AM, BOUQUE Anais wrote: Hello, I use autoreconf and configure, and I have a problem using configure : I use the cl6x compiler, (./configure --host=c6x CC=cl6x) but when configure does cl6x -version or cl6x-v or cl6x -V

Re: problem with ./configure

On 09/12/2013 10:05 AM, Zack Weinberg wrote: On 2013-09-12 11:25 AM, Eric Blake wrote: -for ac_option in --version -v -V -qversion; do +for ac_option in --version -v -V -qversion -version; do _AC_DO_LIMIT([$ac_compiler $ac_option AS_MESSAGE_LOG_FD]) This isn't anything to do with your

[PATCH] AC_INIT: add --runstatedir option to configure

Directory Variables): Document new option. (Site Defaults): Mention typical use within a distro. * NEWS: Mention the addition. Signed-off-by: Eric Blake ebl...@redhat.com --- I don't plan to push this until the make-stds.texi changes actually go live (particarly in case we change our minds

Re: [PATCH 2/3] Modernize AC_INCLUDES_DEFAULT and friends.

# -- Another too-short divider. # AU::AC_USG # -- -# Define `USG' if string functions are in strings.h. +# Define `USG' if string functions are *not* in strings.h. Have we seriously been documenting it incorrectly for this long? Looking nice! -- Eric Blake eblake redhat com

  1   2   3   4   5   6   7   8   9   10   >