Re: [PATCH v2] specify void prototype for functions with no parameters

2022-09-19 Thread Sam James
> On 30 Aug 2022, at 22:53, Paul Eggert wrote: > > On 8/29/22 21:35, Khem Raj wrote: >> Compilers defaulting to C99 flag such functions as warning which fails >> to compile when using -Werror > > As mentioned earlier, projects should not use -Werror when configuring, for > several reasons (th

Re: [PATCH v2] specify void prototype for functions with no parameters

2022-09-18 Thread Paul Eggert
On 9/18/22 19:56, Sam James wrote: In order to help with the rather mass breakage with newer Clang, could the autoconf maintainers consider a small new release with this fix? I doubt whether we have the time to do anything other than the usual, which is generate a new release at ab appropriat

Re: [PATCH v2] specify void prototype for functions with no parameters

2022-09-02 Thread Paul Eggert
On 9/2/22 10:42, Zack Weinberg wrote: Why the #undef malloc here? It's just a cut-and-paste typo. Thanks for reporting that. I installed the patch after correcting the typo.

Re: [PATCH v2] specify void prototype for functions with no parameters

2022-09-02 Thread Zack Weinberg
On Thu, Sep 1, 2022, at 7:18 PM, Paul Eggert wrote: > Thanks for checking. How about the attached patch instead? It's closer > to what you originally suggested. > > Zack, any thoughts on this sort of thing? ... > --- a/doc/autoconf.texi > +++ b/doc/autoconf.texi > @@ -5460,9 +5460,8 @@ the @samp{

Re: [PATCH v2] specify void prototype for functions with no parameters

2022-09-02 Thread Khem Raj
On Thu, Sep 1, 2022 at 4:18 PM Paul Eggert wrote: > > On 9/1/22 11:53, Khem Raj wrote: > > > > I ran into few problems. Some of them were latent issues[1] but some > > are problems[2] especially using AC_CHECK_FUNCS when default compiler > > is C++ compiler not C compiler > > > Thanks for checkin

Re: [PATCH v2] specify void prototype for functions with no parameters

2022-09-01 Thread Paul Eggert
On 9/1/22 11:53, Khem Raj wrote: I ran into few problems. Some of them were latent issues[1] but some are problems[2] especially  using AC_CHECK_FUNCS when default compiler is C++ compiler not C compiler Thanks for checking. How about the attached patch instead? It's closer to what you or

Re: [PATCH v2] specify void prototype for functions with no parameters

2022-09-01 Thread Khem Raj
On 8/30/22 2:53 PM, Paul Eggert wrote: On 8/29/22 21:35, Khem Raj wrote: Compilers defaulting to C99 flag such functions as warning which fails to compile when using -Werror As mentioned earlier, projects should not use -Werror when configuring, for several reasons (this is just one). After y

Re: [PATCH v2] specify void prototype for functions with no parameters

2022-08-30 Thread Paul Eggert
On 8/29/22 21:35, Khem Raj wrote: Compilers defaulting to C99 flag such functions as warning which fails to compile when using -Werror As mentioned earlier, projects should not use -Werror when configuring, for several reasons (this is just one). After you mentioned rsync was using something

[PATCH v2] specify void prototype for functions with no parameters

2022-08-29 Thread Khem Raj
Compilers defaulting to C99 flag such functions as warning which fails to compile when using -Werror Fixes error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] Signed-off-by: Khem Raj --- v2: Drop changes in the c++ checks lib/auto