Tom Tromey [EMAIL PROTECTED] writes:
"Akim" == Akim Demaille [EMAIL PROTECTED] writes:
Akim * automake.in: Formatting and mying changes.
Ok.
Akim + # FIXME: This code is mad, rewrite!
At the time it was hard to find a better solution.
Maybe we can do
Tom Tromey wrote:
"Akim" == Akim Demaille [EMAIL PROTECTED] writes:
Akim Six, six for them! (I'm not counting those for file handles,
Akim which perl refuses as my, not sure to understand why).
The way file handles work is another reason to dislike Perl. At
least, I've always found them
Tom Tromey [EMAIL PROTECTED] writes:
Targets which are presented to the user must be defined regardless of
whether they have any effect. So for instance `install-exec' must
always exist.
I understand this. Then I'll have a list of required targets and
output them in any case.
Akim Also,
Pavel Roskin [EMAIL PROTECTED] writes:
Hello, Akim!
Is this only GNU Make, or a general property?
/tmp % cat Makefile 21:37 remo
all: foo bar
.PHONY: all foo
/tmp % make 21:37
Pavel Roskin [EMAIL PROTECTED] writes:
Hello, Akim!
You recently applied a patch to tests/target-cflags.test without
mentioning it in ChangeLog. Maybe you didn't mean to commit that change?
If you did, then two small fixes are needed:
1) You should run ./foo instead /foo
2) bash
Tom Tromey [EMAIL PROTECTED] writes:
Akim --
One problem with target/variable separation is that am_line_error
accepts a variable name as its first argument. If they are separate
then some calls to this may become ambiguous. This can probably be
fixed, but it is something to be aware
Tom Tromey [EMAIL PROTECTED] writes:
Akim Below are first presented the Makefiles of Automake. There is
Akim obviously a problem, which I do not solve in this already too
Akim long patch, but will address later: what do with empty targets.
This patch is ok, but please don't check it in
"Tom" == Tom Tromey [EMAIL PROTECTED] writes:
Following up my own post...
Tom if FOO
Tom var = a b c
Tom else
Tom var = d e f
Tom endif
Tom derived = $(var:%=%.c)
Tom Will this work correctly? In this situation we have to give
Tom `derived' the same conditions as
"Akim" == Akim Demaille [EMAIL PROTECTED] writes:
If it is a dependency then it won't work properly with a parallel
make. That's because the -hook for must be run after all the other
rules.
Akim Why don't we use dependencies to say that -hook must be run
Akim last, instead of using the
Tom Tromey [EMAIL PROTECTED] writes:
"Akim" == Akim Demaille [EMAIL PROTECTED] writes:
Akim * automake.in: Mying changes.
Akim (handle_tags): Fix a bug uncovered by the previous mying changes:
Akim transform CONFIG into $config, not $xform.
I think this has a
Tom Tromey [EMAIL PROTECTED] writes:
"Akim" == Akim Demaille [EMAIL PROTECTED] writes:
Akim * automake.in: Mying changes.
Akim (handle_tags): Fix a bug uncovered by the previous mying changes:
Akim transform CONFIG into $config, not $xform.
I think this has a
I think this has a bug.
It is ok if you fix it though.
Akim oops, I missed that part. What do you mean?
I just meant the =~ reversal I pointed out. I only cited the
ChangeLog entry so we'd be clear on which patch. Sorry for the
confusion.
Tom
Tom Tromey [EMAIL PROTECTED] writes:
Akim -local ($in_ac_output, $in_ac_replace) = (0, 0);
Akim +# Watchout: these guys need dynamic scope!
Why remove the other local() though?
Those variables also have dynamic scope :-(
Hm, do they?
I moved them inside the routines which uses
"Akim" == Akim Demaille [EMAIL PROTECTED] writes:
Akim -local ($in_ac_output, $in_ac_replace) = (0, 0);
Akim +# Watchout: these guys need dynamic scope!
Why remove the other local() though?
Those variables also have dynamic scope :-(
Akim Hm, do they?
Ok, thanks.
Tom
Tom Tromey [EMAIL PROTECTED] writes:
"Akim" == Akim Demaille [EMAIL PROTECTED] writes:
Akim In fact, I've had to finish the job, because the following test
Akim was falling:
Akim cat Makefile.am 'END'
Akim bin_PROGRAMS = consud
Akim ## Note next line is target, not
Tom Tromey wrote:
if FOO
var = a b
endif
derived = $(var:%=%.c)
if BAR
var = c d
endif
Isn't the order irrelevant here since derived won't be evaluated until
it's used?
Um, the gmake manual calls this "expanded when read, except for the shell
commands in
"Tom" == Tom Tromey [EMAIL PROTECTED] writes:
Tom 2. Pushing the hook out means that if the user has a -local as
Tom well as a -hook then we have to rewrite the -local target to add
Tom a new dependency. We've never rewritten user targets, so this is
Tom a major(-ish) change to contemplate.
"Derek" == Derek R Price [EMAIL PROTECTED] writes:
if FOO
var = a b
endif
derived = $(var:%=%.c)
if BAR
var = c d
endif
Derek Isn't the order irrelevant here since derived won't be
Derek evaluated until it's used?
No, because we're talking about having automake itself expand the
18 matches
Mail list logo
